Repository navigation
ci: fix electron types in product builds - #332539
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures product builds prepare Electron typings after distro overrides are applied.
Changes:
- Updates the distro revision.
- Adds Electron type preparation to all product compile pipelines.
- Removes Electron typings from the shared
node_modulescache.
Show a summary per file
| File | Description |
|---|---|
package.json |
Updates distro revision. |
build/azure-pipelines/win32/steps/product-build-win32-compile.yml |
Prepares product Electron types. |
build/azure-pipelines/win32/sdl-scan-win32.yml |
Prepares types before SDL compilation. |
build/azure-pipelines/web/product-build-web.yml |
Prepares types before web compilation. |
build/azure-pipelines/product-quality-checks.yml |
Prepares types for quality checks. |
build/azure-pipelines/linux/steps/product-build-linux-compile.yml |
Prepares Linux build types. |
build/azure-pipelines/darwin/steps/product-build-darwin-compile.yml |
Prepares macOS build types. |
build/azure-pipelines/alpine/product-build-alpine.yml |
Prepares Alpine build types. |
build/azure-pipelines/common/listNodeModules.ts |
Excludes Electron typings from dependency archives. |
build/azure-pipelines/common/computeNodeModulesCacheKey.ts |
Removes the obsolete listing-script cache input. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 10/10 changed files
- Comments generated: 0
- Review effort level: Balanced
Robo (deepak1556)
marked this pull request as ready for review
August 25, 2026 15:25
Robo (deepak1556)
enabled auto-merge (squash)
August 25, 2026 15:25
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Ladislau Szomoru (@lszomoru)Matched files:
|
Anthony Kim (anthonykim1)
approved these changes
Aug 25, 2026
Logan Ramos (lramos15)
added a commit
that referenced
this pull request
Aug 25, 2026
Electron types used to ride along in the node_modules cache. #332539 took them out of it and added a download step to the Azure pipelines, but the GitHub Actions compile job skips `npm ci` whenever that cache hits, so it never downloaded them and every PR failed with "Cannot find module 'electron'". Add the same step the Azure pipelines got. It re-checksums an existing file and returns early, so a cache miss doesn't pay for it twice. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 376c7f32-2259-472d-a00a-ade0de4b8f11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #331833