refactor: trim SKILL.md for token efficiency#30
Merged
Merged
Conversation
Move detailed PR commit cleanup content to references/pr-commit-cleanup.md. Remove actionlint, asset templates, related skills, and external resources sections (already covered in reference files). Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
There was a problem hiding this comment.
Pull request overview
This PR refactors the github-project skill documentation to improve token efficiency by trimming SKILL.md from 731 words to 352 words (52% reduction). The refactoring extracts detailed troubleshooting content to a new reference file while removing redundant sections that are already covered in existing reference documentation. The reorganization better aligns with writing-skills standards that require SKILL.md files to be under 500 words, with detailed content belonging in reference files loaded on demand.
Changes:
- Created new reference file
pr-commit-cleanup.mdwith enhanced content about GitHub fork merge base issues - Removed redundant sections from SKILL.md: PR commit cleanup (moved), asset templates table (redundant), actionlint guide (covered in reference), related skills, and external resources
- Reorganized SKILL.md to move "Running Scripts" section before "References" section and added proper reference links to extracted content
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
skills/github-project/references/pr-commit-cleanup.md |
New reference file containing enhanced troubleshooting guide for fork merge base issues, including why it happens and alternative approaches |
skills/github-project/SKILL.md |
Trimmed from 731 to 352 words by moving PR commit cleanup content to reference file, removing redundant sections (asset templates, actionlint, related skills, external resources), reorganizing sections, and adding proper reference links |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CybotTM
added a commit
that referenced
this pull request
Mar 30, 2026
…conversation resolution Add mechanical checkpoints (GH-30, GH-31) that verify enforce_admins and required_conversation_resolution via GitHub API, plus an LLM review checkpoint (GH-32) for the combined audit. Without enforce_admins, admins can bypass all branch protection rules including unresolved review threads. Updates verify script to check these settings and security-config.md reference to document the enforce_admins requirement.
4 tasks
3 tasks
CybotTM
added a commit
that referenced
this pull request
May 4, 2026
…allowlist The automated-assessment runner enforces a command allowlist that rejects command-chaining metacharacters (; && || backticks $()) and only accepts specific base commands. Four checkpoints failed allowlist validation and were never actually evaluated against target projects. GH-6 and GH-23 used `test -f X || test -f Y` chains to test for any of several files. Rewritten as `type: file_exists` with brace expansion, which is the runner's first-class idiom for "any of these files". GH-30 and GH-31 used multi-line YAML literal-block scalars (`target: |`) to invoke `gh api` for branch protection audits. The runner's simple line parser sees the literal-block indicator as the first token and rejects with "'|' not in allowed command whitelist". Even with the allowlist passing, these cannot be executed mechanically — they require GitHub API auth context. Converted to `type: gh_api`, which the runner recognises and skips with a clear evidence string. The semantically equivalent audit is preserved in GH-32 (llm_reviews).
CybotTM
added a commit
that referenced
this pull request
May 4, 2026
…ert GH-5 demotion Addresses PR #69 review feedback: GH-2 (Copilot, Gemini): added missing license filenames the skill itself documents — COPYING, COPYING.md, COPYING.txt, LICENSE-BSD-2-Clause, LICENSE-BSD-3-Clause, LICENSE-GPL-2.0, LICENSE-GPL-3.0, LICENSE-LGPL, LICENSE-LGPL-3.0, LICENSE-AGPL-3.0, LICENSE-MPL-2.0. GH-5 (Copilot): reverted demotion to info — CODEOWNERS must exist in the repository itself on the default branch (.github/, root, or docs/), and the org-wide .github mechanism explicitly does NOT cover it (that mechanism only provides templates and community-health files, never review-routing rules). Severity restored to warning; description corrected to remove the misleading org-wide claim. GH-6 (Gemini): added .github/dependabot.yaml, renovate.json5, renovate config variants, and the .json5 form for Renovate. GH-13/14 (Gemini follow-on): brace-expanded targets to also accept .github/dependabot.yaml. GH-19/20/21 (Gemini): glob target now `.github/workflows/*.{yml,yaml}` to match either extension. GH-24..27 (Gemini): glob target now `.github/workflows/auto-merge*.{yml,yaml}`. Push-back on Copilot 'auto-merge.yml weakens GH-23' comment: GH-24..27 already use a glob (auto-merge*.yml — now expanded to *.{yml,yaml}) that matches both filenames, so adding auto-merge.yml to GH-23 does not produce false failures downstream. GH-30/31 desc: wrapped long lines as YAML folded scalars (no impact on runner — these are gh_api types, the desc field is human-readable). .yamllint.yml: line-length bumped 160 → 360 to accommodate single-line brace-expansion targets that the runner cannot read as folded scalars (the runner's parser is bash regex, not a YAML library).
2 tasks
CybotTM
added a commit
that referenced
this pull request
May 5, 2026
- GH-7: add docs/ paths to target list and accept both upper/lowercase PULL_REQUEST_TEMPLATE.md in org_provides via brace expansion. - GH-8/09: drop redundant .github/ prefix from org_provides (path is resolved against the {owner}/.github repo root) and accept both .yml and .md forms for the org-wide fallback so repos following either Netresearch convention pass. - GH-32: align prompt with GH-30 demote — enforce_admins is advisory (info), only required_conversation_resolution remains error-level. Prevents repos following the org default (enforce_admins=false) from failing GH-32 even though GH-30 was demoted to info. Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
CybotTM
added a commit
that referenced
this pull request
May 5, 2026
netresearch's org-wide default leaves enforce_admins=false so admins retain bypass for emergency response — none of the surveyed mature repos enables it. Forcing severity=error against this org policy created persistent red findings everywhere. Demoted to info so the checkpoint still reminds reviewers but doesn't block as a hard failure. Description updated to make the policy choice explicit. Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
CybotTM
added a commit
that referenced
this pull request
May 5, 2026
- GH-7: add docs/ paths to target list and accept both upper/lowercase PULL_REQUEST_TEMPLATE.md in org_provides via brace expansion. - GH-8/09: drop redundant .github/ prefix from org_provides (path is resolved against the {owner}/.github repo root) and accept both .yml and .md forms for the org-wide fallback so repos following either Netresearch convention pass. - GH-32: align prompt with GH-30 demote — enforce_admins is advisory (info), only required_conversation_resolution remains error-level. Prevents repos following the org default (enforce_admins=false) from failing GH-32 even though GH-30 was demoted to info. Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
references/pr-commit-cleanup.mdContext
Per writing-skills standards, SKILL.md should be under 500 words. Detailed content belongs in reference files loaded on demand.