fix: align verify script with README merge strategy#7
Merged
Conversation
The verify script was checking for rebase-only configuration while the README recommends merge-commits-only. This inconsistency caused confusion when the script reported failures for correctly configured repositories. Changes: - Check for merge commits enabled (not rebase) - Check for rebase disabled (not enabled) - Update info messages to reflect merge-commits-only strategy - Add comment explaining the rationale (merge commits preserve history, strict branch protection ensures rebased PRs)
2 tasks
CybotTM
added a commit
that referenced
this pull request
May 5, 2026
- GH-7: add docs/ paths to target list and accept both upper/lowercase PULL_REQUEST_TEMPLATE.md in org_provides via brace expansion. - GH-8/09: drop redundant .github/ prefix from org_provides (path is resolved against the {owner}/.github repo root) and accept both .yml and .md forms for the org-wide fallback so repos following either Netresearch convention pass. - GH-32: align prompt with GH-30 demote — enforce_admins is advisory (info), only required_conversation_resolution remains error-level. Prevents repos following the org default (enforce_admins=false) from failing GH-32 even though GH-30 was demoted to info. Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
CybotTM
added a commit
that referenced
this pull request
May 5, 2026
GH-3 (SECURITY.md), GH-4 (CONTRIBUTING.md), GH-7 (PR template) declare org_provides: paths so the runner falls back to `gh api repos/{owner}/.github/contents/<path>` when the local file is missing. Repos that opt into org-wide community-health files (the documented GitHub default) now stop being flagged. GH-7 also accepts both PULL_REQUEST_TEMPLATE.md and the lowercase pull_request_template.md (which is what netresearch/.github actually uses) — GitHub treats these case-insensitively. GH-5 (CODEOWNERS) intentionally stays local-only — GitHub's review routing only honours CODEOWNERS in the consuming repo, not the org's .github fallback. GH-8 / GH-9 (issue templates) declare org_provides for completeness but most orgs don't ship default issue templates; for those repos this still surfaces as a finding. When an org does provide them at {owner}/.github/.github/ISSUE_TEMPLATE/<name>, the checkpoint passes. Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
CybotTM
added a commit
that referenced
this pull request
May 5, 2026
- GH-7: add docs/ paths to target list and accept both upper/lowercase PULL_REQUEST_TEMPLATE.md in org_provides via brace expansion. - GH-8/09: drop redundant .github/ prefix from org_provides (path is resolved against the {owner}/.github repo root) and accept both .yml and .md forms for the org-wide fallback so repos following either Netresearch convention pass. - GH-32: align prompt with GH-30 demote — enforce_admins is advisory (info), only required_conversation_resolution remains error-level. Prevents repos following the org default (enforce_admins=false) from failing GH-32 even though GH-30 was demoted to info. Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The verify script was checking for rebase-only configuration while the README recommends merge-commits-only. This inconsistency caused repos configured per README to be flagged as incorrect.
Changes
Rationale
Merge commits with
strict: truebranch protection provides: