Skip to content

Favorite received share shows "Add to favorites" on its own root #4187

Closed

Description

@AlexAndBear

Initial Checklist

  • I understand this is a bug report and questions should be posted in the Community Discussions
  • I searched issues and couldn’t find anything (or linked relevant results below)

Bug Description

A received share that is a favorite shows "Add to favorites" and an empty star once you open it. For a share root, loaderSpace.ts replaces the WebDAV folder with one built from the Graph share and only keeps its permissions, so the favorite state is lost.

Reproduction Steps

  1. Share a folder with another user
  2. As the recipient, add the share to favorites in Shared with me
  3. Open the share and open "Show actions for current folder" in the breadcrumb, or the sidebar of the open folder

Expected Outcome

"Remove from favorites" and a filled star.

Actual Outcome

"Add to favorites" and an empty star, until the action is used once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions