Skip to content

fix: keep favorite state and tags on the received share root - #4208

Merged
AlexAndBear merged 1 commit into
mainfrom
fix/share-root-favorite
Nov 4, 2026
Merged

AlexAndBear merged 1 commit into
mainfrom
fix/share-root-favorite

Conversation

@AlexAndBear

Copy link
Copy Markdown
Member

Description

An open received share now shows its real favorite state and tags in the folder actions, so a favorite share no longer offers "Add to favorites" and toggling it works as expected.

Related Issue

How Has This Been Tested?

  • test environment: unit tests (Vitest), browser tests (Playwright) against a local OpenCloud
  • test case 1: unit: the share root keeps the WebDAV favorite state and tags
  • test case 2: browser: favorited folder share with a tag (desktop and Pixel 7), toggling from the folder actions, non-favorite share, single-file share and personal folders

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
AlexAndBear merged commit 06ee2c0 into main Nov 4, 2026
29 checks passed
@AlexAndBear
AlexAndBear deleted the fix/share-root-favorite branch November 4, 2026 16:25
@openclouders openclouders mentioned this pull request Nov 4, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Favorite received share shows "Add to favorites" on its own root

2 participants