Skip to content

fix: update the sidebar preview when switching to a resource with the same mdate - #3615

Merged
dschmidt merged 4 commits into
mainfrom
fix/sidebar-preview-same-mdate
Oct 8, 2026
Merged

dschmidt merged 4 commits into
mainfrom
fix/sidebar-preview-same-mdate

Conversation

@dschmidt

@dschmidt dschmidt commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Description

The preview in the details panel of the right sidebar only reloaded when the mdate of the selected resource changed. When switching between two files with the same modification date, the preview of the previous file stayed.

The preview now reloads when the etag of the selected resource changes, which covers both another resource and new content of the same one.

Related Issue

  • None

How Has This Been Tested?

  • test environment: local dev setup
  • test case 1: unit test that changes the etag while the mdate stays the same
  • test case 2: selecting a pdf and then an mp3 with the same modification date with the sidebar open (manual)

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@dschmidt dschmidt self-assigned this Oct 8, 2026
@dschmidt
dschmidt marked this pull request as ready for review October 8, 2026 10:45

@kulmann kulmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice finding 😅 thanks for the fix!

@dschmidt
dschmidt enabled auto-merge October 8, 2026 11:09
@dschmidt
dschmidt merged commit 9242b58 into main Oct 8, 2026
31 checks passed
@dschmidt
dschmidt deleted the fix/sidebar-preview-same-mdate branch October 8, 2026 11:31
@openclouders openclouders mentioned this pull request Oct 8, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants