Skip to content

fix: update the sidebar preview when switching to a resource with the same mdate #3615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dschmidt merged 4 commits into from
Oct 8, 2026
Merged

fix: update the sidebar preview when switching to a resource with the same mdate #3615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
abcec01
fix: update the sidebar preview when switching to a resource with the…
dschmidt Oct 8, 2026
610c766
test: swap the resource in the sidebar preview test without changing …
dschmidt Oct 8, 2026
339748e
fix: watch the etag to reload the sidebar preview
dschmidt Oct 8, 2026
74d60b1
test: use descriptive etags in the sidebar preview test
dschmidt Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/web-app-files/src/components/SideBar/Details/FileDetails.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ const capitalizedTimestamp = computed(() => {
})

watch(
() => unref(resource)?.mdate,
() => unref(resource)?.etag,
async () => {
if (unref(resource)) {
preview.value = await loadPreview({
Expand Down
20 changes: 20 additions & 0 deletions packages/web-app-files/tests/unit/components/SideBar/Details/FileDetails.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
RouteLocation
} from '@opencloud-eu/web-test-helpers'
import { mock, mockDeep } from 'vitest-mock-extended'
import { reactive } from 'vue'
import { SpaceResource } from '@opencloud-eu/web-client'
import { AncestorMetaData, ImageDimension, ProcessorType } from '@opencloud-eu/web-pkg'
import { User } from '@opencloud-eu/web-client/graph/generated'
Expand Down Expand Up @@ -87,6 +88,25 @@ describe('Details SideBar Panel', () => {
expect.anything()
)
})
it('loads the preview again when the etag changes but the modification date stays the same', async () => {
const resource = reactive({ ...getResourceMock(), etag: 'initial-etag' }) as Resource
const { mocks, wrapper } = createWrapper({ resource })
await wrapper.vm.$nextTick()
await wrapper.vm.$nextTick()
expect(mocks.$previewService.loadPreview).toHaveBeenCalledTimes(1)

resource.etag = 'changed-etag'
await wrapper.vm.$nextTick()
await wrapper.vm.$nextTick()

expect(mocks.$previewService.loadPreview).toHaveBeenCalledTimes(2)
expect(mocks.$previewService.loadPreview).toHaveBeenLastCalledWith(
expect.objectContaining({ resource: expect.objectContaining({ etag: 'changed-etag' }) }),
expect.anything(),
expect.anything(),
expect.anything()
)
})
})
describe('status indicators', () => {
it('show if given on non-public page', () => {
Expand Down
Loading