Skip to content

fix: only renew the login when admins rename themselves - #3882

Merged
AlexAndBear merged 1 commit into
mainfrom
fix/admin-rename-relogin
Oct 19, 2026
Merged

AlexAndBear merged 1 commit into
mainfrom
fix/admin-rename-relogin

Conversation

@AlexAndBear

Copy link
Copy Markdown
Member

Description

  • Current-user check: the silent re-login after a user name change compared the edited user with its own copy (always true). It now compares with the logged-in user, so renaming other users no longer re-authenticates the admin.

Related Issue

How Has This Been Tested?

  • test environment: unit tests (Vitest), browser tests (Playwright) against a local OpenCloud
  • test case 1: unit: renaming another user doesn't call signinSilent
  • test case 2: browser: renaming another user sends no silent renew; renaming yourself still renews and the session keeps working; display name, role, quota and group edits still save

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
AlexAndBear merged commit cadd639 into main Oct 19, 2026
28 checks passed
@AlexAndBear
AlexAndBear deleted the fix/admin-rename-relogin branch October 19, 2026 10:01
@openclouders openclouders mentioned this pull request Oct 19, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Renaming any user in admin settings re-authenticates the admin

2 participants