Fix codejail proxy#151
Merged
Merged
Conversation
aht007
commented
Jan 30, 2023
Contributor
Author
|
@kdmccormick Can you please review this PR. |
kdmccormick
approved these changes
Jan 31, 2023
kdmccormick
left a comment
kdmccormick
left a comment
Member
There was a problem hiding this comment.
Looks good. Two pieces of feedback, up to you whether you use them.
aht007
force-pushed
the
aht007/fix-codejail-proxy
branch
2 times, most recently
from
e67249e to
4d14456
Compare
aht007
force-pushed
the
aht007/fix-codejail-proxy
branch
from
4d14456 to
9b41588
Compare
awais786
approved these changes
Feb 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the latest release of codejail on PyPI, the scripts fail to execute the jailed code because proxy_main isn't packaged correctly. In this PR we move
proxy_main.pyinside codejail package and fix the code which makes the call to this file. This PR should potentially fix the codejail release and we should be able to install codejail from PyPI in edx-platform