Skip to content

Install edx codejail from pypi - #31683

Merged
aht007 merged 3 commits into
masterfrom
aht007/install-edx-codejail-from-pypi
Feb 2, 2023
Merged

Install edx codejail from pypi#31683
aht007 merged 3 commits into
masterfrom
aht007/install-edx-codejail-from-pypi

Conversation

@aht007

@aht007 aht007 commented Feb 1, 2023

Copy link
Copy Markdown
Contributor

Description

This PR installs codejail package from PyPI instead of using github hash.
Previous attempts at installing codejail as PyPI package have failed multiple due to various reasons. We hope that openedx/codejail#151 was the last piece of puzzle and now it wouldn't cause trouble on production.

Disclaimer: Please don't merge this PR as we need to pause the production pipeline before merging and test the changes on staging server

@aht007 aht007 closed this Feb 1, 2023
@aht007 aht007 reopened this Feb 1, 2023
@aht007
aht007 force-pushed the aht007/install-edx-codejail-from-pypi branch from fe08638 to ff7189d Compare February 1, 2023 09:55
@aht007 aht007 changed the title Aht007/install edx codejail from pypi install edx codejail from pypi Feb 1, 2023
@aht007 aht007 changed the title install edx codejail from pypi Install edx codejail from pypi Feb 1, 2023
@aht007
aht007 merged commit 2741bed into master Feb 2, 2023
@aht007
aht007 deleted the aht007/install-edx-codejail-from-pypi branch February 2, 2023 07:26
aht007 added a commit that referenced this pull request Feb 2, 2023
@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@aht007

aht007 commented Feb 2, 2023

Copy link
Copy Markdown
Contributor Author

Tested the PR on staging server keeping in view the codejail testing and upgrade guide: Codejail-guide(2u-internal)
Tested some code problems on stage server on a previous course: stage-link
All the problems passed except the last one which was supposed to fail since it tried to access private system files.
@UsamaSadiq made a new course on staging server and tested some problems on his end too and everything worked as expected.

@aht007

aht007 commented Feb 2, 2023

Copy link
Copy Markdown
Contributor Author

Screenshot 2023-02-02 at 2 01 00 PM

Screenshot 2023-02-02 at 2 02 39 PM

@aht007

aht007 commented Feb 2, 2023

Copy link
Copy Markdown
Contributor Author

Going to unpause the pipeline now as things look good on staging server

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

1 similar comment
@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@kdmccormick

Copy link
Copy Markdown
Member

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

4 participants