Skip to content

Pin nova tempest-multinode nodeset on the job definition - #1233

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
amartyasinha:fix_nodeset
Oct 5, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
amartyasinha:fix_nodeset

Conversation

@amartyasinha

@amartyasinha amartyasinha commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Set the 3xl nodeset on nova-operator-tempest-multinode so all consumers
inherit it (cyborg via parent, the s2i-component-jobs template, and the
experimental pipeline). Drop the now-redundant per-pipeline overrides.

s2i template job was not having nodeset pin, thus CI on s2i repo for nova tempest was flaky.

Depends-On: #1232
Depends-On: openstack-k8s-operators/s2i-openstack-containers#239

  Set the 3xl nodeset on nova-operator-tempest-multinode so all consumers
  inherit it (cyborg via parent, the s2i-component-jobs template, and the
  experimental pipeline). Drop the now-redundant per-pipeline overrides.

Signed-off-by: Amartya Sinha <amsinha@redhat.com>
@openshift-ci
openshift-ci Bot requested review from amoralej and bogdando October 5, 2026 12:26
@openshift-ci openshift-ci Bot added the approved label Oct 5, 2026
@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Central YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 74f49dfc-075f-4dfb-96e2-0d74c45ac6f0
📥 Commits

Reviewing files that changed from the base of the PR and between 469b36e and e9203e9.

📒 Files selected for processing (1)
  • .zuul.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Chores
    • Nova and Cyborg multinode checks now run in a two-node CentOS 9/CRC environment inherited from their shared job configuration. Their GitHub check entries no longer specify separate node environments. The Ceph check retains its existing setup. These changes affect CI test environments; no end-user-facing application behavior changes.

Walkthrough

The Nova multinode job now defines the two-node CentOS 9/CRC nodeset. The Nova and Cyborg GitHub checks inherit that nodeset. The Ceph check retains its existing nodeset override.

Changes

Tempest Nodeset Configuration

Layer / File(s) Summary
Define and inherit the multinode nodeset
.zuul.yaml
The Nova multinode job declares the two-node CentOS 9/CRC nodeset. The Nova and Cyborg GitHub-check entries no longer set nodesets; the Ceph entry retains its override.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: ashu-011

Merge Risk: ⚪ Minimal · up to e9203

Nova and Cyborg checks use the shared two-node CentOS 9/CRC nodeset, while Ceph retains its override; no actionable merge risk is evident.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly states the main change: pinning the nodeset on the Nova tempest-multinode job definition.
Description check ✅ Passed The description explains the nodeset pin, its inheritance by consumers, and the removal of redundant overrides.
✨ Finishing Touches 💡 1
🧪 Generate unit tests (beta)
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@centosinfra-prod-github-app

Copy link
Copy Markdown

This change depends on a change that failed to merge.

Change #1232 is needed.

@amartyasinha

Copy link
Copy Markdown
Contributor Author

recheck

@openshift-ci

openshift-ci Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amartyasinha, gibizer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [amartyasinha,gibizer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build succeeded (check pipeline).
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/d111a5bdebe040e8a10adeed49dc68f8

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 00m 48s
✔️ workloads-s2i-content-provider SUCCESS in 8h 42m 02s
✔️ nova-operator-kuttl SUCCESS in 53m 08s
✔️ nova-operator-kuttl-placement SUCCESS in 38m 42s
✔️ nova-operator-tempest-multinode SUCCESS in 2h 12m 36s
✔️ nova-operator-tempest-multinode-ceph SUCCESS in 2h 21m 05s

@openshift-merge-bot
openshift-merge-bot Bot merged commit baa8fca into openstack-k8s-operators:main Oct 5, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants