Repository navigation
Set-up funnel rework - #3392
Set-up funnel rework#3392
Conversation
…p-attribution # Conflicts: # src/app/ClientProviders.tsx # src/components/Setup/Views/SignTestTransaction.tsx # src/context/authContext.tsx
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code-analysis diffPainscore total: 9216.83 → 9391.45 (+174.62) 🆕 New findings (437)
…and 417 more. ✅ Resolved (334)
…and 314 more. 📈 Painscore deltas (top movers)
|
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
The screen catalogue still prevents visual captures, and the QR copy still exceeds its CI baseline. The recovery-guide icon is fixed; none of the three earlier save-path findings survives.
Findings
-
MAJOR · src/dev/screens/catalogue.ts:126 · Keep setup screen orders valid for screenshot capture
These new fractional setup steps (43.5 here, and 43.2/43.6/43.7 below) become screenordervalues, butvalidateCapturerequiresNumber.isInteger(order). At the preceding head, all eight before/after capture jobs failed withInvalid screen order; this head changes only the email icon, leaving the failure path intact. Renumber the setup journey with distinct integer steps in the intended order. -
MINOR · src/features/payments/flows/qr-pay/views/QrPayFormView.tsx:220 · Reconcile the QR payment copy budget
The shared exchange-rate tooltip and revised comparison copy raise this screen to 214 words against its 200-word baseline. Thescreen-wordinesscheck failed at the preceding head, and this head only changes an email icon. Shorten the copy or update the baseline with the rationale for the approved longer wording.
Checked clean
- Prior P1 is fixed: explicit notification opt-outs require an acknowledged preferences write before advancing.
- Prior P2 is fixed: failed attribution attachment keeps a user-bound pending marker for retry.
- Prior P3 is fixed: failed email writes retain the draft and do not advance setup.
- The latest commit changes only the recovery-guide icon from 14px to the design-system 16px size, resolving the preceding off-scale finding.
- Current-head capture and wordiness CI jobs were still in progress at review time; their affected code is unchanged from the preceding head whose failure logs were inspected.
- Local reruns were unavailable because the supplied detached worktree has no installed dependencies.
Security review by moonshotai/kimi-k3: 0 finding(s), marked with the model name. It reads the diff only and answers only security, privacy and money, so treat its findings as advice.
Third opinion: did not run — it reads only the first review of a pull request; the first reviewer checks later rounds. This review is one reviewer short.
Exact head: 432eca63e464 · Context: repo, sibling, ci · Took 7m
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
The screenshot-catalogue order is fixed. The QR payment screen still exceeds the advisory wordiness baseline; the other five listed findings are fixed at this head.
Answered by a human, not raised again
These are still present as far as this review can tell. You resolved the thread or deferred the fix, so Chip files them instead of repeating them.
- MINOR · src/features/payments/flows/qr-pay/views/QrPayFormView.tsx:220 · Reconcile the QR payment copy budget — no task filed, please file one
Checked clean
- P1 fixed: explicit notification opt-outs require acknowledged preference writes before setup advances.
- P2 fixed: unacknowledged signup-attribution attachment keeps its user-bound retry marker.
- P3 fixed: failed email writes retain the draft and prevent setup advancement.
- P4 fixed: all 21 account-setup catalogue steps are distinct integers; the added test validates manifests in all four locales using the capture validator.
- P6 fixed: the recovery-guide icon now uses the design-system 16px size; design-system lint succeeded at the preceding head.
- Current-head screenshot and wordiness CI jobs were in progress at review time; the QR copy and baseline are unchanged from the preceding failed wordiness check.
Security review by moonshotai/kimi-k3: 0 finding(s), marked with the model name. It reads the diff only and answers only security, privacy and money, so treat its findings as advice.
Third opinion: did not run — it reads only the first review of a pull request; the first reviewer checks later rounds. This review is one reviewer short.
Exact head: 205b0933b1d2 · Context: repo, sibling, ci · Took 6m
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
The new shared residence checklist promises account and payment access to sanctioned residents. The changed common translations leave the marketing catalogs out of sync and the unit check failing. The QR copy budget finding remains; P1–P4 are fixed.
Findings
-
MAJOR · src/components/Setup/Views/Residence.tsx:199 · Do not promise Peanut access to sanctioned residents
Selecting a fully restricted sanctioned residence such as Iran or Russia now enters this shared checklist and displays checked “Digital dollars account” and “Peanut-to-Peanut payments” under “Here’s what you get with Peanut.” Peanut’s country policy excludes the sanctioned countries from the product; open registration does not make these benefits available. Keep the checklist for eligible restriction tiers, but show an honest unavailable state for sanctioned residences instead of these checked promises. -
MAJOR · src/i18n/app/messages/en.json:3 · Regenerate marketing catalogs after adding common copy
Adding thesecommonkeys in all four app catalogs without regenerating their.marketing.jsonsubsets makesmarketing-messages.test.tsfail for every locale in the preceding head’sunitcheck; this head does not change either catalog set.commonis a required marketing namespace, so run the marketing-message generator and commit the updated subsets.
Answered by a human, not raised again
These are still present as far as this review can tell. You resolved the thread or deferred the fix, so Chip files them instead of repeating them.
- MINOR · src/features/payments/flows/qr-pay/views/QrPayFormView.tsx:220 · Reconcile the QR payment copy budget — no task filed, please file one
Checked clean
- P1 fixed: explicit notification opt-outs still require acknowledged preference writes before advancing.
- P2 fixed: failed signup-attribution attachment still retains its user-bound retry marker.
- P3 fixed: a failed email write retains the draft and does not advance; the moved recovery link remains conditional on duplicate email.
- P4 fixed: setup catalogue order values remain distinct integers; all eight capture jobs succeeded at the preceding head.
- The new feature-step sequence places funding between the two selected introductions and has focused forward/back tests.
- The Lexicon establishes open registration, while the current country policy excludes sanctioned residences from Peanut availability.
- Current-head unit and wordiness CI jobs were still pending at review time; their affected catalog and QR-copy files are unchanged from the preceding failing head.
Security review by moonshotai/kimi-k3: 0 finding(s), marked with the model name. It reads the diff only and answers only security, privacy and money, so treat its findings as advice.
Third opinion: did not run — it reads only the first review of a pull request; the first reviewer checks later rounds. This review is one reviewer short.
Exact head: 074819998495 · Context: repo, product, lexicon, ci · Took 9m
Make signup open and guided, with residence-based feature introductions, email and notification choices, passkey confirmation, and a completion celebration. Preserve referral and marketing attribution without requiring an invite.
Backend dependencies: API #1789 for notification preferences and API #1579 for open signup and durable attribution. #1579 requires four database migrations: Render applies them automatically during staging builds on
dev; production must apply them before API rollout. Detailed instructions remain in that PR.Validation: 145 focused setup, DataRow and locale tests passed for the layout changes, followed by 45 locale/Manteca claim tests for shared copy and 61 focused player, email/notification, setup-document, transition and locale tests for the latest update. The 17 email/notification tests passed again after adjusting the recovery icon to the design-system 16px size. Full TypeScript, changed-file ESLint, Prettier and the complete design-system lint ratchet passed. Browser checks covered translated layouts at 320px and 390px, equal checklist rows, consistent button labels, localized recovery links and reachable actions without horizontal overflow. These component previews use mocked network/state; native-device behavior is not established by these checks.
The advisory
screen-wordinesscheck measures Manteca withdrawal at 347/347, down from 353 after sharing the duplicate notice. After the provider-disclosure merge and readable Pix comparison copy, QR payment scores 225 against the current dev baseline of 203; this remains the only wordiness failure. The baseline is unchanged.The screenshot-capture
Invalid screen orderfailure is fixed by integer setup steps. The new regression test reproduced the failure before the change and now passes for all four locale manifests; all 23 catalogue, capture-core and route-inventory tests pass, with changed-file ESLint and Prettier also passing. The dev merge includes #3580’s fix for version-control files in prebuilt preview functions. Full before/after capture and deployment behavior still require current-head CI verification.Public onboarding gallery
Latest motion/footer validation: 23 focused animation-player, email/notification and celebration tests passed. Browser checks measured the one-second card pause and verified the recovery link below Continue at 320px and 390px in all four locales. The original globe/route layers remain unchanged; the new glow layers have matching loop endpoints, and @ outlines have equal stroke widths with the fill painted behind the inner stroke. Full TypeScript, changed-file ESLint, Prettier and the design-system lint ratchet passed.
Latest checklist/order validation: 98 residence and setup-flow tests passed, including forward/back navigation for all five feature combinations and exactly two interactive options for Ukraine. All 23 capture/catalogue/inventory tests passed with distinct integer orders. Browser checks covered 24 conditional-checklist layouts across four locales at 320px and 390px. Full TypeScript, changed-file ESLint, Prettier and the design-system lint ratchet passed. Current-head CI remains separate from this local validation.
Latest funding validation: all 91 funding, residence and residence-availability tests passed, covering two-option countries, three/four-feature countries, residence changes and pending eligibility. Browser checks covered the two-row funding layout in all four locales at 320px and 390px, with 48px rows and reachable actions. Full TypeScript, changed-file ESLint, Prettier and the design-system lint ratchet passed.
Latest celebration validation: all 30 success, final-confirmation, shared-confetti, coordinated-curtain and lifecycle tests passed. Browser checks covered eight translated layouts, particle coverage on both sides from top to bottom, and a completely clear canvas before redirect. Full TypeScript, changed-file ESLint, Prettier and the design-system lint ratchet passed.
Unify setup typography and field sizing: use 16px Body/M descriptions with 26px line height and the approved #5F646D colour throughout setup, including residence and celebration. Keep notes and legal text at their secondary sizes; use the DS 48px email input to match username.
Typography/input verification: 33 focused setup tests, TypeScript, changed-file ESLint, Prettier and DS ratchet passed; rendered component previews checked across all four supported locales at 320px and 390px widths. Full Next.js preview verification was unavailable because the existing development server timed out while compiling.
Latest dev conflict resolution: preserve the approved Mercado Pago savings explanation from commit
2bbf8f46cand the shared exchange-rate/own-account notices while importing dev’s Manteca provider row, disclosure sheet, and other upstream updates. Apply the same readable style to the Pix savings tooltip in all four locales: lead with how the payment works, explain IOF as Brazilian tax, and replace issuer FX jargon with currency conversion fees. Keep the catalogue membership test independent of journey order, and regenerate the marketing catalogs.Conflict-resolution validation: all 523 tests across the 32 upstream-changed suites, all 149 focused locale/provider/catalogue tests, and all 166 screen-library script tests passed. Full TypeScript passed after generating Next types; translation formatting and the Git whitespace/conflict-marker checks passed. The full local Jest run stalled and was stopped, so full-suite validation remains with current-head CI. The deliberate readable-copy growth leaves the advisory QR wordiness score at 225/203; the baseline is unchanged by this resolution.