Repository navigation
Conversation
… (hotfix to main) Cherry-pick of #3878 (merged to dev 28 Oct, otherwise on main only with Release 167 on 9 Nov). peanut.me/peanut-card tells prod users they can apply before adding money, which contradicts the $10 first-application rule (mono product truth, confirmed by Konrad 6 Nov). Two launch films wait on it. i18n JSON only: no native surface change, OTA-safe.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Code-analysis diffPainscore total: 10624.51 → 10624.51 (0) |
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
No findings in the card application copy update.
Findings
- MAJOR · src/i18n/app/messages/en.json:4040 · Copy now wrong: product/card.md says access has one gate and omits the $10 first-application balance step
After this change: A first card application needs at least $10 in the Peanut balance, and the FAQ now says so; before this PR the FAQ said no deposit was needed before applying.
These places still say otherwise:
mono:product/card.md:96— "# Access has one gate: verification plus an eligible residence country (api#1586 retired the queue layers)." → # Access has two gates: verification plus an eligible residence country, and for a first application at least $10 spendable balance (api#1586 retired the queue layers).mono:product/card.md:98— "gate: "KYC approved (Sumsub, 18+) AND residence country not on the denylist above; the application is then subject to Rain's approval"" → gate: "KYC approved (Sumsub, 18+) AND residence country not on the denylist above; for a first application, at least $10 spendable balance; the application is then subject to Rain's approval"
Fix them in this pull request, or say where the fix goes. mono: copy ships to mono main as its own content change, never inside a code PR.
Checked clean
- Exact head and merge base verified; eight i18n JSON files changed.
- Card first-application $10 spendable-balance rule checked against the live Lexicon, product/card.md, and useCardFlow.
- App and marketing card copy match in en, es-419, es-AR, and pt-BR; es-AR inherits the updated question.
- Deploy-Preview failed on an invalid passkeys rewrite destination; the PR changes only i18n JSON, not rewrite configuration. Other CI checks were still in progress when reviewed.
Security review: did not run — this change has no security, privacy or money surface, so it was not asked. This review is one reviewer short.
Third opinion by claude-opus: 0 finding(s), marked with the model name. It answers only product truth, missing tests and the cross-repo contract, so treat its findings as advice.
Copy check by claude-haiku-5-5: 1 finding(s), titled "Copy now wrong". Every quoted passage was checked against the file.
Exact head: 9481f3a0467e · Context: repo, product · Took 2m
| "question": "Do I need to deposit before applying?", | ||
| "answer": "No. You can apply before adding money. Add funds once your card is ready to make payments." | ||
| "question": "Do I need money in my balance to apply?", | ||
| "answer": "Yes. To apply for your first card, you need at least $10 in your Peanut balance. It is not a fee: the money stays yours to spend with the card." |
There was a problem hiding this comment.
MAJOR: Copy now wrong: product/card.md says access has one gate and omits the $10 first-application balance step
After this change: A first card application needs at least $10 in the Peanut balance, and the FAQ now says so; before this PR the FAQ said no deposit was needed before applying.
These places still say otherwise:
mono:product/card.md:96— "# Access has one gate: verification plus an eligible residence country (api#1586 retired the queue layers)." → # Access has two gates: verification plus an eligible residence country, and for a first application at least $10 spendable balance (api#1586 retired the queue layers).mono:product/card.md:98— "gate: "KYC approved (Sumsub, 18+) AND residence country not on the denylist above; the application is then subject to Rain's approval"" → gate: "KYC approved (Sumsub, 18+) AND residence country not on the denylist above; for a first application, at least $10 spendable balance; the application is then subject to Rain's approval"
Fix them in this pull request, or say where the fix goes. mono: copy ships to mono main as its own content change, never inside a code PR.
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
🖼 Visual diff — 10 screens moved12 of 326 shots changed · 314 identical · baseline
job summary · before/after/diff images — artifact Fixture screenshots, no backend. Advisory — this check never blocks a merge. Posted from the default branch by ds-shots-comment.yml; the report it renders is untrusted data. |
What
Cherry-pick of #3878 (Hugo, merged to
dev28 Oct) ontomain. Eight i18n JSON files (en, es-419, es-AR, pt-BR, app + marketing): the card FAQ and the card spend line now say a first application needs at least $10 in the balance, instead of "You can apply before adding money".Why now
product/activation-funnel.md, gateuseCardFlow.needsFundingBeforeApplyfrom Set-up funnel rework #3392). Konrad confirmed on 6 Nov that mono is right.ops/releases.md(Konrad's call, 6 Nov). Needs one approval from a dev who is not the author. Release 167 captain: please note a hotfix onmainbefore Monday's freeze.Risk
i18n strings only. No native surface change, so the OTA that a
mainmerge starts is safe. Back-mergemain→devafter merge is a no-op (same change already ondev). Replaces #3993 (closed by mistake).Task
Notion: Follow up the launch films: weekly reads, $650 reserve, card films (TASK-24202) https://app.notion.com/p/4088381175798143a435d4e0544294f1
🤖 Generated with Claude Code