Skip to content

hotfix(card): FAQ says a first card application needs $10 in the balance (#3878 to main) - #3995

Open
0xkkonrad wants to merge 1 commit into
mainfrom
hotfix/card-faq-deposit-copy
Open

0xkkonrad wants to merge 1 commit into
mainfrom
hotfix/card-faq-deposit-copy

Conversation

@0xkkonrad

Copy link
Copy Markdown
Contributor

What

Cherry-pick of #3878 (Hugo, merged to dev 28 Oct) onto main. Eight i18n JSON files (en, es-419, es-AR, pt-BR, app + marketing): the card FAQ and the card spend line now say a first application needs at least $10 in the balance, instead of "You can apply before adding money".

Why now

  • Production peanut.me/peanut-card still shows the old answer, which contradicts the $10 rule (mono product/activation-funnel.md, gate useCardFlow.needsFundingBeforeApply from Set-up funnel rework #3392). Konrad confirmed on 6 Nov that mono is right.
  • Two launch films (PC1, PC2) post automatically the day the old answer is gone; they have waited since 4 Nov. Release 167 (Prod Release Sprint 167 — KYC rework, privacy follow-ups (2026-11-09) #3987) would carry it on 9 Nov; Konrad asked for the faster path.
  • Not a P0/P1 by the lexicon: this is the explicit-exception path in ops/releases.md (Konrad's call, 6 Nov). Needs one approval from a dev who is not the author. Release 167 captain: please note a hotfix on main before Monday's freeze.

Risk

i18n strings only. No native surface change, so the OTA that a main merge starts is safe. Back-merge main → dev after merge is a no-op (same change already on dev). Replaces #3993 (closed by mistake).

Task

Notion: Follow up the launch films: weekly reads, $650 reserve, card films (TASK-24202) https://app.notion.com/p/4088381175798143a435d4e0544294f1

🤖 Generated with Claude Code

… (hotfix to main)

Cherry-pick of #3878 (merged to dev 28 Oct, otherwise on main only with Release 167 on 9 Nov).
peanut.me/peanut-card tells prod users they can apply before adding money, which contradicts
the $10 first-application rule (mono product truth, confirmed by Konrad 6 Nov). Two launch
films wait on it. i18n JSON only: no native surface change, OTA-safe.
@vercel

vercel Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
peanut-wallet Ready Ready Preview Nov 6, 2026 12:34pm UTC

Request Review

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Code-analysis diff

Painscore total: 10624.51 → 10624.51 (0)
Findings: 0 net (+0 new, -0 resolved)

@chip-peanut-bot chip-peanut-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chip review — no blocking findings — this is not an approval

No findings in the card application copy update.

Findings

  • MAJOR · src/i18n/app/messages/en.json:4040 · Copy now wrong: product/card.md says access has one gate and omits the $10 first-application balance step
    After this change: A first card application needs at least $10 in the Peanut balance, and the FAQ now says so; before this PR the FAQ said no deposit was needed before applying.

These places still say otherwise:

  • mono:product/card.md:96 — "# Access has one gate: verification plus an eligible residence country (api#1586 retired the queue layers)." → # Access has two gates: verification plus an eligible residence country, and for a first application at least $10 spendable balance (api#1586 retired the queue layers).
  • mono:product/card.md:98 — "gate: "KYC approved (Sumsub, 18+) AND residence country not on the denylist above; the application is then subject to Rain's approval"" → gate: "KYC approved (Sumsub, 18+) AND residence country not on the denylist above; for a first application, at least $10 spendable balance; the application is then subject to Rain's approval"

Fix them in this pull request, or say where the fix goes. mono: copy ships to mono main as its own content change, never inside a code PR.

Checked clean

  • Exact head and merge base verified; eight i18n JSON files changed.
  • Card first-application $10 spendable-balance rule checked against the live Lexicon, product/card.md, and useCardFlow.
  • App and marketing card copy match in en, es-419, es-AR, and pt-BR; es-AR inherits the updated question.
  • Deploy-Preview failed on an invalid passkeys rewrite destination; the PR changes only i18n JSON, not rewrite configuration. Other CI checks were still in progress when reviewed.

Security review: did not run — this change has no security, privacy or money surface, so it was not asked. This review is one reviewer short.

Third opinion by claude-opus: 0 finding(s), marked with the model name. It answers only product truth, missing tests and the cross-repo contract, so treat its findings as advice.

Copy check by claude-haiku-5-5: 1 finding(s), titled "Copy now wrong". Every quoted passage was checked against the file.

Exact head: 9481f3a0467e · Context: repo, product · Took 2m

"question": "Do I need to deposit before applying?",
"answer": "No. You can apply before adding money. Add funds once your card is ready to make payments."
"question": "Do I need money in my balance to apply?",
"answer": "Yes. To apply for your first card, you need at least $10 in your Peanut balance. It is not a fee: the money stays yours to spend with the card."

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR: Copy now wrong: product/card.md says access has one gate and omits the $10 first-application balance step

After this change: A first card application needs at least $10 in the Peanut balance, and the FAQ now says so; before this PR the FAQ said no deposit was needed before applying.

These places still say otherwise:

  • mono:product/card.md:96 — "# Access has one gate: verification plus an eligible residence country (api#1586 retired the queue layers)." → # Access has two gates: verification plus an eligible residence country, and for a first application at least $10 spendable balance (api#1586 retired the queue layers).
  • mono:product/card.md:98 — "gate: "KYC approved (Sumsub, 18+) AND residence country not on the denylist above; the application is then subject to Rain's approval"" → gate: "KYC approved (Sumsub, 18+) AND residence country not on the denylist above; for a first application, at least $10 spendable balance; the application is then subject to Rain's approval"

Fix them in this pull request, or say where the fix goes. mono: copy ships to mono main as its own content change, never inside a code PR.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

🧪 UI test report — ✅ all green

Suites

  • ✅ unit: 14044 ran, 0 failed, 0 skipped, 5.4m

📊 Coverage (unit)

metric %
statements 85.8%
branches 77.4%
functions 80.8%
lines 87.1%
⏱ 10 slowest test cases
time test
🐢 9.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › Network failure keeps loading while retries remain, then shows the generic error
🐢 7.7s scripts/__tests__/indexable-urls.test.ts › excludes missing locale files, drafts, redirects, and retired pages from crawl and submission lists
🐢 7.0s scripts/__tests__/signup-attribution-paths.test.ts › includes newly published articles and locale fallbacks without editing the manifest
4.5s scripts/__tests__/indexable-urls.test.ts › gives crawls and IndexNow exactly the canonical inventory
4.1s src/components/Card/share-asset/__tests__/shareAssetLayout.test.ts › never places two stickers in heavy overlap (broad seed sweep)
4.1s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › MANTECA_USER_NOT_PROVISIONED fails fast with copy that names the real cause
4.0s src/features/setup/__tests__/useSignupPasskey.test.tsx › opens the help drawer for NotReadableError and retries from it with one more ceremony
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › User KYC not approved fails fast with copy that names the real cause
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › MANTECA_MERCHANT_RECENT_REFUND fails fast with copy that names the real cause
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › MANTECA_SOURCE_OVER_MONTHLY_CAP fails fast with copy that names the real cause
📍 Inline annotations are in the **Unit test report** check above. Coverage artifact: `coverage-unit`. Generated by `.github/workflows/tests.yml`.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

🖼 Visual diff — 10 screens moved

12 of 326 shots changed · 314 identical · baseline 6b37e0d → head 9481f3a

worst % screen widths
55.87% avatar-picker 320, 430
19.37% card-available 320, 430
4.51% history-request-pot-closed-short 430
2.09% guest-invite 430
0.28% withdraw-bank-form-us-resident 430
0.27% withdraw-bank-form-us-abroad 430
0.13% empty-history 430
0.09% card-prohibited 320
0.04% card-holder 430
0.00% card-onboarding 320

job summary · before/after/diff images — artifact

Fixture screenshots, no backend. Advisory — this check never blocks a merge. Posted from the default branch by ds-shots-comment.yml; the report it renders is untrusted data.

This branch was successfully deployed

1 active and 1 inactive deployments
Preview — 9481f3a0 Deployed Nov 6, 2026 by vercel[bot]
content-publish — 9481f3a0 Deployed Nov 6, 2026 by 0xkkonrad via approve-and-merge #7602
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant