Repository navigation
fix: Add Money picker and analytics, bank setup, residence review, card issuance, and signup layout - #4065
fix: Add Money picker and analytics, bank setup, residence review, card issuance, and signup layout#4065innolope-dev wants to merge 18 commits into
Conversation
…-errors-main fix(TASK-24702): recover paperwork questions and blocked setup
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Code-analysis diffPainscore total: 11191.26 → 11241.56 (+50.3) 🆕 New findings (261)
…and 241 more. ✅ Resolved (219)
…and 199 more. 📈 Painscore deltas (top movers)
|
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
Preserve the bank claim identity restart and bind its verification requests to the initiating account.
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
No confirmed defects at the pinned head. Four CI checks were still running at review time.
Checked clean
- Bridge setup preview and exact-currency gate against the paired API contract; no conflicting behavior found.
- Explicit restart dispatch, terminal hold, and signed-in account switch guards; no reachable regression found.
- Add Money analytics event scope, country-list navigation, and capture failure behavior; no defect found.
- Design-system rules for the changed UI; no deviation found.
- CI at this head: completed checks had no failures; unit, ds-shots, i18n-overflow, and press-contract were still running.
Security review by moonshotai/kimi-k3: 0 finding(s), marked with the model name. It reads the diff only and answers only security, privacy and money, so treat its findings as advice.
Third opinion by claude-opus: 0 finding(s), marked with the model name. It answers only product truth, missing tests and the cross-repo contract, so treat its findings as advice.
Copy check by claude-haiku-5-5: 0 finding(s), titled "Copy now wrong". Every quoted passage was checked against the file.
Exact head: 6c71651046e1 · Context: repo, product, design, sibling-api, ci · Took 8m
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
Two findings on the new head: one failing copy gate and one unavailable-country navigation regression.
Findings
-
MAJOR · src/features/paperwork-verification/KycFeatureActivationStatus.tsx:58 · Account-status copy fails the screen-wordiness check
At this head, the screen-wordiness check fails five over-baseline screens: ClaimAccountScreen (+20 words), Card (+42), Add Money bank and Withdraw bank (+20 each), and DepositAccountsListScreen (+4). The new shared refusal-copy branches are counted by KYC-gate consumers; the new Argentina note grows the list. This check passed on the previous head. Shorten or scope the added copy, or update the baseline with a documented reason for intentional growth. -
MINOR · src/components/Common/CountryList.tsx:291 · Unavailable Argentina row loses its residence action
With a known non-Argentine residence, the Add Money Argentina row gets an unavailable reason and is disabled, so pointer and keyboard selection do nothing. That removes access to the existing ResidenceRequiredScreen, which explains the restriction and offers Update residence and QR pay. design.md → rows the user cannot act on requires unavailable rows to remain tappable and reserves disabled styling for in-flight reads. Keep the row selectable and lead to that explanation instead of disabling it.
Checked clean
- Exact head, trusted PR metadata, and merge base matched the supplied identifiers.
- Selected-currency waiting/refusal handling, Manteca country scoping, and Pix verification routing were compared with their focused acceptance tests; no additional confirmed regression.
- Earlier Bridge claim/restart and Add Money analytics paths were unchanged from the prior clean review.
- CI at this head: screen-wordiness failed; unit, i18n-overflow, ds-shots, Deploy-Preview, press-contract, and seo-contract remained in progress at review time.
Security review by moonshotai/kimi-k3: 0 finding(s), marked with the model name. It reads the diff only and answers only security, privacy and money, so treat its findings as advice.
Third opinion: did not run — it reads only the first review of a pull request; the first reviewer checks later rounds. This review is one reviewer short.
Copy check by claude-haiku-5-5: 0 finding(s), titled "Copy now wrong". Every quoted passage was checked against the file.
Exact head: ad8cab5a4236 · Context: repo, product, design, ci · Took 6m
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
The checklist Add money route still disagrees with the canonical activation funnel, and this head introduces failing screen-wordiness and format checks. No separate card-issuance or residence-review state defect was confirmed.
Findings
-
MAJOR · src/components/Home/GettingStartedChecklist.tsx:185 · Checklist Add money entry disagrees with activation funnel
Tapping the Home checklist Add money row now opens /add-money, while product/activation-funnel.md explicitly specifies the Home Add drawer with bank first and crypto second as this row’s destination. This remains unchanged at this head. Restore the documented entry point, or update the canonical funnel decision and its intended ordering alongside this change. -
MAJOR · src/components/Profile/views/ResidenceChangeDrawer.tsx:203 · Residence-review copy exceeds the screen word budget
The new review callout adds the full reviewBody to the residence drawer, and the shared copy also reaches other screens. The screen-wordiness check fails on this head; design.md’s word-budget rule limits existing screens to their baseline and counts callout text twice. Shorten or collapse the added explanation, then regenerate only any intentionally changed baseline. -
MINOR · src/components/Profile/components/tests/ResidenceMenuItem.test.tsx:128 · New residence-review test fails formatting check
The format check fails on src/components/Profile/components/tests/ResidenceMenuItem.test.tsx after this new test was added. Format this test with the repository Prettier configuration so the required check passes. -
MAJOR · src/components/Profile/views/ResidenceChangeDrawer.tsx:98 · Copy now wrong: A residence change under review can no longer be completed from the app; the support docs still tell users to finish the verification
After this change: While a residence change is REVIEW_PENDING for the requested country, the app hides the submit action, disables Save, shows an 'Under review' callout and offers only Contact support, so the user cannot complete or resubmit the verification for that country.
These places still say otherwise:
mono:product/support-answers/card-country-restrictions.md:65— "to re-select the approved country (cancel) or complete the new-residence verification." → to re-select the approved country (cancel). If the new residence is already submitted and shows 'Under review', there is nothing to complete in the app; wait for the review or contact support.mono:product/support-answers/card-country-restrictions.md:34— "residence verification if the move is real." → residence verification if the move is real and not yet submitted. If it is already submitted and shows 'Under review', wait for the review or contact support.mono:product/support-answers/card-not-showing-after-kyc.md:45— "Payment Channels → Residence**, or finish verification if the move is real." → Payment Channels → Residence**, or, if the move is real and already submitted, wait for the 'Under review' result or contact support.
Fix them in this pull request, or say where the fix goes. mono: copy ships to mono main as its own content change, never inside a code PR.
Answered by a human, not raised again
These are still present as far as this review can tell. You resolved the thread or deferred the fix, so Chip does not repeat them. If one needs a follow-up, file the task yourself.
- MAJOR · src/components/Home/GettingStartedChecklist.tsx:185 · Copy now wrong: Checklist Add money row opens /add-money, but activation-funnel still says Home Add drawer
Checked clean
- Verified trusted PR metadata, exact head and base, clean detached worktree, and current-head CI.
- Rechecked P1–P6 against this head: the earlier account-status copy, Argentina action, capture ordering/checkpoint, and duplicate checklist reports do not warrant separate findings; P7 remains.
- Reviewed card issuance polling, retry, owner fencing, pending-application tests, and residence-review action, drawer, modal, and tests; no additional confirmed defect.
Security review by moonshotai/kimi-k3: 0 finding(s), marked with the model name. It reads the diff only and answers only security, privacy and money, so treat its findings as advice.
Third opinion: did not run — it reads only the first review of a pull request; the first reviewer checks later rounds. This review is one reviewer short.
Copy check by claude-haiku-5-5: 2 finding(s), titled "Copy now wrong". Every quoted passage was checked against the file.
Exact head: b0c263fbdda1 · Context: repo, product, design, CI · Took 7m
kushagrasarathe
left a comment
There was a problem hiding this comment.
From Kush's agent (pr-review):
Requesting changes for one design-rule break and the release path. The code itself looks sound and CI is green. Smaller nits are inline.
To fix before merge:
- Icon colours (inline on
conceptIcons.tsx): get a ruling from Hugo or Konrad and updatedesign/design.mdin mono, or revert the two lines. - Release path: this goes to
mainas a hotfix but carries new features too (Add Money picker,/add-money/options, 5 analytics events, the Home Add drawer, icon colours).ops/releases.mdkeeps the hotfix path to P0/P1, everymainmerge also ships an OTA, and release ui#4059 is still open. Either split the Bridge setup fix into a small hotfix and send the rest throughdev, or get Hugo and the release captain to sign off on shipping it whole. - Open a
devtwin or plan a same-daymain→devback-merge. None of the new files exist ondev, so the next release would conflict with or revert this. - Merge after api#2110 is deployed. Without it, the residence-review and
restart-identitybranches never fire. - Reply to Chip's open threads on
GettingStartedChecklist.tsx:185. mono 52adf78bc probably answers them.
| */ | ||
| export const CONCEPT_ICONS = { | ||
| bank: { icon: 'bank', color: 'blue' }, | ||
| bankAccount: { icon: 'bank', color: 'green' }, |
There was a problem hiding this comment.
Blocking: design/design.md (icon bubble colour table) says green means "done" and is never for a concept, and IconBubble.tsx:13 in this PR still says "green: done". A green bank icon on Home and Add money reads as "already done".
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
No confirmed findings at this head. Earlier review issues are fixed or no longer apply after the dev integration.
Checked clean
- Verified trusted author, open PR, exact dev base and head, clean detached worktree, and the 104-file base-to-head diff.
- Rechecked P1–P11: activation-funnel.md now specifies the checklist picker; support guidance distinguishes submission from review; Argentina action and capture checkpoints remain; residence copy, baseline, and test formatting are updated.
- Reviewed Add Money picker and returning-user drawer, account readiness and selected-currency gates, Pix route integration, residence review, card issuance wait/retry, KYC identity fencing, and corresponding focused tests.
- Current-head screen-wordiness, screen-tests, typecheck, format, and other completed focused checks succeeded; unit, i18n-overflow, capture_after, press-contract, seo-contract, and preview were still running when checked.
Security review by moonshotai/kimi-k3: 0 finding(s), marked with the model name. It reads the diff only and answers only security, privacy and money, so treat its findings as advice.
Third opinion: did not run — it reads only the first review of a pull request; the first reviewer checks later rounds. This review is one reviewer short.
Copy check by claude-haiku-5-5: 0 finding(s), titled "Copy now wrong". Every quoted passage was checked against the file.
Exact head: 4277e985fbb9 · Context: repo, product, design, CI · Took 6m
|
Review preview: dcbfe47 → 4277e98. Incomplete capture; unavailable states are listed in the report. Other locales were not captured; add the Before was captured with the base branch's own synthetic API because this PR changes it; differences can include synthetic-data changes. Screen Library coverage: fail — UI review needs a complete, unique comparison for every required locale. Screen Library copy: fail — 4 changed copy key(s) appear in no captured state: card.status.creatingCardBody, card.status.creatingCardTitle, card.status.stillCreatingTitle, depositAccounts.list.notOfferedHereBody. 7 baseline entries are now shown or deleted; remove from scripts/screens/copy-coverage-baseline.json: identity.reasons.identity_document_insufficient, profile.unlockPayments.changeModal.lost.local, profile.unlockPayments.changeModal.lostBody, profile.unlockPayments.changeModal.lostTitle, profile.unlockPayments.changeModal.saveAnyway, profile.unlockPayments.changeModal.verifiedMismatchNote, setup.notifications.notNow. Add a capture state that shows the copy, or add the keys to the baseline with “Screen Library copy exception: ” on its own line in the PR description. Copy coverage: 1257/4002 keys shown. |
|
Replaced by #4083. |
Bank accounts
Add money
Analytics
add_money_viewed,add_money_country_list_opened,add_money_country_list_closed,add_money_country_selected, andadd_money_back_tappedon Add Money.Signup, notification setup, and card issuance
Residence change review
TASK-24823 and TASK-24822.
Review follow-ups
Release order
The narrow Bridge account setup hotfix is in UI #4069. This PR targets dev. The API changes landed on main in API #2110 and are ported to dev in API #2115. Confirm the API revision is live before releasing the dependent UI.
Verification