Skip to content

fix: Add Money picker and analytics, bank setup, residence review, card issuance, and signup layout - #4065

Closed
innolope-dev wants to merge 18 commits into
devfrom
innolope/bridge-deposit-claim-main
Closed

innolope-dev wants to merge 18 commits into
devfrom
innolope/bridge-deposit-claim-main

Conversation

@innolope-dev

@innolope-dev innolope-dev commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Bank accounts

  • Refresh the requested currency during Bridge setup. Show the existing terms, pending setup, or rejection for that currency, and allow opening once its rail is enabled.
  • Honor the requested rail’s explicit identity restart action. Preserve terminal holds and fence the restart request and response to the signed-in account that started it.
  • Give unverified Pix users the same Verify badge and identity drawer as the other bank-account rows. Companion API PR #2110

Add money

  • Open a full-screen picker for first-time users and when no method is ready. The picker offers Open a bank account, One-time bank transfer, Pay with Pix, and Crypto, with a currency or country chooser where applicable.
  • Returning users with a usable method get a drawer with ready methods and More ways to add money. The Home to-do entry opens the full picker directly. Crypto remains available without identity verification.
  • Show the actual setup, review, or rejection for the selected currency. Mark Argentina unavailable in All countries for users without eligible Argentine residence.
  • Use the app’s shared color icons, including a green bank-account icon and a blue crypto icon across the affected screens. Preserve Back behavior through the picker, drawer, and account routes.

Analytics

  • Capture add_money_viewed, add_money_country_list_opened, add_money_country_list_closed, add_money_country_selected, and add_money_back_tapped on Add Money.
  • Country selection captures the catalogue slug, accordion or search source, and route or waitlist outcome. Back captures the country-list context. Events omit search text and bank details. The existing ledger supplies settled deposits.

Signup, notification setup, and card issuance

  • Update the residence and signup browser tests to exercise the fullscreen residence comparison and the actual signup footer.
  • Keep Continue and Not now visible on the notification screen. On short screens, the choices scroll inside the panel. Both notification variants have deterministic capture fixtures.
  • After a pending card application, show Creating your card while the approved rail has no card yet. Poll the read-only overview every two seconds for up to twelve seconds. Show the card as soon as it appears and offer the existing retry after a fresh empty result. Unavailable reads use the load-retry path.
  • Update the screenshot catalogue and browser coverage for Add Money, the current EURe label, Settings and Statements, card lock and store handoff, and Back navigation.

Residence change review

  • Show Under review and a support path after submitting residence evidence or reopening a held upload. Prevent duplicate uploads for the same target and retain the option to choose a different country.
  • Add the review state to the shared residence drawer and capture catalogue. Include English, Latin American Spanish, and Brazilian Portuguese copy, with the existing fallback for Argentina.

TASK-24823 and TASK-24822.

  • Keep the review copy concise and record the measured 16-word drawer increase and two-word Profile increase for the review status and support action.
  • Mono records the full-picker decision and distinguishes submission, review and correction in support guidance. Activation funnel · Support answers

Review follow-ups

  • Preserve Avenia Pix routes on dev. Use the Pix deposit route to determine readiness even when the legacy local account is unavailable.
  • Share the owner-scoped deposit account cache, skip standing account reads when the feature is off, and require complete transfer instructions for the selected corridor.
  • Use the shared best-effort analytics helper and show Still creating your card with a safe recheck when the issuance deadline passes without a fresh response.
  • The bank account icon remains green pending a design decision. Crypto uses the documented blue. QR Pay uses brand pink.

Release order

The narrow Bridge account setup hotfix is in UI #4069. This PR targets dev. The API changes landed on main in API #2110 and are ported to dev in API #2115. Confirm the API revision is live before releasing the dependent UI.

Verification

  • 125 focused card tests, 26 capture catalogue checks, and 11 publishing and provenance checks passed locally, along with TypeScript, changed-source lint, and formatting.
  • The preceding setup revision passed required CI and all 976 captures. All three setup fixes passed in the browser suite. The only browser failure was the existing desktop feature-directory link, whose anchor appears inside a hidden Suspense segment during rendering. Previous screenshot run
  • 278 focused residence, KYC hook, and modal tests passed. The capture catalogue passed 30 checks.
  • Changed-file Prettier and the residence drawer wordiness check passed locally.
  • The configured 180-second commit gate passed. The final focused Pix, bank account list and icon suites passed 129 tests. Changed-file ESLint reported no errors. The dev Screen Library catalogue tests passed.
  • Visual comparison from the prior main-targeted revision

@innolope-dev innolope-dev self-assigned this Nov 11, 2026
@vercel

vercel Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
peanut-wallet Ready Ready Preview Nov 12, 2026 7:46am UTC

Request Review

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Code-analysis diff

Painscore total: 11191.26 → 11241.56 (+50.3)
Findings: +42 net (+261 new, -219 resolved)

🆕 New findings (261)

  • critical complexity — src/features/paperwork-verification/PaperworkVerificationFlow.tsx — CC 399, MI 59.6, SLOC 1280
  • critical complexity — src/features/card/useCardFlow.ts — CC 297, MI 49.99, SLOC 1063
  • critical complexity — src/hooks/useSumsubKycFlow.ts — CC 257, MI 48.85, SLOC 1065
  • critical complexity — src/hooks/useMultiPhaseKycFlow.ts — CC 191, MI 51.83, SLOC 777
  • critical complexity — src/dev/surfaces/registry.tsx — CC 177, MI 67.22, SLOC 878
  • critical complexity — src/app/actions/sumsub.ts — CC 128, MI 44.29, SLOC 456
  • critical complexity — src/utils/native-routes.ts — CC 127, MI 53.44, SLOC 323
  • critical complexity — src/features/add-money/AddMoneyOptions.tsx — CC 124, MI 58.56, SLOC 294
  • critical complexity — src/features/deposit-accounts/components/DepositAccountsFlow.tsx — CC 123, MI 59.18, SLOC 235
  • critical complexity — src/components/Setup/components/SetupWrapper.tsx — CC 105, MI 62.85, SLOC 204
  • critical complexity — src/features/deposit-accounts/components/AccountsHubList.tsx — CC 100, MI 58.73, SLOC 274
  • critical complexity — src/features/card/CardPage.tsx — CC 99, MI 60.81, SLOC 289
  • critical complexity — src/features/paperwork-verification/useKycFeatureActivation.ts — CC 98, MI 50.91, SLOC 199
  • critical complexity — src/components/AddMoney/components/MantecaAddMoneyFlow.tsx — CC 90, MI 55.39, SLOC 315
  • critical complexity — src/components/Global/PeanutActionDetailsCard/index.tsx — CC 90, MI 54.45, SLOC 119
  • critical method-complexity — src/features/deposit-accounts/components/DepositAccountsFlow.tsx:117 — DepositAccountsFlow CC 76 SLOC 136
  • critical complexity — src/features/deposit-accounts/useDepositGateRemediation.tsx — CC 76, MI 57.83, SLOC 231
  • critical complexity — src/dev/fixtures/registry.ts — CC 72, MI 30.17, SLOC 4582
  • critical complexity — src/components/Common/CountryList.tsx — CC 62, MI 58.76, SLOC 166
  • critical complexity — src/components/Profile/views/ResidenceChangeDrawer.tsx — CC 58, MI 56.91, SLOC 139

…and 241 more.

✅ Resolved (219)

  • src/features/paperwork-verification/PaperworkVerificationFlow.tsx — CC 397, MI 59.58, SLOC 1275
  • src/features/card/useCardFlow.ts — CC 238, MI 50.21, SLOC 893
  • src/hooks/useSumsubKycFlow.ts — CC 234, MI 48.47, SLOC 968
  • src/hooks/useMultiPhaseKycFlow.ts — CC 191, MI 51.88, SLOC 773
  • src/dev/surfaces/registry.tsx — CC 173, MI 67.16, SLOC 862
  • src/app/actions/sumsub.ts — CC 126, MI 44.42, SLOC 451
  • src/utils/native-routes.ts — CC 126, MI 53.44, SLOC 323
  • src/features/deposit-accounts/components/DepositAccountsFlow.tsx — CC 117, MI 59.44, SLOC 231
  • src/components/Setup/components/SetupWrapper.tsx — CC 102, MI 62.9, SLOC 204
  • src/features/deposit-accounts/components/AccountsHubList.tsx — CC 95, MI 59.01, SLOC 269
  • src/features/card/CardPage.tsx — CC 93, MI 61.34, SLOC 270
  • src/components/Global/PeanutActionDetailsCard/index.tsx — CC 90, MI 54.67, SLOC 117
  • src/components/AddMoney/components/MantecaAddMoneyFlow.tsx — CC 87, MI 55.06, SLOC 311
  • src/dev/fixtures/registry.ts — CC 72, MI 30.24, SLOC 4556
  • src/features/deposit-accounts/components/DepositAccountsFlow.tsx:117 — DepositAccountsFlow CC 71 SLOC 134
  • src/features/deposit-accounts/useDepositGateRemediation.tsx — CC 68, MI 59.14, SLOC 211
  • src/features/paperwork-verification/useKycFeatureActivation.ts — CC 64, MI 53.16, SLOC 175
  • src/components/Common/CountryList.tsx — CC 56, MI 59.69, SLOC 156
  • src/dev/screens/catalogue.ts — CC 53, MI 49.28, SLOC 325
  • src/hooks/useSumsubKycFlow.ts:455 — CC 51 SLOC 181

…and 199 more.

📈 Painscore deltas (top movers)

File Before After Δ
src/features/add-money/AddMoneyOptions.tsx 0.0 11.4 +11.4
src/features/add-money/useAddMoneyReadiness.ts 0.0 7.9 +7.9
src/features/add-money/addMoneyMethods.ts 0.0 7.0 +7.0
src/features/add-money/CurrencyRefusalScreen.tsx 0.0 5.4 +5.4
src/features/add-money/AddMoneyPicker.tsx 0.0 5.2 +5.2
src/components/Kyc/ResidenceReviewModal.tsx 0.0 3.9 +3.9
src/features/card/useCardFlow.ts 18.5 21.2 +2.7
src/features/add-money/analytics.ts 0.0 1.9 +1.9
src/features/paperwork-verification/useKycFeatureActivation.ts 10.0 11.7 +1.8
src/features/home/HomePage.tsx 6.1 7.8 +1.7
src/app/(mobile-ui)/add-money/options/page.tsx 0.0 1.7 +1.7
src/features/home/components/HomeActionDrawers.tsx 7.6 8.6 +0.9
src/features/add-money/AddMoneyBankPage.tsx 4.2 5.2 +0.9
src/features/deposit-accounts/components/DepositAccountsListScreen.tsx 10.3 11.3 +0.9
src/hooks/useSumsubKycFlow.ts 23.8 24.6 +0.8
src/features/paperwork-verification/KycFeatureActivationGate.tsx 5.1 5.8 +0.7
src/components/Common/CountryList.tsx 9.4 10.0 +0.7
src/features/deposit-accounts/useDepositGateRemediation.tsx 9.6 10.3 +0.6
src/features/deposit-accounts/rails.ts 6.7 7.2 +0.5
src/features/home/home-drawer-options.ts 4.4 3.9 -0.5

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

🧪 UI test report — ✅ all green

Suites

  • ✅ unit: 19924 ran, 0 failed, 0 skipped, 9.2m

📊 Coverage (unit)

metric %
statements 87.9%
branches 80.7%
functions 82.0%
lines 89.4%
⏱ 10 slowest test cases
time test
🐢 24.8s scripts/__tests__/screens-adapter.test.js › runs the existing synthetic screen adapter Node acceptance suite
🐢 16.5s src/features/deposit-accounts/__tests__/AddMoneyArgentinaCountry.acceptance.test.tsx › keeps unavailable Argentina searchable and opens its residence explanation with Enter
🐢 15.7s src/features/deposit-accounts/__tests__/AddMoneyArgentinaCountry.acceptance.test.tsx › keeps unavailable Argentina searchable and opens its residence explanation with pointer
🐢 14.8s src/features/deposit-accounts/__tests__/AddMoneyArgentinaCountry.acceptance.test.tsx › keeps unavailable Argentina searchable and opens its residence explanation with Space
🐢 9.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › Network failure keeps loading while retries remain, then shows the generic error
🐢 9.0s src/features/deposit-accounts/__tests__/AddMoneyArgentinaCountry.acceptance.test.tsx › preserves ordinary Argentina selection for residence AR
🐢 8.7s src/features/deposit-accounts/__tests__/AddMoneyArgentinaCountry.acceptance.test.tsx › preserves ordinary Argentina selection for residence null
🐢 6.6s scripts/__tests__/indexable-urls.test.ts › excludes missing locale files, drafts, redirects, and retired pages from crawl and submission lists
🐢 6.4s scripts/__tests__/signup-attribution-paths.test.ts › includes newly published articles and locale fallbacks without editing the manifest
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › routes the KYC rejection on its wire code, and does not retry it
📍 Inline annotations are in the **Unit test report** check above. Coverage artifact: `coverage-unit`. Generated by `.github/workflows/tests.yml`.

Preserve the bank claim identity restart and bind its verification requests to the initiating account.

@chip-peanut-bot chip-peanut-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chip review — no blocking findings — this is not an approval

No confirmed defects at the pinned head. Four CI checks were still running at review time.

Checked clean

  • Bridge setup preview and exact-currency gate against the paired API contract; no conflicting behavior found.
  • Explicit restart dispatch, terminal hold, and signed-in account switch guards; no reachable regression found.
  • Add Money analytics event scope, country-list navigation, and capture failure behavior; no defect found.
  • Design-system rules for the changed UI; no deviation found.
  • CI at this head: completed checks had no failures; unit, ds-shots, i18n-overflow, and press-contract were still running.

Security review by moonshotai/kimi-k3: 0 finding(s), marked with the model name. It reads the diff only and answers only security, privacy and money, so treat its findings as advice.

Third opinion by claude-opus: 0 finding(s), marked with the model name. It answers only product truth, missing tests and the cross-repo contract, so treat its findings as advice.

Copy check by claude-haiku-5-5: 0 finding(s), titled "Copy now wrong". Every quoted passage was checked against the file.

Exact head: 6c71651046e1 · Context: repo, product, design, sibling-api, ci · Took 8m

@chip-peanut-bot chip-peanut-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chip review — no blocking findings — this is not an approval

Two findings on the new head: one failing copy gate and one unavailable-country navigation regression.

Findings

  • MAJOR · src/features/paperwork-verification/KycFeatureActivationStatus.tsx:58 · Account-status copy fails the screen-wordiness check
    At this head, the screen-wordiness check fails five over-baseline screens: ClaimAccountScreen (+20 words), Card (+42), Add Money bank and Withdraw bank (+20 each), and DepositAccountsListScreen (+4). The new shared refusal-copy branches are counted by KYC-gate consumers; the new Argentina note grows the list. This check passed on the previous head. Shorten or scope the added copy, or update the baseline with a documented reason for intentional growth.

  • MINOR · src/components/Common/CountryList.tsx:291 · Unavailable Argentina row loses its residence action
    With a known non-Argentine residence, the Add Money Argentina row gets an unavailable reason and is disabled, so pointer and keyboard selection do nothing. That removes access to the existing ResidenceRequiredScreen, which explains the restriction and offers Update residence and QR pay. design.md → rows the user cannot act on requires unavailable rows to remain tappable and reserves disabled styling for in-flight reads. Keep the row selectable and lead to that explanation instead of disabling it.

Checked clean

  • Exact head, trusted PR metadata, and merge base matched the supplied identifiers.
  • Selected-currency waiting/refusal handling, Manteca country scoping, and Pix verification routing were compared with their focused acceptance tests; no additional confirmed regression.
  • Earlier Bridge claim/restart and Add Money analytics paths were unchanged from the prior clean review.
  • CI at this head: screen-wordiness failed; unit, i18n-overflow, ds-shots, Deploy-Preview, press-contract, and seo-contract remained in progress at review time.

Security review by moonshotai/kimi-k3: 0 finding(s), marked with the model name. It reads the diff only and answers only security, privacy and money, so treat its findings as advice.

Third opinion: did not run — it reads only the first review of a pull request; the first reviewer checks later rounds. This review is one reviewer short.

Copy check by claude-haiku-5-5: 0 finding(s), titled "Copy now wrong". Every quoted passage was checked against the file.

Exact head: ad8cab5a4236 · Context: repo, product, design, ci · Took 6m

Comment thread src/components/Common/CountryList.tsx Resolved
Hugo0
Hugo0 previously approved these changes Nov 11, 2026
Hugo0
Hugo0 previously approved these changes Nov 12, 2026

@chip-peanut-bot chip-peanut-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chip review — no blocking findings — this is not an approval

The checklist Add money route still disagrees with the canonical activation funnel, and this head introduces failing screen-wordiness and format checks. No separate card-issuance or residence-review state defect was confirmed.

Findings

  • MAJOR · src/components/Home/GettingStartedChecklist.tsx:185 · Checklist Add money entry disagrees with activation funnel
    Tapping the Home checklist Add money row now opens /add-money, while product/activation-funnel.md explicitly specifies the Home Add drawer with bank first and crypto second as this row’s destination. This remains unchanged at this head. Restore the documented entry point, or update the canonical funnel decision and its intended ordering alongside this change.

  • MAJOR · src/components/Profile/views/ResidenceChangeDrawer.tsx:203 · Residence-review copy exceeds the screen word budget
    The new review callout adds the full reviewBody to the residence drawer, and the shared copy also reaches other screens. The screen-wordiness check fails on this head; design.md’s word-budget rule limits existing screens to their baseline and counts callout text twice. Shorten or collapse the added explanation, then regenerate only any intentionally changed baseline.

  • MINOR · src/components/Profile/components/tests/ResidenceMenuItem.test.tsx:128 · New residence-review test fails formatting check
    The format check fails on src/components/Profile/components/tests/ResidenceMenuItem.test.tsx after this new test was added. Format this test with the repository Prettier configuration so the required check passes.

  • MAJOR · src/components/Profile/views/ResidenceChangeDrawer.tsx:98 · Copy now wrong: A residence change under review can no longer be completed from the app; the support docs still tell users to finish the verification
    After this change: While a residence change is REVIEW_PENDING for the requested country, the app hides the submit action, disables Save, shows an 'Under review' callout and offers only Contact support, so the user cannot complete or resubmit the verification for that country.

These places still say otherwise:

  • mono:product/support-answers/card-country-restrictions.md:65 — "to re-select the approved country (cancel) or complete the new-residence verification." → to re-select the approved country (cancel). If the new residence is already submitted and shows 'Under review', there is nothing to complete in the app; wait for the review or contact support.
  • mono:product/support-answers/card-country-restrictions.md:34 — "residence verification if the move is real." → residence verification if the move is real and not yet submitted. If it is already submitted and shows 'Under review', wait for the review or contact support.
  • mono:product/support-answers/card-not-showing-after-kyc.md:45 — "Payment Channels → Residence**, or finish verification if the move is real." → Payment Channels → Residence**, or, if the move is real and already submitted, wait for the 'Under review' result or contact support.

Fix them in this pull request, or say where the fix goes. mono: copy ships to mono main as its own content change, never inside a code PR.

Answered by a human, not raised again

These are still present as far as this review can tell. You resolved the thread or deferred the fix, so Chip does not repeat them. If one needs a follow-up, file the task yourself.

  • MAJOR · src/components/Home/GettingStartedChecklist.tsx:185 · Copy now wrong: Checklist Add money row opens /add-money, but activation-funnel still says Home Add drawer

Checked clean

  • Verified trusted PR metadata, exact head and base, clean detached worktree, and current-head CI.
  • Rechecked P1–P6 against this head: the earlier account-status copy, Argentina action, capture ordering/checkpoint, and duplicate checklist reports do not warrant separate findings; P7 remains.
  • Reviewed card issuance polling, retry, owner fencing, pending-application tests, and residence-review action, drawer, modal, and tests; no additional confirmed defect.

Security review by moonshotai/kimi-k3: 0 finding(s), marked with the model name. It reads the diff only and answers only security, privacy and money, so treat its findings as advice.

Third opinion: did not run — it reads only the first review of a pull request; the first reviewer checks later rounds. This review is one reviewer short.

Copy check by claude-haiku-5-5: 2 finding(s), titled "Copy now wrong". Every quoted passage was checked against the file.

Exact head: b0c263fbdda1 · Context: repo, product, design, CI · Took 7m

@innolope-dev innolope-dev changed the title fix(deposit-accounts): surface Bridge setup before claim fix: Add Money picker and analytics, bank setup, residence review, card issuance, and signup layout Nov 12, 2026

@kushagrasarathe kushagrasarathe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From Kush's agent (pr-review):

Requesting changes for one design-rule break and the release path. The code itself looks sound and CI is green. Smaller nits are inline.

To fix before merge:

  1. Icon colours (inline on conceptIcons.tsx): get a ruling from Hugo or Konrad and update design/design.md in mono, or revert the two lines.
  2. Release path: this goes to main as a hotfix but carries new features too (Add Money picker, /add-money/options, 5 analytics events, the Home Add drawer, icon colours). ops/releases.md keeps the hotfix path to P0/P1, every main merge also ships an OTA, and release ui#4059 is still open. Either split the Bridge setup fix into a small hotfix and send the rest through dev, or get Hugo and the release captain to sign off on shipping it whole.
  3. Open a dev twin or plan a same-day main→dev back-merge. None of the new files exist on dev, so the next release would conflict with or revert this.
  4. Merge after api#2110 is deployed. Without it, the residence-review and restart-identity branches never fire.
  5. Reply to Chip's open threads on GettingStartedChecklist.tsx:185. mono 52adf78bc probably answers them.

*/
export const CONCEPT_ICONS = {
bank: { icon: 'bank', color: 'blue' },
bankAccount: { icon: 'bank', color: 'green' },

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: design/design.md (icon bubble colour table) says green means "done" and is never for a concept, and IconBubble.tsx:13 in this PR still says "green: done". A green bank icon on Home and Add money reads as "already done".

Comment thread src/features/home/HomePage.tsx Resolved
Comment thread src/features/card/useCardFlow.ts Resolved

@chip-peanut-bot chip-peanut-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chip review — no blocking findings — this is not an approval

No confirmed findings at this head. Earlier review issues are fixed or no longer apply after the dev integration.

Checked clean

  • Verified trusted author, open PR, exact dev base and head, clean detached worktree, and the 104-file base-to-head diff.
  • Rechecked P1–P11: activation-funnel.md now specifies the checklist picker; support guidance distinguishes submission from review; Argentina action and capture checkpoints remain; residence copy, baseline, and test formatting are updated.
  • Reviewed Add Money picker and returning-user drawer, account readiness and selected-currency gates, Pix route integration, residence review, card issuance wait/retry, KYC identity fencing, and corresponding focused tests.
  • Current-head screen-wordiness, screen-tests, typecheck, format, and other completed focused checks succeeded; unit, i18n-overflow, capture_after, press-contract, seo-contract, and preview were still running when checked.

Security review by moonshotai/kimi-k3: 0 finding(s), marked with the model name. It reads the diff only and answers only security, privacy and money, so treat its findings as advice.

Third opinion: did not run — it reads only the first review of a pull request; the first reviewer checks later rounds. This review is one reviewer short.

Copy check by claude-haiku-5-5: 0 finding(s), titled "Copy now wrong". Every quoted passage was checked against the file.

Exact head: 4277e985fbb9 · Context: repo, product, design, CI · Took 6m

@github-actions

Copy link
Copy Markdown
Contributor

English

Open screen library dashboard

Review preview: dcbfe47 → 4277e98. Incomplete capture; unavailable states are listed in the report. Other locales were not captured; add the screens:all-locales label and re-run Screen library to include them.

Before was captured with the base branch's own synthetic API because this PR changes it; differences can include synthetic-data changes.

Screen Library coverage: fail — UI review needs a complete, unique comparison for every required locale.

Screen Library copy: fail — 4 changed copy key(s) appear in no captured state: card.status.creatingCardBody, card.status.creatingCardTitle, card.status.stillCreatingTitle, depositAccounts.list.notOfferedHereBody. 7 baseline entries are now shown or deleted; remove from scripts/screens/copy-coverage-baseline.json: identity.reasons.identity_document_insufficient, profile.unlockPayments.changeModal.lost.local, profile.unlockPayments.changeModal.lostBody, profile.unlockPayments.changeModal.lostTitle, profile.unlockPayments.changeModal.saveAnyway, profile.unlockPayments.changeModal.verifiedMismatchNote, setup.notifications.notNow. Add a capture state that shows the copy, or add the keys to the baseline with “Screen Library copy exception: ” on its own line in the PR description. Copy coverage: 1257/4002 keys shown.

@innolope-dev

Copy link
Copy Markdown
Collaborator Author

Replaced by #4083.

This branch was successfully deployed

1 active and 1 inactive (outdated) deployments
Preview — 4277e985 Deployed Nov 12, 2026 by vercel[bot]
content-publish — 51f32687 Deployed Nov 12, 2026 by innolope-dev via approve-and-merge #7921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants