Repository navigation
fix(deposit-accounts): show Bridge setup before opening an account - #4069
innolope-dev wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Code-analysis diffPainscore total: 11163.31 → 11163.4 (+0.09) 🆕 New findings (2)
✅ Resolved (2)
|
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
One stale-capability recovery gap remains in the Bridge review flow.
Findings
-
MAJOR · src/features/deposit-accounts/useDepositAccounts.ts:341 · Retry the capability refresh while a review action is withheld
If the accounts preview reportsreview-actionwhile the cached capability still saysready(orneeds-enrollment), this effect makes just one [USER] refresh. A 429 on that request is not retried, andreview-actiondoes not poll the accounts query; with the screen left open, the gate stayspendingand the user never gets the Bridge terms action. Keep refreshing the capability with a bounded retry while this mismatch persists, or arrange a retry on subsequent preview updates. -
MAJOR · src/features/deposit-accounts/useDepositAccounts.ts:319 · Copy now wrong: Review-action corridor's wait drawer says nothing is needed from the user
After this change: When a corridor's review waits on the user (cause review-action) and the cached gate reads ready or needs-enrollment, the gate is now forced to pending, so the drawer shows the wait copy with no button.
These places still say otherwise:
pr:src/i18n/app/messages/en.json:5196— "Nothing for you to do. This page updates by itself." → Your review is waiting on you. Check this account again in a moment to see the next step.pr:src/i18n/app/messages/es-419.json:5196— "No tienes que hacer nada. Esta pantalla se actualiza sola." → Tu revisión espera algo de ti. Vuelve a revisar esta cuenta en un momento para ver el siguiente paso.pr:src/i18n/app/messages/es-AR.json:2242— "No tenés que hacer nada. Esta pantalla se actualiza sola." → Tu revisión espera algo de tu parte. Volvé a revisar esta cuenta en un momento para ver el siguiente paso.pr:src/i18n/app/messages/pt-BR.json:5196— "Você não precisa fazer nada. Esta tela se atualiza sozinha." → Sua revisão depende de você. Confira esta conta de novo em instantes para ver o próximo passo.
Fix them in this pull request, or say where the fix goes. mono: copy ships to mono main as its own content change, never inside a code PR.
Checked clean
- Pinned head and exact base diff; PR metadata and CI at this head (unit, typecheck, CodeQL passed; review and visual checks still in progress).
- Capability gate, account-preview, claim, and user-query refresh paths; design-system row guidance.
Security review: did not run — this change has no security, privacy or money surface, so it was not asked. This review is one reviewer short.
Third opinion by claude-opus: 0 finding(s), marked with the model name. It answers only product truth, missing tests and the cross-repo contract, so treat its findings as advice.
Copy check by claude-haiku-5-5: 1 finding(s), titled "Copy now wrong". Every quoted passage was checked against the file.
Exact head: 2b9f1e175d62 · Context: repo, design, api · Took 2m
| useEffect(() => { | ||
| // A withheld corridor cannot be tapped through to a claim. Fetch its | ||
| // missing action even when the user never presses the claim button. | ||
| if (enabled && userId && staleReviewAction) void queryClient.invalidateQueries({ queryKey: [USER] }) |
There was a problem hiding this comment.
MAJOR: Retry the capability refresh while a review action is withheld
If the accounts preview reports review-action while the cached capability still says ready (or needs-enrollment), this effect makes just one [USER] refresh. A 429 on that request is not retried, and review-action does not poll the accounts query; with the screen left open, the gate stays pending and the user never gets the Bridge terms action. Keep refreshing the capability with a bounded retry while this mismatch persists, or arrange a retry on subsequent preview updates.
| for (const corridor of DEPOSIT_RAIL_ORDER) { | ||
| const gate = gateFor('deposit', { railId: railIdFor(corridor) }) | ||
| const cause = unavailable[corridor]?.cause | ||
| const setupUnderWay = cause === 'setup-pending' || cause === 'review-pending' || cause === 'review-action' |
There was a problem hiding this comment.
MAJOR: Copy now wrong: Review-action corridor's wait drawer says nothing is needed from the user
After this change: When a corridor's review waits on the user (cause review-action) and the cached gate reads ready or needs-enrollment, the gate is now forced to pending, so the drawer shows the wait copy with no button.
These places still say otherwise:
pr:src/i18n/app/messages/en.json:5196— "Nothing for you to do. This page updates by itself." → Your review is waiting on you. Check this account again in a moment to see the next step.pr:src/i18n/app/messages/es-419.json:5196— "No tienes que hacer nada. Esta pantalla se actualiza sola." → Tu revisión espera algo de ti. Vuelve a revisar esta cuenta en un momento para ver el siguiente paso.pr:src/i18n/app/messages/es-AR.json:2242— "No tenés que hacer nada. Esta pantalla se actualiza sola." → Tu revisión espera algo de tu parte. Volvé a revisar esta cuenta en un momento para ver el siguiente paso.pr:src/i18n/app/messages/pt-BR.json:5196— "Você não precisa fazer nada. Esta tela se atualiza sozinha." → Sua revisão depende de você. Confira esta conta de novo em instantes para ver o próximo passo.
Fix them in this pull request, or say where the fix goes. mono: copy ships to mono main as its own content change, never inside a code PR.
|
Replaced by #4083. |
A user could finish identity verification, tap to open a SEPA account, and hit a refusal while the requested Bridge rail was still setting up. Refresh the user capability when the account preview or claim reports setup in progress. This lets the existing Bridge terms prompt surface and keeps the selected currency pending until it can be opened.
This hotfix contains the account setup hook and its regression tests. The Add Money picker, analytics, card, and signup changes are tracked in #4065 for dev.
All 38 focused deposit account tests and the configured commit gate passed. The release captain should confirm API #2110 is live before merging this PR. The same UI fix is included in the #4065 dev port.