Repository navigation
fix(TASK-24847): show Log in as a button at once on the app landing, drop the iOS auto login - #4085
Conversation
…auto login once Since 0311620 (ui#3972) the native landing hid Log in until the passkey check answered or 5 s passed. Android often answers 'unknown' (below 14, no permission, slow Credential Manager), so Konrad saw no Log in for seconds. Each Landing mount restarted the check, so going back from Claim username hid it again, and on iOS opened the system sign-in sheet again; the unmount cleanup did not retire that attempt, so its sheet could show over the next step. Log in now starts as the link and upgrades to the full button only when Android confirms a passkey before the deadline. The iOS automatic login runs at most once per app launch, never after a Sign up or Log in tap, and unmount aborts it and frees the native slot. The once-per-launch module matches the one in ui#4077 so the two merge cleanly.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Code-analysis diffPainscore total: 11195.97 → 11191.07 (-4.9) 🆕 New findings (14)
✅ Resolved (16)
📈 Painscore deltas (top movers)
|
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
🖼 Visual diff — 8 screens moved13 of 558 shots changed · 545 identical · baseline
job summary · before/after/diff images — artifact Fixture screenshots, no backend. Advisory — this check never blocks a merge. Posted from the default branch by ds-shots-comment.yml; the report it renders is untrusted data. |
…p landing Kush decided Log in must never change shape. The Android passkey check only chose between the button and a link, so it goes too. The native PasskeyAvailability plugin stays until a store build, because removing it changes the binary.
returning iOS devices log in at the same rate with and without the auto prompt (57.6% old bundle vs 58.0% new), 90% of auto logins only replaced a Log in tap, and the auto attempt could open the sheet over the username step. Log in is now the only path to the passkey prompt, so the auto-login state, the per-launch flag, the iOS capability probe and the immediate/cancel options in useLogin/useZeroDev go.
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
No findings.
Findings
- MAJOR · src/components/Setup/Views/Landing.tsx:248 · Copy now wrong: product/app.md still says Log in is hidden on Android without a passkey, appears as a link after 5 seconds, and iOS opens a sign-in sheet by itself
After this change: On the app welcome screen, Log in is always a visible button below Sign up on every device, and no passkey sign-in sheet opens on its own when the screen appears.
These places still say otherwise:
mono:product/app.md:80— "1. Welcome — "Earn anywhere. Spend worldwide." The user taps Sign up. In the app, Log in depends on the device. On Android it shows as a button when the phone has a saved Peanut passkey and stays hidden when the phone reports none. On i" → 1. Welcome — "Earn anywhere. Spend worldwide." The user taps Sign up. In the app, Log in is always a button below Sign up, on Android, iOS and web alike. Nothing opens a passkey sign-in sheet on its own when the screen appears; the user
Fix them in this pull request, or say where the fix goes. mono: copy ships to mono main as its own content change, never inside a code PR.
Checked clean
- Confirmed the supplied head SHA and exact merge base; reviewed the native landing, login hooks, removed auto-login path, and updated tests.
- Checked the design-system button guidance; the changed secondary login action uses the existing Button component.
- Unit and typecheck passed at this SHA. The ds-shots regression failure is in the unrelated marketing-directory viewport spec, outside the changed setup/auth files.
Security review by moonshotai/kimi-k3: 0 finding(s), marked with the model name. It reads the diff only and answers only security, privacy and money, so treat its findings as advice.
Third opinion by claude-opus: 0 finding(s), marked with the model name. It answers only product truth, missing tests and the cross-repo contract, so treat its findings as advice.
Copy check by claude-haiku-5-5: 1 finding(s), titled "Copy now wrong". Every quoted passage was checked against the file.
Exact head: d92808eae255 · Context: repo, design · Took 3m
… into the release Conflicts in Landing, useLogin, useZeroDev and the Landing tests: main's behaviour wins on Log in (always the secondary button, no passkey check wait) and on the dropped iOS automatic login; the release keeps the Welcome headline test, recovery after a failed login, the signup draft reset and the username hold. The once-per-launch auto-login helper and the landing passkey helpers had no callers left and are removed.
Why
P1 on the native app landing, since 0311620 (ui#3972, Sprint 167 / v1.25.0).
unknownon Android below 14, without permission, or when Credential Manager is slow, andunknownwas ignored, so Log in appeared only at the 5 s deadline.What changed
src/components/Setup/Views/Landing.tsxPASSKEY_CHECK_TIMEOUT_MS, and theSetupDocLink onBeforeOpenhook. Log in, Sign up, the recovery drawer and the recovery link calllogin/signUpdirectly. Sign up is disabled on native while a login is in flight.src/utils/landing-passkeys.tsis deleted (nothing usessupportsIOSImmediateLoginorcancelIOSImmediateLoginany more).src/hooks/useLogin.tsx,src/hooks/useZeroDev.ts: theimmediateSignal/immediateDeadline/cancelSignaloptions and thelogin_autoceremony purpose are removed, because only the automatic login passed them. The manual login path is unchanged.Unchanged: Sign up, the recovery link and drawer, error handling, analytics, and the web layout (
blockSignup).Delivery
JS only, no native change.
git diff --name-only origin/main...HEADlists nothing underandroid/,ios/,patches/orcapacitor.config.ts. An OTA update reaches every affected app on v1.25.0 or later.Dead native code left
These stay until a store build, because removing them changes the binary or a native patch:
PasskeyAvailabilityPluginis no longer called from JS.immediateLoginbits inpatches/@capgo__capacitor-passkey.patch(getConfiguration().immediateLogin,cancelRequest).immediateSignal/immediateDeadlinesupport inpatches/@zerodev__webauthn-key.patch.canceloption ofguardPasskeyCeremonyandCeremonyCancelledErrorinsrc/utils/passkeyCeremony.utils.tshave no caller now. Left in place because they are shared ceremony code.Tests
Landing.passkeys.test.tsx: the iOS automatic login tests and thelanding-passkeys/landing-auto-loginmocks are deleted with the code. Cases:Landing.test.tsx: thelanding-passkeysmock is removed.npm run typecheck,npm test -- --maxWorkers=4(1331 suites, 19541 passed, 5 skipped) andnpm run buildare all green.Screenshots
375×667, logged out, Playwright with faked native bridges. Before =
origin/main, after =d92808e. In the before shots, a "SIMULATED iOS system Sign In sheet" overlay marks where the real iOS sheet would open by itself. Assets live on branchpr-assets-4085, deleted after merge.Android with a Peanut passkey
Android without a passkey
Android 13 and older (check unsupported)
Android, slow passkey check
iOS, automatic login build
iOS, older app build
Android, back from the username step
iOS, back from the username step
Web browser
Overlap
ui#4077 also edits the iOS auto login in Landing.tsx; whichever merges second needs a rebase.
🤖 Generated with Claude Code