Skip to content

feat(setup): A2 Welcome screen, the peanut cheers under a received payment - #4088

Draft
0xkkonrad wants to merge 6 commits into
devfrom
feat/a2-first-screen
Draft

0xkkonrad wants to merge 6 commits into
devfrom
feat/a2-first-screen

Conversation

@0xkkonrad

@0xkkonrad 0xkkonrad commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Konrad picked first-screen concept A2 "Atrapá el pago" for the sign-up Welcome screen (13 Nov 2026), on the existing periwinkle setup hero, not pink. The old screen named no source, showed no money and did not match the store frames people see before they install.

Commit 1: the A2 Welcome screen

  • Taller Welcome hero (.setup-hero-height-landing: 54dvh, 52dvh on short phones, full height on desktop). It holds the headline, the shipped cheering mascot, a sample "¡Dinero recibido! USD 1.200" card tagged "Ejemplo" / "Example", USD and EUR chips, and two stars and a sparkle (all approved art). Same --color-background-setup-hero token, so the status bar and safe-area colours do not change.
  • Reviewer fixes applied: the card floats above the mascot's whole jump, so it never covers the eyes. No timestamp, no payer, no dashed arc, larger USD / EUR chips. No mirrored mascot, no white rim, no Knerd, no flags.
  • Copy in en, es-419, es-AR (deltas) and pt-BR:
    • es-AR: "Cobrá desde EE. UU. y Europa." / "Recibí dólares y euros. Pagá con tarjeta o QR." / "Sin contraseña: entrás con tu cara o huella." / "Registrate" / "Ya tengo cuenta · Iniciá sesión"
    • en: "Get paid from the US and Europe." / "Receive dollars and euros. Pay by card or QR." / "No password. Sign in with your face or fingerprint." / "Sign up" / "Already have an account? Log in"
  • Motion: the card, chips and stars pop in on a fast overshoot spring, and the card bobs. Reduced motion shows the resting frame.
  • Next step: leaving Welcome eases the hero from 54% down to the shared 40% over the same 500 ms as the panel slide. Measured at 390×844: 456 → 404 → 370 → 351 → 341 → 338 px over about 480 ms, with no jump. The headline and scene fade out with the art.
  • Kept: analytics events, the native passkey check and Log in states (hidden, then button or link), the recovery link and drawer, the web store layout, the preview-build test box, and every flag. Only the link state of Log in gains the "Ya tengo cuenta ·" prompt in front of the link.

Commit 2: one new approved asset. Konrad approved the USD and EUR sticker coins (first-screen concept F1 art). They are added as lossless WebP (330×350) to src/assets/illustrations/ and to the approved list (/dev/ds/marketing/assets, landing illustrations). They mark the USD and EUR chips on the Welcome hero.

Task

No Notion task is linked yet. Konrad: please name the task this belongs to, or ask me to create one.

Interactions with #4083 and #4085 (both on main, not on dev)

Risks

  • UI only, sign-up entry screen. No API, money or data change.
  • The Welcome panel is shorter than before. At 390×844 on native (safe areas take about 81 px) the panel still has room. At 320×568 with the full Log in button, the button's 4 px shadow sits on the bottom edge. That was already the case in the reserved slot before this PR.

QA

  • Boat sandbox (Linux, Node 22.23): prettier --check on the changed files ✅, npm run typecheck ✅, npm run lint ✅ (0 errors, 65 warnings, none in changed files), npm run build ✅.
  • npm test: 1,359 of 1,360 suites pass. scripts/__tests__/capgo-release-guard.test.js fails with exit 128 because the sandbox copy has no .git and the test shells out to git. It is unrelated, and CI will run it.
  • First CI run: ds-lint (an off-scale md:pt-24, then an inline style) and screen-wordiness failed. Commit 3 fixes ds-lint. It also moves the /setup/finish and /verify wordiness baselines by +5: both import SetupWrapper, so the sample card's five words ("Money received!", "USD 1,200", "Example") count on them, although neither screen ever shows the Welcome hero. Re-run on the sandbox: ds-lint 0 regressions, wordiness ✅, typecheck ✅, setup suites 364/364 ✅.
  • Screenshots: headless Chromium on the sandbox, next dev with NEXT_PUBLIC_CAPACITOR_BUILD=true (native layout, Log in link after the 5 s check) and next start with the keep-web link (Log in button, clean next step). No backend: the connectivity toast and the Next dev badge were hidden in the capture.

Screenshots

⚠️ Not embedded. The repo ruleset requires verified signatures on every new branch, so the pr-assets-<pr#> orphan branch from peanut-pr could not be created (git push, the Git Data API and the Contents API were all refused). The 48 captures are in mono at _temp/first-screen/pr-a2/shots/ (each 1600 px or less):

File pattern What it shows
app-landing-{es-AR,en}-{390x844,320x568,android-412x915}.png Native layout (Capacitor build flag): A2 hero, body, no-password line, recovery link, Sign up, "Ya tengo cuenta · Iniciá sesión" link after the 5 s check
app-transition-{120,260}ms-…png Frames after tapping Sign up: hero shrinking to 40% while the panel slides
app-next-…png Claim username after the transition (the red passkey callout there is sandbox noise: Capacitor flag with no native bridge)
keepweb-landing-…png Keep-web browser layout: same hero, Log in as the full secondary button
keepweb-next-…png Claim username, clean (no sandbox callout)
keepweb-transition-…png Same transition frames in the keep-web layout

What a reviewer should check: card clear of the mascot's face across the jump, headline wraps at 320 px, the step change has no jump, and the Log in link is visible.

Native: ⚠️ needs a device pass (iOS and Android shell, real safe areas and status bar). Chromium cannot test the Capacitor shell.

Docs after merge (not in this PR): design/design.md § assets says "the animated hero pose is waving-chill", and engineering/ui/signup-hero-loops.md describes the landing as the waving mascot with clouds. Both go stale for the sign-up Welcome screen.

…yment

Konrad picked first-screen concept A2 ("Atrapá el pago") on 13 Nov 2026, on the
existing periwinkle hero instead of pink. The old screen named no source, showed
no money and did not match the store frames people saw before installing.

- Taller Welcome hero (54dvh, 52dvh on short phones) carries the headline, the
  cheering peanut, a sample "Money received! USD 1,200" card tagged "Example",
  USD and EUR chips, and stars. The card floats above the mascot's whole jump,
  so it never covers the face. No timestamp, payer or dashed arc.
- Leaving Welcome eases the hero down to the shared 40% height over the 500 ms
  panel slide, so the next step does not jump. Reduced motion: static scene,
  instant transition.
- Copy in en, es-419, es-AR and pt-BR: "Get paid from the US and Europe." /
  "Receive dollars and euros. Pay by card or QR." plus "No password. Sign in
  with your face or fingerprint." The Log in link reads "Already have an
  account? Log in".
- Log in visibility, the passkey checks, recovery, analytics and the web store
  layout are unchanged.
…Welcome chips

Konrad approved one new asset on 13 Nov 2026 in the first-screen run: the
smiling USD and EUR coins from concept F1. They join the approved inventory
(/dev/ds/marketing/assets, landing illustrations) as lossless WebP at the
source size (330x350), and mark the USD and EUR source chips on the Welcome
hero. The cheering pose entry now lists the Welcome hero as a use.
@vercel

vercel Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
peanut-wallet Ready Ready Preview Nov 13, 2026 3:45pm UTC

Request Review

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Code-analysis diff

Painscore total: 11050.75 → 11062.08 (+11.33)
Findings: +7 net (+24 new, -17 resolved)

🆕 New findings (24)

  • critical complexity — src/components/Setup/components/SetupWrapper.tsx — CC 116, MI 62.61, SLOC 228
  • critical complexity — src/components/Setup/Views/Landing.tsx — CC 75, MI 60.02, SLOC 267
  • high hotspot — src/components/Setup/components/SetupWrapper.tsx — 87 commits, +1763/-1445 lines since 6 months ago
  • high method-complexity — src/components/Setup/components/SetupWrapper.tsx:389 — SetupWrapper CC 39 SLOC 45
  • high complexity — src/components/Setup/Setup.consts.tsx — CC 2, MI 45.64, SLOC 86
  • medium high-mdd — src/components/Setup/Views/Landing.tsx:42 — LandingStep: MDD 91.6 (uses across many lines from declarations)
  • medium high-mdd — src/components/Setup/components/SetupWrapper.tsx:389 — SetupWrapper: MDD 68.5 (uses across many lines from declarations)
  • medium high-dlt — src/components/Setup/Views/Landing.tsx:42 — LandingStep: DLT 47 (calls 47 distinct functions — high context load)
  • medium high-mdd — src/components/Setup/components/SetupWrapper.tsx:233 — ImageSection: MDD 45.5 (uses across many lines from declarations)
  • medium high-mdd — src/components/Setup/components/SetupWrapper.tsx:163 — Navigation: MDD 32.0 (uses across many lines from declarations)
  • medium method-complexity — src/components/Setup/components/SetupWrapper.tsx:233 — CC 25 SLOC 26
  • medium high-mdd — src/components/Setup/Views/LandingHero.tsx:30 — LandingHero: MDD 23.7 (uses across many lines from declarations)
  • medium method-complexity — src/components/Setup/Views/Landing.tsx:42 — CC 15 SLOC 100
  • medium complexity — src/app/(mobile-ui)/dev/ds/marketing/assets/assets-data.ts — CC 9, MI 52.95, SLOC 187
  • medium complexity — src/components/Setup/components/StickerPop.tsx — CC 4, MI 58.03, SLOC 26
  • medium complexity — src/components/Setup/Views/LandingHero.tsx — CC 4, MI 64.49, SLOC 23
  • low high-dlt — src/components/Setup/components/SetupWrapper.tsx:389 — SetupWrapper: DLT 18 (calls 18 distinct functions — high context load)
  • low high-mdd — src/components/Setup/components/SetupWrapper.tsx:125 — TransitioningContent: MDD 12.0 (uses across many lines from declarations)
  • low nextjs-barrel-export — src/components/Setup/Views/index.ts:1 — barrel index.ts (6 re-exports)
  • low missing-return-type — src/components/Setup/components/SetupWrapper.tsx:34 — useSetupFullScreen: exported fn missing return type annotation

…and 4 more.

✅ Resolved (17)

  • src/components/Setup/components/SetupWrapper.tsx — CC 102, MI 62.9, SLOC 204
  • src/components/Setup/Views/Landing.tsx — CC 74, MI 59.79, SLOC 262
  • src/components/Setup/components/SetupWrapper.tsx — 85 commits, +1668/-1377 lines since 6 months ago
  • src/components/Setup/components/SetupWrapper.tsx:373 — SetupWrapper CC 33 SLOC 45
  • src/components/Setup/Setup.consts.tsx — CC 2, MI 45.61, SLOC 86
  • src/components/Setup/Views/Landing.tsx:42 — LandingStep: MDD 86.4 (uses across many lines from declarations)
  • src/components/Setup/components/SetupWrapper.tsx:373 — SetupWrapper: MDD 63.6 (uses across many lines from declarations)
  • src/components/Setup/components/SetupWrapper.tsx:224 — ImageSection: MDD 62.6 (uses across many lines from declarations)
  • src/components/Setup/Views/Landing.tsx:42 — LandingStep: DLT 46 (calls 46 distinct functions — high context load)
  • src/components/Setup/components/SetupWrapper.tsx:154 — Navigation: MDD 32.0 (uses across many lines from declarations)
  • src/components/Setup/components/SetupWrapper.tsx:224 — CC 21 SLOC 21
  • src/components/Setup/Views/Landing.tsx:42 — CC 15 SLOC 96
  • src/app/(mobile-ui)/dev/ds/marketing/assets/assets-data.ts — CC 9, MI 53.46, SLOC 179
  • src/components/Setup/components/SetupWrapper.tsx:373 — SetupWrapper: DLT 18 (calls 18 distinct functions — high context load)
  • src/components/Setup/components/SetupWrapper.tsx:116 — TransitioningContent: MDD 12.0 (uses across many lines from declarations)
  • src/components/Setup/Views/index.ts:1 — barrel index.ts (5 re-exports)
  • src/components/Setup/components/SetupWrapper.tsx:35 — useSetupFullScreen: exported fn missing return type annotation

📈 Painscore deltas (top movers)

File Before After Δ
src/components/Setup/Views/LandingHero.tsx 0.0 5.5 +5.5
src/components/Setup/components/StickerPop.tsx 0.0 4.6 +4.6
src/components/Setup/components/SetupWrapper.tsx 14.6 15.3 +0.7

…up screens

ds-lint caught an off-scale md:pt-24 and an inline style on the reduced-motion
path; both now use scale steps and framer-motion. screen-wordiness counts every
string a screen can import: /setup/finish and /verify import SetupWrapper, so
LandingHero's five sample-card words land on them although neither ever shows
the Welcome hero. Their baselines move by those 5 words.
@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

🧪 UI test report — ✅ all green

Suites

  • ✅ unit: 20196 ran, 0 failed, 0 skipped, 10.0m

📊 Coverage (unit)

metric %
statements 88.0%
branches 80.8%
functions 82.1%
lines 89.5%
⏱ 10 slowest test cases
time test
🐢 27.8s scripts/__tests__/screens-adapter.test.js › runs the existing synthetic screen adapter Node acceptance suite
🐢 9.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › Network failure keeps loading while retries remain, then shows the generic error
🐢 7.6s scripts/__tests__/indexable-urls.test.ts › excludes missing locale files, drafts, redirects, and retired pages from crawl and submission lists
🐢 7.1s scripts/__tests__/signup-attribution-paths.test.ts › includes newly published articles and locale fallbacks without editing the manifest
4.7s scripts/__tests__/indexable-urls.test.ts › gives crawls and IndexNow exactly the canonical inventory
4.3s src/components/Card/share-asset/__tests__/shareAssetLayout.test.ts › never places two stickers in heavy overlap (broad seed sweep)
4.1s scripts/__tests__/indexable-urls.test.ts › rejects explicit submissions outside the inventory and deduplicates canonical paths
4.0s src/features/setup/__tests__/useSignupPasskey.test.tsx › opens the help drawer for NotReadableError and retries from it with one more ceremony
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › a refused idempotency key tells the user to scan again, not to contact support
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › MANTECA_USER_NOT_PROVISIONED fails fast with copy that names the real cause
📍 Inline annotations are in the **Unit test report** check above. Coverage artifact: `coverage-unit`. Generated by `.github/workflows/tests.yml`.

…s one image

QA on #4088 found SetupWrapper carrying landing-only branches and the hero
weaker than the A2 mockup.

- A step can now pass `image: { hero }`; a hero carries the step's headline,
  so the wrapper makes it taller and starts the panel with the description.
  SetupWrapper no longer imports LandingHero, which puts the /setup/finish and
  /verify wordiness baselines back where dev had them.
- The headline hero takes what the Welcome panel leaves (measured per height
  band) instead of a fixed 54dvh, which pushed the page into a scroll on
  phones with safe areas; large text grows it until the headline fits and the
  scene gives way.
- Only entering or leaving a headline hero animates the height (500 ms, with
  the art crossfading over the same time); keyboard and address-bar resizes
  snap again, and the colour fade is back to dev's duration-fast. The
  outgoing panel fades in 200 ms so no button ends hang at the edge.
- The mascot sits on its own box with the card and chips placed on it, so the
  composition holds from 320 px to desktop: bigger peanut, feet on the hero's
  edge, fists under the card at the top of each jump, never over the eyes.
- StickerPop gets its own file and uses the DS motion tokens; the card and
  chips use 0_Bruddle/Card; the chips load 96 px coin variants.
- On desktop the panel's body and actions sit together mid-column.
…p one box

The A2 Welcome hero carries the headline and is taller, so the "one hero box
on every frame" rule failed on Welcome -> username. The spec now requires one
hero that never moves or changes width, a one-way height change that starts
at Welcome's height and ends at the board's 40% (34% at 320x568), and the
reverse on Back. Later steps still share one height, and Welcome is checked
for its own height with a reachable, unscrolled Sign up.
… own style

- Konrad ruled today that "no password" sounds like a problem, not a feature.
  The Welcome line now says what happens, from the round-2 spec: "Get in with
  your face or fingerprint." (es-AR, es-419 and pt-BR to match; never "Sign in").
- The prompt before the Log in link takes the link's type and colour instead
  of the call site overriding LinkButton, and the link's hit area reaches 44 px
  wide for short labels (en was 41 px, pt-BR 38 px).
- es-AR keeps Konrad's "Ya tengo cuenta" with the separator moved into markup
  (aria-hidden), and the link says "Iniciar sesión" like the Log in button.
  es-419 matches the button the same way.
- pt-BR description no longer repeats "Receba".
- The Welcome panel's gap drops to gap-6 so the hero keeps more room.

This branch was successfully deployed

1 active deployment
Preview — e6bb8748 Deployed Nov 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant