Repository navigation
Conversation
…yment
Konrad picked first-screen concept A2 ("Atrapá el pago") on 13 Nov 2026, on the
existing periwinkle hero instead of pink. The old screen named no source, showed
no money and did not match the store frames people saw before installing.
- Taller Welcome hero (54dvh, 52dvh on short phones) carries the headline, the
cheering peanut, a sample "Money received! USD 1,200" card tagged "Example",
USD and EUR chips, and stars. The card floats above the mascot's whole jump,
so it never covers the face. No timestamp, payer or dashed arc.
- Leaving Welcome eases the hero down to the shared 40% height over the 500 ms
panel slide, so the next step does not jump. Reduced motion: static scene,
instant transition.
- Copy in en, es-419, es-AR and pt-BR: "Get paid from the US and Europe." /
"Receive dollars and euros. Pay by card or QR." plus "No password. Sign in
with your face or fingerprint." The Log in link reads "Already have an
account? Log in".
- Log in visibility, the passkey checks, recovery, analytics and the web store
layout are unchanged.
…Welcome chips Konrad approved one new asset on 13 Nov 2026 in the first-screen run: the smiling USD and EUR coins from concept F1. They join the approved inventory (/dev/ds/marketing/assets, landing illustrations) as lossless WebP at the source size (330x350), and mark the USD and EUR source chips on the Welcome hero. The cheering pose entry now lists the Welcome hero as a use.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Code-analysis diffPainscore total: 11050.75 → 11062.08 (+11.33) 🆕 New findings (24)
…and 4 more. ✅ Resolved (17)
📈 Painscore deltas (top movers)
|
…up screens ds-lint caught an off-scale md:pt-24 and an inline style on the reduced-motion path; both now use scale steps and framer-motion. screen-wordiness counts every string a screen can import: /setup/finish and /verify import SetupWrapper, so LandingHero's five sample-card words land on them although neither ever shows the Welcome hero. Their baselines move by those 5 words.
Contributor
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
…s one image QA on #4088 found SetupWrapper carrying landing-only branches and the hero weaker than the A2 mockup. - A step can now pass `image: { hero }`; a hero carries the step's headline, so the wrapper makes it taller and starts the panel with the description. SetupWrapper no longer imports LandingHero, which puts the /setup/finish and /verify wordiness baselines back where dev had them. - The headline hero takes what the Welcome panel leaves (measured per height band) instead of a fixed 54dvh, which pushed the page into a scroll on phones with safe areas; large text grows it until the headline fits and the scene gives way. - Only entering or leaving a headline hero animates the height (500 ms, with the art crossfading over the same time); keyboard and address-bar resizes snap again, and the colour fade is back to dev's duration-fast. The outgoing panel fades in 200 ms so no button ends hang at the edge. - The mascot sits on its own box with the card and chips placed on it, so the composition holds from 320 px to desktop: bigger peanut, feet on the hero's edge, fists under the card at the top of each jump, never over the eyes. - StickerPop gets its own file and uses the DS motion tokens; the card and chips use 0_Bruddle/Card; the chips load 96 px coin variants. - On desktop the panel's body and actions sit together mid-column.
…p one box The A2 Welcome hero carries the headline and is taller, so the "one hero box on every frame" rule failed on Welcome -> username. The spec now requires one hero that never moves or changes width, a one-way height change that starts at Welcome's height and ends at the board's 40% (34% at 320x568), and the reverse on Back. Later steps still share one height, and Welcome is checked for its own height with a reachable, unscrolled Sign up.
… own style - Konrad ruled today that "no password" sounds like a problem, not a feature. The Welcome line now says what happens, from the round-2 spec: "Get in with your face or fingerprint." (es-AR, es-419 and pt-BR to match; never "Sign in"). - The prompt before the Log in link takes the link's type and colour instead of the call site overriding LinkButton, and the link's hit area reaches 44 px wide for short labels (en was 41 px, pt-BR 38 px). - es-AR keeps Konrad's "Ya tengo cuenta" with the separator moved into markup (aria-hidden), and the link says "Iniciar sesión" like the Log in button. es-419 matches the button the same way. - pt-BR description no longer repeats "Receba". - The Welcome panel's gap drops to gap-6 so the hero keeps more room.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Konrad picked first-screen concept A2 "Atrapá el pago" for the sign-up Welcome screen (13 Nov 2026), on the existing periwinkle setup hero, not pink. The old screen named no source, showed no money and did not match the store frames people see before they install.
Commit 1: the A2 Welcome screen
.setup-hero-height-landing: 54dvh, 52dvh on short phones, full height on desktop). It holds the headline, the shippedcheeringmascot, a sample "¡Dinero recibido! USD 1.200" card tagged "Ejemplo" / "Example", USD and EUR chips, and two stars and a sparkle (all approved art). Same--color-background-setup-herotoken, so the status bar and safe-area colours do not change.Commit 2: one new approved asset. Konrad approved the USD and EUR sticker coins (first-screen concept F1 art). They are added as lossless WebP (330×350) to
src/assets/illustrations/and to the approved list (/dev/ds/marketing/assets, landing illustrations). They mark the USD and EUR chips on the Welcome hero.Task
No Notion task is linked yet. Konrad: please name the task this belongs to, or ask me to create one.
Interactions with #4083 and #4085 (both on
main, not ondev)main: Log in is always the secondary button, and the iOS auto login is gone). This PR keepsdev's Log in logic. When main is back-merged intodev,Landing.tsxconflicts in thesecondaryslot. The resolution is fix(TASK-24847): show Log in as a button at once on the app landing, drop the iOS auto login #4085's always-button. The "Ya tengo cuenta ·" prompt then goes, or Konrad decides whether the button should carry it. The reassurance line and the hero do not conflict.main: sign-up reorder and thewelcome-headline-copyPostHog flag). The flag does not exist ondev. On back-merge:SetupWrapper.tsxconflicts where Release UI: signup passkey screen, Welcome A/B test, signup/KYC/card fixes #4083 swaps inWelcomeHeadlineTitleBlock. In this PR the Welcome headline sits on the hero (LandingHerogetstitlefrom the wrapper), and the panel shows only the body. The resolution that keeps both: feed the variant's title intoLandingHeroand the variant's description into the panel's title block.setup.steps.landing.title/descriptionkeys become the experiment'scontrolcopy. So control is no longer the copy the variants were written against. The variants also say "No transfer fees", "travels free" and "at no cost", which break the no-fee and no-free rule this screen follows. Recommendation: stop the experiment, or rewrite its arms, before launch.Risks
QA
prettier --checkon the changed files ✅,npm run typecheck✅,npm run lint✅ (0 errors, 65 warnings, none in changed files),npm run build✅.npm test: 1,359 of 1,360 suites pass.scripts/__tests__/capgo-release-guard.test.jsfails with exit 128 because the sandbox copy has no.gitand the test shells out to git. It is unrelated, and CI will run it.ds-lint(an off-scalemd:pt-24, then an inline style) andscreen-wordinessfailed. Commit 3 fixes ds-lint. It also moves the/setup/finishand/verifywordiness baselines by +5: both importSetupWrapper, so the sample card's five words ("Money received!", "USD 1,200", "Example") count on them, although neither screen ever shows the Welcome hero. Re-run on the sandbox: ds-lint 0 regressions, wordiness ✅, typecheck ✅, setup suites 364/364 ✅.next devwithNEXT_PUBLIC_CAPACITOR_BUILD=true(native layout, Log in link after the 5 s check) andnext startwith the keep-web link (Log in button, clean next step). No backend: the connectivity toast and the Next dev badge were hidden in the capture.Screenshots
pr-assets-<pr#>orphan branch from peanut-pr could not be created (git push, the Git Data API and the Contents API were all refused). The 48 captures are in mono at_temp/first-screen/pr-a2/shots/(each 1600 px or less):app-landing-{es-AR,en}-{390x844,320x568,android-412x915}.pngapp-transition-{120,260}ms-…pngapp-next-…pngkeepweb-landing-…pngkeepweb-next-…pngkeepweb-transition-…pngWhat a reviewer should check: card clear of the mascot's face across the jump, headline wraps at 320 px, the step change has no jump, and the Log in link is visible.
Native:⚠️ needs a device pass (iOS and Android shell, real safe areas and status bar). Chromium cannot test the Capacitor shell.
Docs after merge (not in this PR):
design/design.md§ assets says "the animated hero pose iswaving-chill", andengineering/ui/signup-hero-loops.mddescribes the landing as the waving mascot with clouds. Both go stale for the sign-up Welcome screen.