Repository navigation
fix(billing): correct plan field name, add enterprise badge, store cleanup #3733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
3d63e1a
fix(billing): correct plan field name, add enterprise badge, store cl…
PierreBrisorgueil 9880151
fix(billing): address review feedback — add tests and fix mock data
PierreBrisorgueil 9fbdfbc
fix(billing): mock plans API in E2E tests so pricing page renders wit…
PierreBrisorgueil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
src/modules/billing/tests/billing.planBadge.component.unit.tests.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| import { describe, it, expect } from 'vitest'; | ||
| import { mount } from '@vue/test-utils'; | ||
| import { createVuetify } from 'vuetify'; | ||
| import BillingPlanBadgeComponent from '../components/billing.planBadge.component.vue'; | ||
|
|
||
| const vuetify = createVuetify(); | ||
|
|
||
| /** | ||
| * Mount the plan badge component with Vuetify installed. | ||
| * @param {Object} props Component props. | ||
| * @returns {import('@vue/test-utils').VueWrapper} Mounted wrapper | ||
| */ | ||
| const mountComponent = (props) => | ||
| mount(BillingPlanBadgeComponent, { | ||
| props, | ||
| global: { plugins: [vuetify] }, | ||
| }); | ||
|
|
||
| describe('BillingPlanBadgeComponent', () => { | ||
| it('renders free plan with grey color', () => { | ||
| const wrapper = mountComponent({ plan: 'free' }); | ||
| expect(wrapper.text()).toContain('free'); | ||
| expect(wrapper.vm.color).toBe('grey'); | ||
| }); | ||
|
|
||
| it('renders starter plan with primary color', () => { | ||
| const wrapper = mountComponent({ plan: 'starter' }); | ||
| expect(wrapper.text()).toContain('starter'); | ||
| expect(wrapper.vm.color).toBe('primary'); | ||
| }); | ||
|
|
||
| it('renders pro plan with secondary color', () => { | ||
| const wrapper = mountComponent({ plan: 'pro' }); | ||
| expect(wrapper.text()).toContain('pro'); | ||
| expect(wrapper.vm.color).toBe('secondary'); | ||
| }); | ||
|
|
||
| it('renders enterprise plan with warning color', () => { | ||
| const wrapper = mountComponent({ plan: 'enterprise' }); | ||
| expect(wrapper.text()).toContain('enterprise'); | ||
| expect(wrapper.vm.color).toBe('warning'); | ||
| }); | ||
|
|
||
| it('falls back to grey for unknown plan', () => { | ||
| // Validator will warn, but computed still returns grey fallback | ||
| const wrapper = mountComponent({ plan: 'unknown' }); | ||
| expect(wrapper.vm.color).toBe('grey'); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.