fix(billing): correct plan field name, add enterprise badge, store cleanup

[PierreBrisorgueil]

Summary

• What changed: Fixed 4 billing module issues — plan field mismatch in views, missing enterprise badge support, missing loading state in openPortal, and console.log used instead of console.error in store catch blocks.
• Why: Views referenced subscription.planId while the composable and API return subscription.plan, causing plan detection to always fall back to free. PlanBadge rejected enterprise as invalid. openPortal did not set loading state. Error logging used console.log instead of console.error.
• Related issues: Closes fix(billing): use subscription.plan instead of subscription.planId in views #3729, closes fix(billing): add enterprise to PlanBadge validator #3730, closes fix(billing): set loading=true in openPortal store action #3731, closes fix(billing): use console.error instead of console.log for errors in store #3732

Scope

• Modules impacted: billing
• Cross-module impact: none
• Risk level: low

Validation

• npm run lint
• npm run test:unit
• npm run build
• Manual checks done (if applicable)

Guardrails check

• No secrets or credentials introduced (.env*, secrets/**, keys, tokens)
• No risky rename/move of core stack paths
• Changes remain merge-friendly for downstream projects
• Tests added or updated when behavior changed

Notes for reviewers

• Security considerations: None — console.error is a strict improvement over console.log for error reporting
• Mergeability considerations: Clean, minimal diff across 5 files
• Follow-up tasks (optional): None

Summary by CodeRabbit

• New Features

  • Enterprise billing plan added with a dedicated visual indicator.

• Bug Fixes

  • Improved error logging and handling across billing flows.
  • Loading state now reflected during portal operations.
  • Validation added for portal URLs and error propagation standardized.
  • Plan detection updated to use the current subscription field for accurate display.

• Tests

  • New unit and E2E tests plus API mocks to ensure deterministic billing UI behavior.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.19%. Comparing base (78db8b1) to head (9fbdfbc).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3733   +/-   ##
=======================================
  Coverage   99.19%   99.19%           
=======================================
  Files          26       26           
  Lines         866      867    +1     
  Branches      225      225           
=======================================
+ Hits          859      860    +1     
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 7c2cec22-0f70-4164-b8e2-ef0f1a15e71f

📥 Commits

Reviewing files that changed from the base of the PR and between 3d63e1a and 9fbdfbc.

📒 Files selected for processing (3)

• src/modules/billing/tests/billing.e2e.tests.js
• src/modules/billing/tests/billing.planBadge.component.unit.tests.js
• src/modules/billing/tests/billing.store.unit.tests.js

---

Walkthrough

Fixes billing module field usage (use subscription.plan instead of planId), adds enterprise to the plan badge validator with a color mapping, standardizes error logging to console.error, sets this.loading = true at the start of openPortal, and updates/adds unit and e2e tests to match these changes.

Changes

Cohort / File(s)	Summary
Plan Badge & Views src/modules/billing/components/billing.planBadge.component.vue, src/modules/billing/views/billing.billing.view.vue, src/modules/billing/views/billing.pricing.view.vue	Added 'enterprise' to allowed plans and mapped it to warning; changed computed properties to read subscription?.plan instead of subscription?.planId.
Store: actions & logging src/modules/billing/stores/billing.store.js	Replaced console.log with console.error in catch blocks; set this.loading = true at start of openPortal; improved portal URL validation and error propagation.
Unit & E2E tests src/modules/billing/tests/billing.store.unit.tests.js, src/modules/billing/tests/billing.planBadge.component.unit.tests.js, src/modules/billing/tests/billing.e2e.tests.js	Updated tests to spy on console.error and adjusted mocks/data shape (subscription.plan); added unit tests for BillingPlanBadge color mappings; injected mock plans into e2e tests for deterministic pricing scenarios.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• feat(billing): add billing page with plan badge #3725: Updates the billing plan badge component — validator and color mappings for enterprise.
• feat(billing): checkout flow with auth/org guards #3727: Modifies openPortal behavior (loading state / finally handling) overlapping store action changes.
• feat(billing): scaffold billing module with store, router, and views #3723: Introduced the billing store/actions and views that these fixes correct and extend.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the three main changes: correcting the plan field name, adding enterprise badge support, and store cleanup (console.error).
Description check	✅ Passed	The description is comprehensive, covering all required sections with clear explanations of what changed, why, scope, validation status, and guardrails checks.
Linked Issues check	✅ Passed	All four linked issues are fully addressed: subscription.plan field corrected in views [#3729], enterprise added to PlanBadge validator and color mapping [#3730], loading state set in openPortal [#3731], console.error replaces console.log in catch blocks [#3732].
Out of Scope Changes check	✅ Passed	All changes remain tightly scoped to the billing module and directly address the four linked issues; no extraneous modifications detected.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/billing-plan-field-and-cleanup

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Fixes billing module plan detection and UX issues by aligning the UI with the subscription shape returned by the billing API/store, adding enterprise plan badge support, and improving store loading/error reporting behavior.

Changes:

• Update billing/pricing views to use subscription.plan (instead of subscription.planId) for current plan detection.
• Extend BillingPlanBadgeComponent to accept/render the enterprise plan.
• Improve billing store behavior: set loading state in openPortal() and log errors via console.error; update unit tests accordingly.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/modules/billing/views/billing.pricing.view.vue	Fixes current plan detection to read subscription.plan.
src/modules/billing/views/billing.billing.view.vue	Fixes current plan detection to read subscription.plan.
src/modules/billing/stores/billing.store.js	Adds openPortal() loading state and switches error logging to console.error.
src/modules/billing/components/billing.planBadge.component.vue	Adds enterprise to plan validation and color mapping.
src/modules/billing/tests/billing.store.unit.tests.js	Updates tests to spy on console.error to match store changes.

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/modules/billing/tests/billing.store.unit.tests.js (1)

62-68: 🧹 Nitpick | 🔵 Trivial

Deduplicate repeated console.error spy setup/teardown.

The same spy boilerplate is repeated across six tests. Consider moving it to a shared setup/cleanup helper to reduce drift and missed restores.

Also applies to: 91-97, 126-132, 151-157, 161-167, 171-177

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/modules/billing/tests/billing.store.unit.tests.js` around lines 62 - 68,
Extract the repeated console.error spy setup/teardown into a shared test helper:
create a single vi.spyOn(console, 'error').mockImplementation(() => {}) in a
beforeEach (or a helper like createConsoleErrorSpy) and restore it in afterEach
(or via returned mockRestore), then remove the duplicate spy/mockRestore lines
from the individual tests that call store.fetchPlans() and other test cases;
reference the existing spy pattern (vi.spyOn(console, 'error'),
mockImplementation, mockRestore) and ensure tests still assert spy was called
where needed (expect(spy).toHaveBeenCalled()) using the shared spy variable
accessible to the tests.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/modules/billing/components/billing.planBadge.component.vue`:
- Line 18: Add component unit tests for the BillingPlanBadge component to cover
the new "enterprise" branch: write tests that mount the
billing.planBadge.component.vue, assert that isAllowedPlan accepts 'enterprise'
(or that the component renders when passed plan="enterprise"), and verify the
rendered badge uses the expected color mapping (the same mapping updated at the
color logic referenced around the color mapping function/variable used in the
component). Use the existing test harness style in this repo
(mount/shallowMount, props injection, and CSS/class/text assertions) and add one
test for acceptance and one for correct color rendering for 'enterprise'.

---

Outside diff comments:
In `@src/modules/billing/tests/billing.store.unit.tests.js`:
- Around line 62-68: Extract the repeated console.error spy setup/teardown into
a shared test helper: create a single vi.spyOn(console,
'error').mockImplementation(() => {}) in a beforeEach (or a helper like
createConsoleErrorSpy) and restore it in afterEach (or via returned
mockRestore), then remove the duplicate spy/mockRestore lines from the
individual tests that call store.fetchPlans() and other test cases; reference
the existing spy pattern (vi.spyOn(console, 'error'), mockImplementation,
mockRestore) and ensure tests still assert spy was called where needed
(expect(spy).toHaveBeenCalled()) using the shared spy variable accessible to the
tests.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: a9457d34-eab5-425c-b1d6-f477c35c2127

📥 Commits

Reviewing files that changed from the base of the PR and between 78db8b1 and 3d63e1a.

📒 Files selected for processing (5)

• src/modules/billing/components/billing.planBadge.component.vue
• src/modules/billing/stores/billing.store.js
• src/modules/billing/tests/billing.store.unit.tests.js
• src/modules/billing/views/billing.billing.view.vue
• src/modules/billing/views/billing.pricing.view.vue