Relink some missing docs and remove unnecessary docs by sunetic · Pull Request #8724 · pingcap/docs-cn

sunetic · 2022-03-22T07:21:58Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

ti-chi-bot · 2022-03-22T07:22:00Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

TomShawn

LGTM

needs reconsider

TomShawn · 2022-03-22T09:58:55Z

        - [通过 SQL 表达式过滤 DML](/dm/feature-expression-filter.md)
        - 迁移任务操作
            - [任务前置检查](/dm/dm-precheck.md)
+            - [配置文件](/dm/task-configuration-file.md)


这一部分是【入门指南】下的【迁移任务操作】，对应一系列任务，是 Task 导向的。这一篇参考类型的【配置文件】放在这里感觉有些奇怪。

task 的配置文件，所有 task 操作的前提就是配置文件

Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>

TomShawn · 2022-03-23T11:33:06Z

@shichun-0415 删除了这些文件是否需要加 aliases 呢？

shichun-0415 · 2022-03-23T15:04:10Z

@shichun-0415 删除了这些文件是否需要加 aliases 呢？

多谢 Tom 提醒，删除的五篇文档中：

quick-create-migration-task.md、scenarios.md 和 task-configuration-file.md 不存在被引用，是否可以直接删除，不加 aliases？
dm-benchmark-v5.3.0.md：docs 仓库两篇文档引用了它。但是，dm 的文档是 5.4 才迁移到 docs 仓库，这篇文档严格说只应存在于 dm 仓库，所以这里是不是可以删除 docs 仓库的这篇文档，然后加外链引用 dm 仓库的这篇文档呢？
shard-merge-best-practices.md：这一篇重新看了，感觉不能直接删，因为有三个文档都引用了它，且没有新的文档供重定向。@SunZhaoyang

sunetic · 2022-04-18T08:43:48Z

@shichun-0415 删除了这些文件是否需要加 aliases 呢？

多谢 Tom 提醒，删除的五篇文档中：

quick-create-migration-task.md、scenarios.md 和 task-configuration-file.md 不存在被引用，是否可以直接删除，不加 aliases？

dm-benchmark-v5.3.0.md：docs 仓库两篇文档引用了它。但是，dm 的文档是 5.4 才迁移到 docs 仓库，这篇文档严格说只应存在于 dm 仓库，所以这里是不是可以删除 docs 仓库的这篇文档，然后加外链引用 dm 仓库的这篇文档呢？

shard-merge-best-practices.md：这一篇重新看了，感觉不能直接删，因为有三个文档都引用了它，且没有新的文档供重定向。@SunZhaoyang

task-configuration-file.md 和 task-configuration-file-full.md 重复了，所以留 full 的这篇就行；quick-create-migration-task.md 有新的 quick-start-with-dm.md 也不需要了；scenarios.md 目录重构后也不需要了；
可以的。
可以放到使用示例里先

TomShawn · 2022-04-18T09:04:13Z

@shichun-0415 删除了这些文件是否需要加 aliases 呢？

多谢 Tom 提醒，删除的五篇文档中：

quick-create-migration-task.md、scenarios.md 和 task-configuration-file.md 不存在被引用，是否可以直接删除，不加 aliases？

dm-benchmark-v5.3.0.md：docs 仓库两篇文档引用了它。但是，dm 的文档是 5.4 才迁移到 docs 仓库，这篇文档严格说只应存在于 dm 仓库，所以这里是不是可以删除 docs 仓库的这篇文档，然后加外链引用 dm 仓库的这篇文档呢？

shard-merge-best-practices.md：这一篇重新看了，感觉不能直接删，因为有三个文档都引用了它，且没有新的文档供重定向。@SunZhaoyang

这些文档都出现在了文档站，直接删除的话，再访问这些页面就是 404，不推荐直接删。
「docs」仓库是英文仓库，为什么英文仓库会引用中文文档呢？

TomShawn · 2022-04-18T09:08:04Z

@SunZhaoyang 也请根据 ci / pull (pull_request) 报错提示修复死链，谢谢！

shichun-0415 · 2022-04-18T09:14:57Z

@TomShawn 「docs」仓库是英文仓库，为什么英文仓库会引用中文文档呢？----我的问题，想说的是 docs-cn 两篇文档引用了 dm-benchmark-v5.3.0.md。

shichun-0415 · 2022-04-19T03:11:54Z

/merge

ti-chi-bot · 2022-04-19T03:11:57Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 0225cb6

ti-chi-bot · 2022-04-19T03:12:41Z

In response to a cherrypick label: new pull request created: #9061.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2022-04-19T03:13:19Z

In response to a cherrypick label: new pull request created: #9062.

Update TOC.md

6889242

ti-chi-bot requested a review from TomShawn March 22, 2022 07:22

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 22, 2022

shichun-0415 added translation/doing This PR’s assignee is translating this PR. type/bugfix This PR fixes a bug. area/dm and removed missing-translation-status This PR does not have translation status info. labels Mar 22, 2022

TomShawn reviewed Mar 22, 2022

View reviewed changes

Comment thread TOC.md Resolved

TomShawn reviewed Mar 22, 2022

View reviewed changes

Comment thread TOC.md Resolved

Apply suggestions from code review

041e856

TomShawn previously approved these changes Mar 22, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 22, 2022

TomShawn self-assigned this Mar 22, 2022

TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label Mar 22, 2022

TomShawn reviewed Mar 22, 2022

View reviewed changes

Comment thread TOC.md Resolved

TomShawn requested review from GMHDBJD, lance6716 and qiancai March 22, 2022 10:00

TomShawn assigned sunetic and unassigned TomShawn Mar 22, 2022

shichun-0415 reviewed Mar 23, 2022

View reviewed changes

Comment thread TOC.md Resolved

Apply suggestions from code review

ec1a8bd

Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>

sunetic commented Mar 23, 2022

View reviewed changes

Comment thread TOC.md Resolved

sunetic added 3 commits March 23, 2022 11:34

Update TOC.md

6afd698

Update TOC.md

73fb29e

Update TOC.md

bef1002

shichun-0415 added the needs-cherry-pick-release-5.4 label Mar 23, 2022

Address comments

0225cb6

shichun-0415 approved these changes Apr 18, 2022

View reviewed changes

TomShawn added the needs-cherry-pick-release-6.0 label Apr 19, 2022

TomShawn approved these changes Apr 19, 2022

View reviewed changes

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 19, 2022

ti-chi-bot merged commit e754835 into pingcap:master Apr 19, 2022

ti-chi-bot mentioned this pull request Apr 19, 2022

Relink some missed docs (#8724) #9061

Merged

4 of 16 tasks

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Apr 19, 2022

This is an automated cherry-pick of pingcap#8724

e1c17c6

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Apr 19, 2022

This is an automated cherry-pick of pingcap#8724

e098ab6

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Apr 19, 2022

Relink some missed docs (#8724) #9062

Merged

4 of 16 tasks

ti-chi-bot added a commit that referenced this pull request Apr 19, 2022

Relink some missed docs (#8724) (#9062)

5ba682e

ti-chi-bot added a commit that referenced this pull request Apr 19, 2022

Relink some missed docs (#8724) (#9061)

c374d76

shichun-0415 changed the title ~~Relink some missed docs~~ Relink some missing docs and remove unnecessary docs Apr 19, 2022

shichun-0415 mentioned this pull request Apr 19, 2022

Relink some missing docs and remove unnecessary docs pingcap/docs#8271

Merged

5 of 17 tasks

shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 19, 2022

This was referenced Apr 20, 2022

Relink some missing docs and remove unnecessary docs (#8271) pingcap/docs#8279

Merged

Relink some missing docs and remove unnecessary docs (#8271) pingcap/docs#8280

Merged

Oreoxmt mentioned this pull request May 24, 2022

Deleted md file is still in Algolia search results pingcap/website-docs#224

Open

Conversation

sunetic commented Mar 22, 2022 • edited by shichun-0415 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

ti-chi-bot commented Mar 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TomShawn left a comment

Choose a reason for hiding this comment

Uh oh!

TomShawn Mar 22, 2022

Choose a reason for hiding this comment

Uh oh!

sunetic Mar 23, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TomShawn commented Mar 23, 2022

Uh oh!

shichun-0415 commented Mar 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sunetic commented Apr 18, 2022

Uh oh!

TomShawn commented Apr 18, 2022

Uh oh!

TomShawn commented Apr 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shichun-0415 commented Apr 18, 2022

Uh oh!

shichun-0415 commented Apr 19, 2022

Uh oh!

ti-chi-bot commented Apr 19, 2022

Uh oh!

ti-chi-bot commented Apr 19, 2022

Uh oh!

ti-chi-bot commented Apr 19, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sunetic commented Mar 22, 2022 •

edited by shichun-0415

Loading

ti-chi-bot commented Mar 22, 2022 •

edited

Loading

shichun-0415 commented Mar 23, 2022 •

edited

Loading

TomShawn commented Apr 18, 2022 •

edited

Loading