metrics: bump CSE meta cache metrics and fix prefetch cache hit ratio panel - #11040
Conversation
The new submodule version adds workspace-hack (path) dependency in kvengine, which makes the [patch] of workspace-hack ineffective (patch cannot override path dependencies), so Cargo.lock must be regenerated to point workspace-hack to cloud-storage-engine/workspace-hack. Verified libtiflash_proxy.so builds successfully and contains no jemalloc symbols.
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
The metric observes hit_ratio*100 with percent buckets, not latency seconds.
📝 WalkthroughWalkthroughThe PR updates the cloud-storage-engine submodule and related build guidance. It narrows contribution ignore rules. It also changes the prefetch cache Grafana panel from duration to percentage-based hit ratio display. ChangesCloud-storage-engine integration
Prefetch cache dashboard
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: 🟡 Moderate · up to The PR updates the cloud-storage-engine dependency and Grafana panel, but the dependency override and lockfile recovery path remain inconsistent; a future allocator reference could introduce conflicting malloc/free symbols and crash TiFlash, so merge should wait for this build/runtime risk to be corrected. Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@contrib/tiflash-columnar-hub/AGENTS.md`:
- Line 124: Update the error code fence in AGENTS.md around the documented
section to include a language identifier after the opening fence, using text or
console, so the markdownlint MD040 violation is resolved.
- Around line 132-137: Update the lockfile recovery guidance to use the existing
explicit list of nine cloud-storage-engine packages, followed by cargo check
--locked, instead of relying only on workspace-hack. Clarify that these packages
resolve from local paths, so git-source revision searches are invalid; document
workspace-hack under [[patch.unused]] and that hub-runtime does not use the
local replacement. Correct the jemalloc documentation and add the text language
tag to the error code fence.
Apply the same fix in `@contrib/tiflash-columnar-hub/AGENTS.md` at line 162.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: eea3c6f5-8f15-4b63-a5ac-32cae32be52c
⛔ Files ignored due to path filters (1)
contrib/tiflash-columnar-hub/Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (6)
.cursorignorecontrib/cloud-storage-enginecontrib/tiflash-columnar-hub/AGENTS.mdmetrics/grafana/tiflash_summary.dashboard.pymetrics/grafana/tiflash_summary.jsonmetrics/grafana/tiflash_summary.json.sha256
|
/test pull-integration-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin, yongman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-nextgen-202603 |
|
@JaySon-Huang: new pull request created to branch DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #11039
Problem Summary:
Bump
cloud-storage-engineso TiFlash picks up the new columnar meta cache metrics, and fix TiFlash Summary which incorrectly plotstiflash_proxy_kv_engine_columnar_prefetch_cache_hitas a duration (seconds). That metric observeshit_ratio * 100with percent buckets, so the panel should use a percent Y-axis and a ratio title.What is changed and how it works?
contrib/cloud-storage-enginesubmodule (includes columnar meta cache metrics) and regenerate relatedCargo.lock/ proxy AGENTS notes for workspace-hack resolution.unit="percent", then regenerate dashboard JSON/checksum.Check List
Tests
Manual test:
cd metrics/grafana && ./generate_dashboard.shColumnar Prefetch Cache Hit Ratioand left Y-axis format ispercent.http://10.2.12.81:21530/d/jmd6Payvz/jsonnet-tiflash-summary.libtiflash_proxy.sobuild / no jemalloc symbols).Side effects
Documentation
Release note
Summary by CodeRabbit
Monitoring
Documentation
Maintenance