metrics: bump CSE meta cache metrics and fix prefetch cache hit ratio panel (#11040) - #11045
Conversation
The new submodule version adds workspace-hack (path) dependency in kvengine, which makes the [patch] of workspace-hack ineffective (patch cannot override path dependencies), so Cargo.lock must be regenerated to point workspace-hack to cloud-storage-engine/workspace-hack. Verified libtiflash_proxy.so builds successfully and contains no jemalloc symbols.
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
The metric observes hit_ratio*100 with percent buckets, not latency seconds.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (3)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, yongman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
a64db04
into
pingcap:release-nextgen-202603
This is an automated cherry-pick of #11040
What problem does this PR solve?
Issue Number: close #11039
Problem Summary:
Bump
cloud-storage-engineso TiFlash picks up the new columnar meta cache metrics, and fix TiFlash Summary which incorrectly plotstiflash_proxy_kv_engine_columnar_prefetch_cache_hitas a duration (seconds). That metric observeshit_ratio * 100with percent buckets, so the panel should use a percent Y-axis and a ratio title.What is changed and how it works?
contrib/cloud-storage-enginesubmodule (includes columnar meta cache metrics) and regenerate relatedCargo.lock/ proxy AGENTS notes for workspace-hack resolution.unit="percent", then regenerate dashboard JSON/checksum.Check List
Tests
Manual test:
cd metrics/grafana && ./generate_dashboard.shColumnar Prefetch Cache Hit Ratioand left Y-axis format ispercent.http://10.2.12.81:21530/d/jmd6Payvz/jsonnet-tiflash-summary.libtiflash_proxy.sobuild / no jemalloc symbols).Side effects
Documentation
Release note
Summary by CodeRabbit
Monitoring
Documentation
Maintenance