Skip to content

feat: add email subscription component - #474

Merged
Yuiham merged 12 commits into
pingcap:masterfrom
likidu:email-subscription
May 22, 2024
Merged

Yuiham merged 12 commits into
pingcap:masterfrom
likidu:email-subscription

Conversation

@likidu

@likidu likidu commented Mar 15, 2024

Copy link
Copy Markdown
Contributor

@lilin90 @Yuiham

Email subscription form component for #453

In markdown file, add <EmailSubscriptionForm /> to where we want to enable the email subscription such as the release-notes.md

@likidu
likidu requested a review from Yuiham March 15, 2024 04:30
@vercel

vercel Bot commented Mar 15, 2024

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the pingcap Team on Vercel.

A member of the Team first needs to authorize it.

@vercel

vercel Bot commented Mar 15, 2024 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website-docs ❌ Failed (Inspect) May 22, 2024 8:04am

@Yuiham Yuiham left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@likidu PTAL these comments. Thx!

@shhdgit shhdgit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest LGTM.

likidu and others added 7 commits May 21, 2024 22:54
Co-authored-by: Suhaha <jklopsdfw@gmail.com>
Co-authored-by: Suhaha <jklopsdfw@gmail.com>
Co-authored-by: Yuiham <Yuiham@users.noreply.github.com>
Co-authored-by: Yuiham <Yuiham@users.noreply.github.com>
Co-authored-by: Yuiham <Yuiham@users.noreply.github.com>
Co-authored-by: Yuiham <Yuiham@users.noreply.github.com>
Comment thread src/components/MDXComponents/index.tsx Resolved

@Yuiham Yuiham left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@likidu PTAL again, thx!

@Yuiham Yuiham changed the title Add email subscription form component feat: add email subscription component May 22, 2024
@Yuiham
Yuiham merged commit 62390f0 into pingcap:master May 22, 2024

This branch was successfully deployed

1 active deployment
Preview – website-docs — 2365fe54 Deployed May 22, 2024 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants