Skip to content

fix(web): highlight tool inputs and remove nested work log indentation - #15384

Merged
Yash-Singh1 merged 1 commit into
mainfrom
t3code/tool-call-hover-indent
Oct 3, 2026
Merged

Yash-Singh1 merged 1 commit into
mainfrom
t3code/tool-call-hover-indent

Conversation

@Yash-Singh1

@Yash-Singh1 Yash-Singh1 commented Oct 3, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

Tool inputs in the item inspector lacked JSON syntax highlighting. Work log detail rows also inherited hover styling and indentation that made nested details appear misaligned.

Change

Add theme-aware JSON highlighting for valid JSON tool inputs, with plain text as the fallback. Remove hover background styling from interactive work log rows and apply indentation only to text details. Remove the extra mobile work log detail indentation.

Scope and approval

This focused fix corrects tool input readability and work log detail layout. It does not add a new capability or change user workflows.

Verification

Not provided.

Screenshots

Before After
Tool call before Tool call after

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Oct 3, 2026
@juliusmarminge juliusmarminge added macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews and removed size:M 30-99 changed lines (additions + deletions). labels Oct 3, 2026 — with Cursor
@macroscopeapp

macroscopeapp Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 675be11

Macroscope's review found this PR approvable — This is a narrowly scoped UI fix: it adjusts work-log spacing/hover presentation and adds theme-aware JSON coloring to existing tool-input displays with plain-text fallbacks. It introduces no new workflow, schema, configuration, or production infrastructure behavior.

You can add or adjust custom eligibility rules. Learn more.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 4.9 KiB 4.9 KiB 0 B (0.0%) 6.8 KiB ✅
Codex Thread snapshot wire 3.7 KiB 3.7 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.1 KiB 1.1 KiB 0 B (0.0%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 20.4 KiB 20.4 KiB 0 B (0.0%) 29.3 KiB ✅
Codex Live turn messages 1 1 0 (0.0%) 8 ✅
Claude Total thread wire 4.9 KiB 4.9 KiB 0 B (0.0%) 6.8 KiB ✅
Claude Thread snapshot wire 3.7 KiB 3.7 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 20.8 KiB 20.8 KiB 0 B (0.0%) 29.3 KiB ✅
Claude Live turn messages 2 2 0 (0.0%) 8 ✅

Baseline: 00eb8f6 · PR result: 675be11 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 106.1 KiB
  • Claude decoded thread snapshot: 106.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Team
  • Run ID: 08b7b8cf-bd0a-43b8-b4b9-25cb41f18792
📥 Commits

Reviewing files that changed from the base of the PR and between 00eb8f6 and 675be11.

📒 Files selected for processing (3)
  • apps/mobile/src/features/threads/thread-work-log.tsx
  • apps/web/src/components/chat/V2ItemInspector.tsx
  • apps/web/src/components/chat/WorkLog.tsx

Included review availability: This review used your included allowance. 9 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.


📝 Walkthrough

Walkthrough

The changes add optional JSON syntax highlighting to command-execution and dynamic-tool inputs. They also adjust expanded work-log detail spacing and web work-log row and cursor styling.

Changes

JSON input highlighting

Layer / File(s) Summary
JSON highlighting in chat inputs
apps/web/src/components/chat/V2ItemInspector.tsx
StructuredValue can render valid JSON with syntax highlighting and fall back to plain text. Command-execution and dynamic-tool inputs enable highlighting.

Work-log styling

Layer / File(s) Summary
Work-log row and detail styling
apps/mobile/src/features/threads/thread-work-log.tsx, apps/web/src/components/chat/WorkLog.tsx
Mobile expanded non-reasoning details no longer have a left inset or border. Web work-log rows no longer have a hover background, and all detail kinds use the common cursor class.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 675be

The highlighting and work-log styling changes have no confirmed merge-blocking issue.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main changes: JSON highlighting for tool inputs and reduced work log indentation.
Description check ✅ Passed The description covers the problem, changes, and scope, and includes before-and-after screenshots. It does not report focused tests or manual checks, or state what could not be checked.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@Yash-Singh1
Yash-Singh1 merged commit f786ff3 into main Oct 3, 2026
39 checks passed
@Yash-Singh1
Yash-Singh1 deleted the t3code/tool-call-hover-indent branch October 3, 2026 23:46
@Yash-Singh1
Yash-Singh1 restored the t3code/tool-call-hover-indent branch October 3, 2026 23:46
github-actions Bot added a commit to davidvanderklay/t3code-flake that referenced this pull request Oct 4, 2026
## What's Changed
* feat(web): Nightly tells you to get the beta mobile app by @t3dotgg in pingdotgg/t3code#15070
* test(server): ACP adapter tests no longer race the prompt settle by @t3dotgg in pingdotgg/t3code#15330
* feat(usage): fold preview model IDs into the model they belong to by @t3dotgg in pingdotgg/t3code#15333
* refactor(server): check RPC scopes in group middleware by @juliusmarminge in pingdotgg/t3code#15324
* feat(mobile): beta Working section hides busy threads until they need you by @t3dotgg in pingdotgg/t3code#15346
* fix(settings): symlinked settings files stay linked when saved by @yordis in pingdotgg/t3code#15009
* fix(server): Stop ends a dev server left running before a provider switch by @t3dotgg in pingdotgg/t3code#15355
* fix(server): merged threads settle even after the agent wakes on its own by @t3dotgg in pingdotgg/t3code#15388
* fix(web): no-project drafts can switch machines by @maria-rcks in pingdotgg/t3code#15356
* fix(web): highlight tool inputs and remove nested work log indentation by @Yash-Singh1 in pingdotgg/t3code#15384
* fix(server): restarts keep delegated tasks, queued threads, and stops intact by @maria-rcks in pingdotgg/t3code#15323
* fix(web): sending past the resume banner compacts first by @maria-rcks in pingdotgg/t3code#15290
* fix(codex): resume archived native sessions by @maria-rcks in pingdotgg/t3code#15389
* feat(web): morph composer and panel action icons by @jakeleventhal in pingdotgg/t3code#14924
* fix(web): subagents sent a follow-up show as running in Lineage by @scratchyone in pingdotgg/t3code#15334
* fix(web): clear stale chat action shortcuts by @maria-rcks in pingdotgg/t3code#15394
* fix(orchestration-v2): restore earlier app agent transcript pages by @Bil0000 in pingdotgg/t3code#14104
* fix(web): remove the square thread info panel shadow by @PixPMusic in pingdotgg/t3code#15069
* fix(mobile): Android usage widget no longer sticks on "Loading widget" in release builds by @tris203 in pingdotgg/t3code#15142
* fix(web): size the model picker to its content by @saphid in pingdotgg/t3code#15152
* test(server): replay checks a Claude subagent's thread takes its reported model by @juliusmarminge in pingdotgg/t3code#15022
* fix(web): subagent finish notifications look like subagent cards by @flamboh in pingdotgg/t3code#15281
* fix(web): thread status dot has an accessible name by @ryanilano in pingdotgg/t3code#14587
* fix(web): legacy sidebar options button has a label by @ryanilano in pingdotgg/t3code#14602
* fix(web): imported themes keep switches and focus rings visible by @flamboh in pingdotgg/t3code#14498
* fix(web): links to issues no longer strand the pull request viewer by @flamboh in pingdotgg/t3code#14242
* fix(web): repo/task breadcrumb no longer bounces when the sidebar collapses by @flamboh in pingdotgg/t3code#15046
* fix(web): Pull request panel entry works for linked PRs by @flamboh in pingdotgg/t3code#15061
* fix(web): add context menu to draft threads in the sidebar by @flamboh in pingdotgg/t3code#10637
* fix(web): keep sidebar branding and build pills from clipping at varying font sizes and zoom levels by @flamboh in pingdotgg/t3code#12141
* fix(usage): model shares and order follow the selected metric by @flamboh in pingdotgg/t3code#11391
* feat(web): sweep sidebar buttons to settle, un-settle, and wake threads by @argofowl in pingdotgg/t3code#14768
* feat: retry a failed workspace preparation by @juliusmarminge in pingdotgg/t3code#15326

## New Contributors
* @argofowl made their first contribution in pingdotgg/t3code#14768

**Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261003.2638...v0.0.46-nightly.20261004.2644

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261004.2644
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Oct 4, 2026
## What's Changed
* feat(web): Nightly tells you to get the beta mobile app by @t3dotgg in pingdotgg/t3code#15070
* test(server): ACP adapter tests no longer race the prompt settle by @t3dotgg in pingdotgg/t3code#15330
* feat(usage): fold preview model IDs into the model they belong to by @t3dotgg in pingdotgg/t3code#15333
* refactor(server): check RPC scopes in group middleware by @juliusmarminge in pingdotgg/t3code#15324
* feat(mobile): beta Working section hides busy threads until they need you by @t3dotgg in pingdotgg/t3code#15346
* fix(settings): symlinked settings files stay linked when saved by @yordis in pingdotgg/t3code#15009
* fix(server): Stop ends a dev server left running before a provider switch by @t3dotgg in pingdotgg/t3code#15355
* fix(server): merged threads settle even after the agent wakes on its own by @t3dotgg in pingdotgg/t3code#15388
* fix(web): no-project drafts can switch machines by @maria-rcks in pingdotgg/t3code#15356
* fix(web): highlight tool inputs and remove nested work log indentation by @Yash-Singh1 in pingdotgg/t3code#15384
* fix(server): restarts keep delegated tasks, queued threads, and stops intact by @maria-rcks in pingdotgg/t3code#15323
* fix(web): sending past the resume banner compacts first by @maria-rcks in pingdotgg/t3code#15290
* fix(codex): resume archived native sessions by @maria-rcks in pingdotgg/t3code#15389
* feat(web): morph composer and panel action icons by @jakeleventhal in pingdotgg/t3code#14924
* fix(web): subagents sent a follow-up show as running in Lineage by @scratchyone in pingdotgg/t3code#15334
* fix(web): clear stale chat action shortcuts by @maria-rcks in pingdotgg/t3code#15394
* fix(orchestration-v2): restore earlier app agent transcript pages by @Bil0000 in pingdotgg/t3code#14104
* fix(web): remove the square thread info panel shadow by @PixPMusic in pingdotgg/t3code#15069
* fix(mobile): Android usage widget no longer sticks on "Loading widget" in release builds by @tris203 in pingdotgg/t3code#15142
* fix(web): size the model picker to its content by @saphid in pingdotgg/t3code#15152
* test(server): replay checks a Claude subagent's thread takes its reported model by @juliusmarminge in pingdotgg/t3code#15022
* fix(web): subagent finish notifications look like subagent cards by @flamboh in pingdotgg/t3code#15281
* fix(web): thread status dot has an accessible name by @ryanilano in pingdotgg/t3code#14587
* fix(web): legacy sidebar options button has a label by @ryanilano in pingdotgg/t3code#14602
* fix(web): imported themes keep switches and focus rings visible by @flamboh in pingdotgg/t3code#14498
* fix(web): links to issues no longer strand the pull request viewer by @flamboh in pingdotgg/t3code#14242
* fix(web): repo/task breadcrumb no longer bounces when the sidebar collapses by @flamboh in pingdotgg/t3code#15046
* fix(web): Pull request panel entry works for linked PRs by @flamboh in pingdotgg/t3code#15061
* fix(web): add context menu to draft threads in the sidebar by @flamboh in pingdotgg/t3code#10637
* fix(web): keep sidebar branding and build pills from clipping at varying font sizes and zoom levels by @flamboh in pingdotgg/t3code#12141
* fix(usage): model shares and order follow the selected metric by @flamboh in pingdotgg/t3code#11391
* feat(web): sweep sidebar buttons to settle, un-settle, and wake threads by @argofowl in pingdotgg/t3code#14768
* feat: retry a failed workspace preparation by @juliusmarminge in pingdotgg/t3code#15326

## New Contributors
* @argofowl made their first contribution in pingdotgg/t3code#14768

**Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261003.2638...v0.0.46-nightly.20261004.2644

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261004.2644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants