Skip to content

fix(dev): write bootstrap warnings directly to stderr - #15865

Merged
maria-rcks merged 2 commits into
pingdotgg:mainfrom
maria-rcks:t3code/fix-main-typecheck
Oct 5, 2026
Merged

maria-rcks merged 2 commits into
pingdotgg:mainfrom
maria-rcks:t3code/fix-main-typecheck

Conversation

@maria-rcks

@maria-rcks maria-rcks commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

main's typecheck fails with TS377064 because the standalone worktree setup script uses console.warn. write the same warning directly to node's stderr stream, preserving its text and newline without a diagnostic suppression or a dependency on effect. the env-file safeguards remain unchanged.

verified on blacksmith: scripts typecheck, targeted lint and formatting, and all 74 existing dev-runner tests passed. a direct node runtime comparison confirmed matching warning output and exit status.

model: gpt-6.1-sol. harness: codex in t3 code.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 5, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 9ca829f

Macroscope's review found this PR approvable — This narrowly scoped development fix preserves the existing warning text and control flow while writing directly to stderr during worktree setup. It does not affect product defaults or production request behavior, and it removes rather than adds a static-analysis suppression.

You can add or adjust custom eligibility rules. Learn more.

@maria-rcks maria-rcks changed the title fix(dev): allow bootstrap warning in worktree setup fix(dev): write bootstrap warnings directly to stderr Oct 5, 2026
@maria-rcks

Copy link
Copy Markdown
Collaborator Author

Note

Written by gpt-6.1-sol on behalf of Maria

addressed in 9ca829f: removed the diagnostic suppression and replaced console.warn with process.stderr.write. the warning text and newline match, and the script still uses only node built-ins before dependencies are installed. scripts typecheck, targeted lint/formatting, and 74 existing dev-runner tests pass on blacksmith.

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 687a592a-5a52-4358-bc61-fa44342d2513
📥 Commits

Reviewing files that changed from the base of the PR and between 1e2ecbd and 9ca829f.

📒 Files selected for processing (1)
  • scripts/setup-worktree.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

When the environment-file source is not a regular file, setup-worktree.ts writes the skip message to stderr instead of calling console.warn. The setup flow otherwise remains unchanged.

Changes

Setup warning output

Layer / File(s) Summary
Write skip message to stderr
scripts/setup-worktree.ts
When the environment-file source is not a regular file, the skip message is written to stderr instead of being emitted with console.warn.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 9ca82

The focused stderr change is mergeable with normal checks.

Architecture Summary

Architecture risk: 🔵 Low · up to 9ca82

The change affects 1 system.

Changed systems: scripts

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — scripts (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in scripts/setup-worktree.ts: The non-regular-file warning is now written to stderr rather than emitted with console.warn.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the main change: writing bootstrap warnings directly to stderr.
Description check ✅ Passed The description explains the typecheck problem, the stderr change, and the verification results. It also states that the env-file safeguards remain unchanged, which makes the focused scope clear.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@maria-rcks
maria-rcks merged commit de09c75 into pingdotgg:main Oct 5, 2026
31 checks passed
scratchyone added a commit to scratchyone/t3code that referenced this pull request Oct 5, 2026
Picks up pingdotgg#15865, which fixes the setup-worktree Typecheck error on main.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Oct 5, 2026
## What's Changed
* fix(cli): reject accidental server launches by @maria-rcks in pingdotgg/t3code#15795
* feat(clients): reach one environment over several routes by @juliusmarminge in pingdotgg/t3code#15467
* feat(clients): learn an environment's LAN and tailnet addresses by @juliusmarminge in pingdotgg/t3code#15468
* fix(server): share MCP tool presentation across providers by @juliusmarminge in pingdotgg/t3code#15475
* revert(chat): remove automatic file-link repair by @maria-rcks in pingdotgg/t3code#15824
* perf(web): validate monospace fonts when selected by @maria-rcks in pingdotgg/t3code#15642
* fix(server): expand home-relative media paths by @maria-rcks in pingdotgg/t3code#15618
* fix(server): recover Linux runtime directory for device hub by @maria-rcks in pingdotgg/t3code#12402
* fix(web): center icons in thread details icon buttons by @RakshithBhat03 in pingdotgg/t3code#15669
* fix(mobile): back from an agent's thread returns to its parent by @AKolenda in pingdotgg/t3code#15068
* fix(dev): worktree setup never deletes a real env file by @juliusmarminge in pingdotgg/t3code#15845
* fix(server): drop the duplicate Option import that breaks main CI by @juliusmarminge in pingdotgg/t3code#15847
* fix(dev): write bootstrap warnings directly to stderr by @maria-rcks in pingdotgg/t3code#15865
* fix(mobile): a message that fails to send now says why in the thread by @shivamhwp in pingdotgg/t3code#15807
* fix(server): queue background notifications during active tools by @Yash-Singh1 in pingdotgg/t3code#15892
* refactor(server): share one keyed lock that releases idle keys by @juliusmarminge in pingdotgg/t3code#15577


**Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261004.2657...v0.0.46-nightly.20261005.2667

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261005.2667
github-actions Bot added a commit to davidvanderklay/t3code-flake that referenced this pull request Oct 5, 2026
## What's Changed
* fix(cli): reject accidental server launches by @maria-rcks in pingdotgg/t3code#15795
* feat(clients): reach one environment over several routes by @juliusmarminge in pingdotgg/t3code#15467
* feat(clients): learn an environment's LAN and tailnet addresses by @juliusmarminge in pingdotgg/t3code#15468
* fix(server): share MCP tool presentation across providers by @juliusmarminge in pingdotgg/t3code#15475
* revert(chat): remove automatic file-link repair by @maria-rcks in pingdotgg/t3code#15824
* perf(web): validate monospace fonts when selected by @maria-rcks in pingdotgg/t3code#15642
* fix(server): expand home-relative media paths by @maria-rcks in pingdotgg/t3code#15618
* fix(server): recover Linux runtime directory for device hub by @maria-rcks in pingdotgg/t3code#12402
* fix(web): center icons in thread details icon buttons by @RakshithBhat03 in pingdotgg/t3code#15669
* fix(mobile): back from an agent's thread returns to its parent by @AKolenda in pingdotgg/t3code#15068
* fix(dev): worktree setup never deletes a real env file by @juliusmarminge in pingdotgg/t3code#15845
* fix(server): drop the duplicate Option import that breaks main CI by @juliusmarminge in pingdotgg/t3code#15847
* fix(dev): write bootstrap warnings directly to stderr by @maria-rcks in pingdotgg/t3code#15865
* fix(mobile): a message that fails to send now says why in the thread by @shivamhwp in pingdotgg/t3code#15807
* fix(server): queue background notifications during active tools by @Yash-Singh1 in pingdotgg/t3code#15892
* refactor(server): share one keyed lock that releases idle keys by @juliusmarminge in pingdotgg/t3code#15577


**Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261004.2657...v0.0.46-nightly.20261005.2667

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261005.2667
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant