fix(dev): write bootstrap warnings directly to stderr - #15865
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This narrowly scoped development fix preserves the existing warning text and control flow while writing directly to stderr during worktree setup. It does not affect product defaults or production request behavior, and it removes rather than adds a static-analysis suppression. You can add or adjust custom eligibility rules. Learn more. |
|
Note Written by addressed in 9ca829f: removed the diagnostic suppression and replaced |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughWhen the environment-file source is not a regular file, ChangesSetup warning output
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The focused stderr change is mergeable with normal checks. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Picks up pingdotgg#15865, which fixes the setup-worktree Typecheck error on main. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
## What's Changed * fix(cli): reject accidental server launches by @maria-rcks in pingdotgg/t3code#15795 * feat(clients): reach one environment over several routes by @juliusmarminge in pingdotgg/t3code#15467 * feat(clients): learn an environment's LAN and tailnet addresses by @juliusmarminge in pingdotgg/t3code#15468 * fix(server): share MCP tool presentation across providers by @juliusmarminge in pingdotgg/t3code#15475 * revert(chat): remove automatic file-link repair by @maria-rcks in pingdotgg/t3code#15824 * perf(web): validate monospace fonts when selected by @maria-rcks in pingdotgg/t3code#15642 * fix(server): expand home-relative media paths by @maria-rcks in pingdotgg/t3code#15618 * fix(server): recover Linux runtime directory for device hub by @maria-rcks in pingdotgg/t3code#12402 * fix(web): center icons in thread details icon buttons by @RakshithBhat03 in pingdotgg/t3code#15669 * fix(mobile): back from an agent's thread returns to its parent by @AKolenda in pingdotgg/t3code#15068 * fix(dev): worktree setup never deletes a real env file by @juliusmarminge in pingdotgg/t3code#15845 * fix(server): drop the duplicate Option import that breaks main CI by @juliusmarminge in pingdotgg/t3code#15847 * fix(dev): write bootstrap warnings directly to stderr by @maria-rcks in pingdotgg/t3code#15865 * fix(mobile): a message that fails to send now says why in the thread by @shivamhwp in pingdotgg/t3code#15807 * fix(server): queue background notifications during active tools by @Yash-Singh1 in pingdotgg/t3code#15892 * refactor(server): share one keyed lock that releases idle keys by @juliusmarminge in pingdotgg/t3code#15577 **Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261004.2657...v0.0.46-nightly.20261005.2667 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261005.2667
## What's Changed * fix(cli): reject accidental server launches by @maria-rcks in pingdotgg/t3code#15795 * feat(clients): reach one environment over several routes by @juliusmarminge in pingdotgg/t3code#15467 * feat(clients): learn an environment's LAN and tailnet addresses by @juliusmarminge in pingdotgg/t3code#15468 * fix(server): share MCP tool presentation across providers by @juliusmarminge in pingdotgg/t3code#15475 * revert(chat): remove automatic file-link repair by @maria-rcks in pingdotgg/t3code#15824 * perf(web): validate monospace fonts when selected by @maria-rcks in pingdotgg/t3code#15642 * fix(server): expand home-relative media paths by @maria-rcks in pingdotgg/t3code#15618 * fix(server): recover Linux runtime directory for device hub by @maria-rcks in pingdotgg/t3code#12402 * fix(web): center icons in thread details icon buttons by @RakshithBhat03 in pingdotgg/t3code#15669 * fix(mobile): back from an agent's thread returns to its parent by @AKolenda in pingdotgg/t3code#15068 * fix(dev): worktree setup never deletes a real env file by @juliusmarminge in pingdotgg/t3code#15845 * fix(server): drop the duplicate Option import that breaks main CI by @juliusmarminge in pingdotgg/t3code#15847 * fix(dev): write bootstrap warnings directly to stderr by @maria-rcks in pingdotgg/t3code#15865 * fix(mobile): a message that fails to send now says why in the thread by @shivamhwp in pingdotgg/t3code#15807 * fix(server): queue background notifications during active tools by @Yash-Singh1 in pingdotgg/t3code#15892 * refactor(server): share one keyed lock that releases idle keys by @juliusmarminge in pingdotgg/t3code#15577 **Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261004.2657...v0.0.46-nightly.20261005.2667 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261005.2667
main's typecheck fails with TS377064 because the standalone worktree setup script uses
console.warn. write the same warning directly to node's stderr stream, preserving its text and newline without a diagnostic suppression or a dependency on effect. the env-file safeguards remain unchanged.verified on blacksmith: scripts typecheck, targeted lint and formatting, and all 74 existing dev-runner tests passed. a direct node runtime comparison confirmed matching warning output and exit status.
model: gpt-6.1-sol. harness: codex in t3 code.