Skip to content

refactor(provider-core): add the provider client contract package - #17282

Closed
juliusmarminge wants to merge 1 commit into
mainfrom
t3/provider-core
Closed

juliusmarminge wants to merge 1 commit into
mainfrom
t3/provider-core

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Provider client metadata (label, settings schema, environment fields, badge) lived in a web-only table, so there was no shared interface a provider package could export its client half against.

This adds @t3tools/provider-core with a ./client entry: ProviderClientDefinition, plus a small registry that looks definitions up by driver kind (and returns undefined for drivers a client does not ship, such as a fork's). The web settings, onboarding, and usage code now read that registry. The definitions themselves stay in web until each provider moves into its own package.

No behavior change.


Part of the provider-packages stack: #17282 → #17283 → #17284 → #17285 → #17286 → #17287 → #17288.

Done by Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

Provider client metadata (label, settings schema, environment fields,
badge) lived in a web-only table. Move its shape into a new
@t3tools/provider-core package as ProviderClientDefinition plus a small
registry, so provider packages can export their client half against a
shared interface. The web settings UI now reads the registry; the
definitions themselves still live in web until each provider moves out.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Oct 8, 2026
@juliusmarminge
juliusmarminge added this pull request to stack #17289 October 8, 2026 19:33
@github-actions github-actions Bot added the size:L 100-499 changed lines (additions + deletions). label Oct 8, 2026
@juliusmarminge juliusmarminge changed the title t3/provider core refactor(provider-core): add the provider client contract package Oct 8, 2026
@juliusmarminge juliusmarminge added the macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews label Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ The exact PR base did not have a successful artifact. Baseline uses the latest successful main measurement shown below.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 20.9 KiB 20.9 KiB 0 B (0.0%) 29.3 KiB ✅
Codex Live turn messages 2 2 0 (0.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.0 KiB +24 B (+0.5%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.2 KiB 1.2 KiB +24 B (+2.0%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.2 KiB 21.2 KiB +41 B (+0.2%) 29.3 KiB ✅
Claude Live turn messages 1 2 +1 (+100.0%) 8 ✅

Baseline: fd25c42 · PR result: 800f320 · Source CI: failure

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@juliusmarminge

Copy link
Copy Markdown
Member Author

Superseded by the squashed 3-PR stack #17299 → #17300 → #17302 (same changes, regrouped; Effect service modules renamed to PascalCase).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant