Skip to content

refactor(settings): drop the legacy per-driver providers map - #17285

Closed
juliusmarminge wants to merge 2 commits into
t3/provider-testingfrom
t3/drop-legacy-provider-settings
Closed

juliusmarminge wants to merge 2 commits into
t3/provider-testingfrom
t3/drop-legacy-provider-settings

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

ServerSettings.providers (one blob per built-in driver) listed every provider's settings schema in contracts, which kept providers from moving into their own packages. providerInstances is now the only provider configuration.

  • An unconfigured built-in default slot runs with the driver's default config. Codex and Claude start enabled; the rest start off. The ACP Registry opts out of a default instance through driver metadata.
  • Migration: on load, a settings file that still has the old map moves each customized entry into its driver's default slot (an explicit instance wins), applies provider history to the cursor/grok/opencode opt-ins as before, and is rewritten once without the old key. An unreadable file is never rewritten. This matters for real installs: some still point Codex/Claude at custom binaries only through the old map.
  • Web settings, onboarding, and model selection read instances only. Resetting a default instance just removes it.

Tests cover the migration (customized entries, explicit-instance precedence, history opt-ins, explicit disables, untouched invalid files) and the new defaults.


Part of the provider-packages stack: #17282 → #17283 → #17284 → #17285 → #17286 → #17287 → #17288.

Done by Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

juliusmarminge and others added 2 commits October 8, 2026 12:21
ServerSettings.providers listed every built-in provider's schema in
contracts, which kept providers from moving into their own packages.
providerInstances is now the only provider configuration.

- An empty built-in default slot runs with the driver's default config;
  Codex and Claude start enabled, the rest start off. The ACP Registry
  opts out of a default instance through driver metadata.
- On load, a settings file that still has the old map moves each
  customized entry into its driver's default slot (an explicit instance
  wins), applies provider history to the cursor/grok/opencode opt-ins,
  and is rewritten once without the old key.
- Web settings, onboarding, and model selection read instances only;
  resetting a default instance just removes it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…instances

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Oct 8, 2026
@juliusmarminge
juliusmarminge added this pull request to stack #17289 October 8, 2026 19:33
@github-actions github-actions Bot added the size:XL 500-999 changed lines (additions + deletions). label Oct 8, 2026
@juliusmarminge juliusmarminge changed the title t3/drop legacy provider settings refactor(settings): drop the legacy per-driver providers map Oct 8, 2026
@juliusmarminge juliusmarminge added the macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews label Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire — 5.0 KiB — 6.8 KiB ✅
Codex Thread snapshot wire — 3.8 KiB — 4.9 KiB ✅
Codex Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Codex Live turn WebSocket decoded — 20.9 KiB — 29.3 KiB ✅
Codex Live turn messages — 2 — 8 ✅
Claude Total thread wire — 5.0 KiB — 6.8 KiB ✅
Claude Thread snapshot wire — 3.8 KiB — 4.9 KiB ✅
Claude Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Claude Live turn WebSocket decoded — 21.2 KiB — 29.3 KiB ✅
Claude Live turn messages — 2 — 8 ✅

Baseline: unavailable · PR result: 62a9a4a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@juliusmarminge

Copy link
Copy Markdown
Member Author

Superseded by the squashed 3-PR stack #17299 → #17300 → #17302 (same changes, regrouped; Effect service modules renamed to PascalCase).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews size:XL 500-999 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant