refactor(mobile): share settings action rows

[juliusmarminge]

Design-system progress

API adoption and Pen rendering are tracked separately. This is cumulative through this PR, not a claim that all native renderers are finished.

Pen component	After this PR
Host / native theme	Later in stack
List / Section / Row	Shared RN rows; native Form / ListItems left
Toggle	Later in stack
Segmented	Later in stack
Menu	Later in stack
Sheet	Later in stack
Dialog	Later in stack
SearchField	Later in stack
Button / IconButton	Later in stack
Chip	Later in stack
Toast	Later in stack
FAB	Later in stack
Toolbar	Later in stack
AppBar	Later in stack
Picker / Slider / Stepper	Later in stack
Progress / EmptyState	Later in stack
Typography / shapes / motion	Later in stack
Split / list-detail / rail	Deferred broader layout work

Custom Appearance cards stay. Segmented controls stay native. Composer, thread-row and task-tray redesigns remain deferred.

Problem

Settings action rows used separate spacing and text sizes from navigation, toggle, and choice rows.

Change

Move them onto ListActionRow and the shared layout, including destructive colors, loading feedback, disabled state, and accessibility hints. Existing settings actions adopt it through their adapter.

Scope and approval

Maintainer-authored work requested by Julius as part of the mobile design-system stack. This layer only standardizes existing settings action rows; it adds no new settings or actions. Based on main after the earlier layers merged.

Verification

Mobile typecheck, targeted lint, and 53 dependency/theme tests pass. Inspected the microphone action on real iOS and Android clients. Action handlers are unchanged; destructive cache actions were not executed.

Before is on the left; after is on the right.

Model: GPT-6.1. Harness: Codex.

---

[macroscopeapp]

Approvability

Verdict: Approved at ee3c64c

Macroscope's review found this PR approvable — This is a small, localized refactor that standardizes existing settings action rows on shared mobile list components. Its runtime effects are limited to presentation, interaction feedback, and accessibility state, with no new workflow or sensitive-system impact.

Notes:

• Diff unchanged. Approvability was decided on eligibility alone.

No code changes detected at 2303735. Prior analysis still applies.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Team
• Run ID: 3503b3a2-7230-42d6-9d20-72eff175d2fa

📥 Commits

Reviewing files that changed from the base of the PR and between 7369836 and 2303735.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Team
• Run ID: 4a21aa06-1d97-4f24-99f7-caf0dec8bf3f

📥 Commits

Reviewing files that changed from the base of the PR and between 48595c7 and ee3c64c.

📒 Files selected for processing (3)

• apps/mobile/src/components/ListActionRow.tsx
• apps/mobile/src/components/ListRowLayout.tsx
• apps/mobile/src/features/settings/components/SettingsActionRow.tsx

Limit details: You’ve used all 10 included reviews currently available.

📝 Walkthrough

📝 Walkthrough

Walkthrough

The pull request adds a shared mobile action row with accessibility states, Android-specific press behavior, loading feedback, and default or danger styling. The settings action row now re-exports this shared component.

Changes

Mobile action row

Layer / File(s)	Summary
Shared action row apps/mobile/src/components/ListRowLayout.tsx, apps/mobile/src/components/ListActionRow.tsx	ListRowLayout accepts default and danger tones. ListActionRow renders an accessible pressable row, disables interaction when disabled or loading, and shows a tone-dependent loading indicator.
Settings row reuse apps/mobile/src/features/settings/components/SettingsActionRow.tsx	SettingsActionRow now re-exports ListActionRow instead of defining platform-specific rendering paths.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to ee3c6

The shared settings rows appear ready to merge after normal checks.

Pre-merge checks: 4

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly describes the primary change: sharing settings action rows through a mobile refactor.
Description check		The description includes the required Problem, Change, Scope and approval, and Verification sections. It explains the shared-row migration, states the scope, lists focused verification results, and pr…

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

Dismissing prior approval to re-evaluate ee3c64c

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	5.0 KiB	4.9 KiB	−23 B (−0.5%)	6.8 KiB	✅
Codex	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Codex	Live turn WebSocket wire	1.2 KiB	1.2 KiB	−23 B (−1.9%)	2.0 KiB	✅
Codex	Live turn WebSocket decoded	20.9 KiB	20.8 KiB	−41 B (−0.2%)	29.3 KiB	✅
Codex	Live turn messages	2	1	−1 (−50.0%)	8	✅
Claude	Total thread wire	5.0 KiB	5.0 KiB	0 B (0.0%)	6.8 KiB	✅
Claude	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Claude	Live turn WebSocket wire	1.2 KiB	1.2 KiB	0 B (0.0%)	2.0 KiB	✅
Claude	Live turn WebSocket decoded	21.2 KiB	21.2 KiB	0 B (0.0%)	29.3 KiB	✅
Claude	Live turn messages	2	2	0 (0.0%)	8	✅

Baseline: 17e1087 · PR result: 2303735 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 108.5 KiB
• Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.