Repository navigation
Conversation
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — The production change is a focused Cursor request fix with targeted regression coverage, but the new test file adds an @effect-diagnostics directive that suppresses static-analysis diagnostics. That suppression requires human review under the repository’s review criteria. You can add or adjust custom eligibility rules. Learn more. |
|
Addressed the diagnostic-suppression finding in 3958063. The new SDK regression test now runs its subprocess probes through Effect’s scoped child-process service and timeout, so it no longer adds an @effect-diagnostics suppression. The SDK send and serialization assertions are unchanged. The 8 targeted tests passed, along with targeted lint and formatting and the Cursor package typecheck. Typecheck reported only existing suggestions in other files. |
|
The workflows for the latest head, 3958063, are waiting for maintainer approval. All four report The diagnostic-suppression fix is pushed, and the 8 targeted tests, targeted lint and formatting, and Cursor package typecheck passed locally. A repository maintainer also needs to request a Macroscope re-review of 3958063. The manual review request was rejected because the author lacks repository permissions. The original diagnostic-suppression finding has been addressed in that commit, but Macroscope has not evaluated the updated head. |
|
@macroscope-app review |
|
Sorry, I'm unable to act on this request because you do not have permissions within this repository. |
|
Superseded by #18700 to correct Git identity. The replacement has identical file contents and commit messages, preserves Matthew Feroz as author of the original fix, and uses emcee6798 as committer on both commits. The replacement commits passed the targeted checks before pushing. |
Problem
Cursor SDK requests omit
RequestedModel.maxMode, so Grok 4.7 at 500K fails withAI Model Not Found, while other long-context selections can use the wrong tier. This is the bug reported in #15788 and originally fixed by @MatthewFeroz in #15884.Change
This reapplies #15884 to current
mainafter the Cursor provider moved intopackages/provider-cursor. Selections above 300K set Max Mode; standard tiers remain unchanged. All implementation credit and development effort belong to @MatthewFeroz and the contributors to #15884. This replacement PR exists only to resolve the merge conflicts, and the original commit remains authored by Matthew Feroz.Scope and approval
This is the same focused obvious-bug fix as #15884, with no unrelated cleanup. Relevant feedback from the original PR is preserved by narrowly patching only
agent.v1.RequestedModel, retaining existing values, and testing the real SDK request path. The separate default-option issue in #16149 and generic provider-error presentation are intentionally out of scope.Verification
From
packages/provider-cursor:vp test run src/server/CursorSdk.test.ts src/server/sdk.test.ts— 8 tests passed, including real SDK request checks for Grok 4.7 at 500K and 256K.vp run typecheckpassed with existing unrelated Effect suggestions.No live authenticated Cursor turn was run on this rebased commit. #15884 contains the original macOS and Linux live verification.