Repository navigation
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — The PR narrowly fixes serialization of explicitly selected Cursor long-context tiers while preserving standard requests and unrelated protobuf messages. Production behavior is confined to the affected model request, and dedicated tests cover the real SDK path and edge cases. Notes:
You can add or adjust custom eligibility rules. Learn more. |
|
Tested the Max Mode rule from this PR locally. It works for the Grok 4.7 500K failure. This nightly ( After restarting the server onto the patched runtime, Cursor runs of The edit is wiped by the next nightly, since it lives in that runtime's |
|
Hi Team, any update? |
Problem
Cursor SDK requests omit
RequestedModel.maxMode, so Grok 4.7 at 500K fails withAI Model Not Found, while other long-context selections can use the wrong tier. This is the bug reported in #15788 and originally fixed by @MatthewFeroz in #15884.Change
This ports #15884 to
packages/provider-cursorafter the Cursor provider moved out of the server app. Selections above 300K set Max Mode; standard tiers remain unchanged. Credit for the original long-context fix belongs to @MatthewFeroz and the contributors to #15884; its commit remains authored by Matthew Feroz. This replaces #18685 to correct Git identity. Both commits now useemcee6798as committer, and the test follow-up usesemcee6798as author. The final code is identical to #18685 at3958063ebe.Scope and approval
This is the same focused obvious-bug fix as #15884, with no unrelated cleanup. Relevant feedback from the original PR is preserved by narrowly patching only
agent.v1.RequestedModel, retaining existing values, and testing the real SDK request path. The separate default-option issue in #16149 and generic provider-error presentation are intentionally out of scope.Verification
Verified on replacement head
f50aad2422before pushing, frompackages/provider-cursor:vp test run src/server/CursorSdk.test.ts src/server/sdk.test.ts— 8 tests passed, including real SDK request checks for Grok 4.7 at 500K and 256K.vp run typecheckpassed with existing unrelated Effect suggestions.The replacement commit trees and messages match #18685 exactly; only Git identity and commit metadata changed. No live authenticated Cursor turn was run on this replacement head. #15884 contains the original macOS and Linux live verification.