Repository navigation
fix(clients): scheduled task editors no longer default to a missing main branch #19373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davisonio
wants to merge
9
commits into
pingdotgg:main
Choose a base branch
from
davisonio:fix/scheduled-task-default-base-branch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+252
−20
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
10f412a
fix(clients): scheduled task editors no longer default to a missing m…
davisonio d353d84
fix(server): a branch named exactly the search leads the ref list
davisonio bc8c29d
Merge commit '18f26cf179503f2311b0006f3392cbcd812833ef' into worktree…
juliusmarminge 26dfafb
fix(clients): discover scheduled task bases across ref pages
juliusmarminge 6bfe5d5
fix(mobile): show remote scheduled task bases consistently
juliusmarminge bb2f470
fix(mobile): select the origin row for automatic main
juliusmarminge 18c2f8a
Merge remote-tracking branch 'origin/main' into pr-19373
juliusmarminge 22450c4
Merge remote-tracking branch 'origin/main' into pr-19373
juliusmarminge 3d0b906
Merge remote-tracking branch 'origin/main' into pr-19373
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
apps/mobile/src/features/settings/useScheduledTaskBaseRef.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import { useAtomValue } from "@effect/atom-react"; | ||
| import type { EnvironmentId } from "@t3tools/contracts"; | ||
|
|
||
| import { scheduledTaskBaseRefAtom } from "../../state/vcs"; | ||
|
|
||
| export function useScheduledTaskBaseRef(input: { | ||
| readonly environmentId: EnvironmentId | null; | ||
| readonly cwd: string | null; | ||
| readonly chosen: string; | ||
| readonly worktree: boolean; | ||
| }) { | ||
| const autoBaseRef = useAtomValue( | ||
| scheduledTaskBaseRefAtom({ | ||
| environmentId: input.environmentId, | ||
| cwd: input.worktree && !input.chosen ? input.cwd : null, | ||
| }), | ||
| ); | ||
| return { baseRef: input.chosen || autoBaseRef.baseRef, pending: autoBaseRef.pending }; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.