Repository navigation
refactor(mobile): use shared Menu for markdown long presses - #20019
Conversation
5a5f458 to
47b5197
Compare
a0e1550 to
8c23c7f
Compare
8c23c7f to
192018f
Compare
192018f to
cf0622d
Compare
cf0622d to
50158c0
Compare
|
🚀 Expo continuous deployment is ready!
|
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
50158c0 to
717d1e4
Compare
717d1e4 to
5bc12ed
Compare
ebef9e7 to
f7e380c
Compare
f7e380c to
316240a
Compare
316240a to
9083b00
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a focused one-file mobile refactor that reuses the existing shared menu and preserves the existing Android anchoring and action flow. Its only observable impact is localized markdown link-menu presentation and gesture plumbing, with no schema, security, deployment, or product-default changes. You can add or adjust custom eligibility rules. Learn more. |
Chat link long-presses should use menus, without introducing a new bottom-sheet interaction.
Route Android markdown link gestures through the shared
Menucomponent while preserving the existing anchored menu and action handlers. Keep iOS’s existing native per-link context menus and remove the action-sheet fallback. The rich-text adapter forwards only link long-presses, leaving ordinary taps and text selection with the markdown renderer.This replaces the earlier action-sheet implementation in this PR. There is no new
Dialog.actionsAPI or catalog example.Validation
Design-system progress
API adoption and Pen rendering are tracked separately. This is cumulative through this PR, not a claim that all native renderers are finished.
Custom Appearance cards stay. Segmented controls stay native. Composer, thread-row and task-tray redesigns remain deferred.
Model: GPT-6.1. Harness: Codex.
Toast decision: retain the custom themed Toast on both platforms for Git progress, success, and errors. The native Snackbar experiment in #20017 was dropped after visual review.