Skip to content

refactor(mobile): use shared Menu for markdown long presses #20019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Oct 15, 2026
Merged

refactor(mobile): use shared Menu for markdown long presses #20019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 26 additions & 34 deletions apps/mobile/src/native/EnrichedMarkdownText.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import {
formatComposerContextReference,
} from "@t3tools/shared/composerContextReferences";
import { markdownWithHtml } from "../lib/markdownDocument";
import { useCallback, useMemo, useState } from "react";
import { ActionSheetIOS, Platform, Share, StyleSheet, View } from "react-native";
import { useCallback, useMemo, useState, type ReactNode } from "react";
import { Platform, Share, StyleSheet, View } from "react-native";
import {
EnrichedMarkdownText,
type DocumentAssetsEvent,
Expand All @@ -16,7 +16,7 @@ import {
import type { SelectableMarkdownTextProps } from "./SelectableMarkdownText.types";

import { useAppearancePreferences } from "../features/settings/appearance/AppearancePreferencesProvider";
import { AndroidAnchoredMenu } from "../components/AndroidAnchoredMenu";
import { Menu } from "../components/Menu";
import { useEnrichedLinkVariants } from "./useEnrichedLinkVariants";
import { copyTextWithHaptic } from "../lib/copyTextWithHaptic";
import {
Expand Down Expand Up @@ -262,37 +262,20 @@ export function MobileEnrichedMarkdownText(props: SelectableMarkdownTextProps) {
[resolveImageSource],
);
const renderMarkdown = (openAndroidMenu?: () => void) => {
const onLinkLongPress = props.fileContextMenu
? ({ url }: { url: string }) => {
const menu = props.fileContextMenu?.(url) ?? {
title: url,
actions: [
{ id: "enriched-open-link", title: "Open link" },
{ id: "enriched-copy-link", title: "Copy link" },
],
};
const actions = menu.actions;
if (Platform.OS === "ios") {
ActionSheetIOS.showActionSheetWithOptions(
{
title: menu.title,
options: [...actions.map((action) => action.title), "Cancel"],
cancelButtonIndex: actions.length,
disabledButtonIndices: actions.flatMap((action, index) =>
action.disabled ? [index] : [],
),
},
(index) => {
const action = actions[index];
if (action && !action.disabled) performMenuAction(url, action.id);
},
);
} else {
const onLinkLongPress =
Platform.OS === "android" && props.fileContextMenu
? ({ url }: { url: string }) => {
const menu = props.fileContextMenu?.(url) ?? {
title: url,
actions: [
{ id: "enriched-open-link", title: "Open link" },
{ id: "enriched-copy-link", title: "Copy link" },
],
};
setActiveMenu({ url, menu });
openAndroidMenu?.();
}
}
: undefined;
: undefined;

return (
<View
Expand Down Expand Up @@ -338,7 +321,8 @@ export function MobileEnrichedMarkdownText(props: SelectableMarkdownTextProps) {
};

return Platform.OS === "android" && props.fileContextMenu ? (
<AndroidAnchoredMenu
<Menu
shouldOpenOnLongPress
title={activeMenu?.menu.title}
actions={
activeMenu?.menu.actions.map((action) => ({
Expand All @@ -352,9 +336,17 @@ export function MobileEnrichedMarkdownText(props: SelectableMarkdownTextProps) {
}}
style={{ flexShrink: 1, minWidth: 0 }}
>
{renderMarkdown}
</AndroidAnchoredMenu>
<MarkdownMenuAnchor renderMarkdown={renderMarkdown} />
</Menu>
) : (
renderMarkdown()
);
}

/** Adapts the rich-text link gesture to Menu's long-press trigger without wrapping text in a Pressable. */
function MarkdownMenuAnchor(props: {
readonly renderMarkdown: (openMenu?: () => void) => ReactNode;
readonly onLongPress?: () => void;
}) {
return props.renderMarkdown(props.onLongPress);
}
Loading