perf(mobile): Connect onboarding compiles with the React Compiler

[juliusmarminge]

The React Compiler skipped ConnectOnboardingRouteScreen because its refresh handler wrapped an await in try/finally.

Stacked on #20969. Part of the React Compiler ratchet from #20967.

The refresh now resets its spinner with .finally() on the promise. Its 3 useCallbacks are gone, and the file is removed from KNOWN_BAILOUTS (86 to 85).

Verified with vp test run src/reactCompilerCoverage.test.ts plus the feature's own tests, mobile typecheck, and lint on the changed files. Measured on an Android emulator below.

Measurement

Scenario: --route /connect-onboarding. Device: Android emulator, Pixel 9 API 36, on nucbox-1, with Metro and an isolated seeded server on cups; dev client rebuilt from #20967 today. Harness: --route scenario from #21001 at 4dee0fbead. Each run reloads the app on Home, starts the counter, opens the route with an app link and records 6 s covering mount and data settling. Median of 3. Both sides sit on the same base, main 13aa882c22 plus the stack below; "before" is the parent PR head, "after" is this PR head. The public Clerk and relay values from .env.example were set so the sheet renders; the app is signed out, so it shows the sign-in prompt, not environment rows. Before: #20969 at 3d3872ca45. After: e620e9c4e2.

Runs (renders/commits): before 725/13, 725/12, 725/13. After 675/13, 675/12, 675/12.

	before	after	Δ
renders	725	675	-50 (-7%)
commits	13	12	-1
renders per commit	56	56	0

Components that changed, one probe run per side with the same window:

Component	before	after	Δ
View	205	189	-16
IconButton	12	8	-4
AndroidHeaderIconButton	8	4	-4
AndroidSheetHeader	3	1	-2
NativeThemeHost / Host / HostView	14	12	-2 each

Cause	before	after	Δ
AndroidHeaderIconButton parent-same-props<-View	6	2	-4
IconButton parent-same-props<-AndroidHeaderIconButton	6	2	-4
View props:children	55	51	-4
AndroidSheetHeader props:actions	2	0	-2
NativeThemeHost props:children	11	9	-2

What it means: a small, real improvement on Android. Before this PR the screen rebuilt the header's actions array on each of its re-renders as auth and connections settle, so AndroidSheetHeader and its two icon buttons re-rendered with it. Compiled, the array keeps its identity and the header renders once. The screen's own render count (3) didn't change. The runs barely varied (725 and 675 every time).

Claude Opus 5.5 via Claude Code.

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at 044079d

Macroscope's review found this PR approvable — This is a small, self-contained React Compiler compatibility change in one mobile onboarding screen, with a corresponding coverage-test update. It does not alter product defaults, APIs, schemas, security-sensitive code, or static-analysis configuration.

No code changes detected at e620e9c. Prior analysis still applies.

^{You can add or adjust custom eligibility rules. Learn more.}

[github-actions]

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for e620e9c.

This comment will update automatically after the next completed run.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Team
• Run ID: 00051cd0-7f42-4293-8753-a132de105597

📥 Commits

Reviewing files that changed from the base of the PR and between 38e2041 and 044079d.

📒 Files selected for processing: 2

• apps/mobile/src/features/cloud/ConnectOnboardingRouteScreen.tsx
• apps/mobile/src/reactCompilerCoverage.test.ts

💤 Files with no reviewable changes: 1

• apps/mobile/src/reactCompilerCoverage.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.

📝 Walkthrough

The onboarding screen replaces memoized refresh, close, and opt-out handlers with ordinary functions. The compiler coverage test removes the screen from its expected bailout list.

Changes: Connect onboarding

Layer / File(s)	Summary
Update onboarding handlers apps/mobile/src/features/cloud/ConnectOnboardingRouteScreen.tsx, apps/mobile/src/reactCompilerCoverage.test.ts	The screen defines its refresh, close, and opt-out handlers as ordinary functions. The coverage test no longer expects a compiler bailout for the screen.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Suggested reviewers: pixpmusic, maria-rcks

Merge Risk: ⚪ Minimal · up to 04407

This change lets the onboarding screen compile with the React Compiler by simplifying its handlers. No concrete merge-blocking risk was established. Device testing was not run.

Pre-merge checks: 3 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Description check		The description explains the problem, implementation, verification commands, performance measurement, and related stacked changes. It does not provide the required Scope and approval information, and …	Add a Scope and approval section. Link the triaged issue or maintainer approval, or explain why this focused React Compiler change qualifies for an exemption. Resolve the device-testing inconsistency by stating whether the Android emulator …

Passed checks: 3 passed

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly identifies the main change: enabling React Compiler compilation for the mobile Connect onboarding screen.

Full details: Description check

Explanation

The description explains the problem, implementation, verification commands, performance measurement, and related stacked changes. It does not provide the required Scope and approval information, and the supplied objectives conflict with the description about whether device testing was performed.

Resolution

Add a Scope and approval section. Link the triaged issue or maintainer approval, or explain why this focused React Compiler change qualifies for an exemption. Resolve the device-testing inconsistency by stating whether the Android emulator measurement was performed and include the observed result.

• Fix all pre-merge checks with AI

✨ Finishing Touches: 💡 1

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}