fix(mobile): sheets close with an X and confirm with a checkmark

[juliusmarminge]

Thread settings on mobile showed Cancel and Done as two identical text buttons, so nothing told users that one discards edits and the other applies them. iOS convention is an X to close without changes and a prominent checkmark to apply.

Thread settings sheet: X on the left, prominent checkmark on the right (tinted with --color-prominent-action). The checkmark covers both the old "Done" and "Save" cases; its accessibility label still says which one it is.

The same look-alike text buttons were in other places too:

Surface	Before	After
New thread sheet	"Cancel"	X
Custom snooze popover (iOS)	X + "Snooze" text	X + prominent checkmark
Shared Sheet header (iOS: terminal output, worktree setup, composer context)	system-blue "Done", dismiss only	X
Worktree setup sheet (Android)	"Done" text	X header action
Arrange threads modal	"Done", dismiss only (each drop already saves)	X
NumberField picker popover (iOS, e.g. auto-settle days)	"Cancel" + "Done" in identical blue text	bordered X + prominent checkmark

Sheets that only dismiss get an X. A checkmark appears only where something gets applied. Inline row toggles ("Edit"/"Done" in lists), alerts, and in-content banners are unchanged, since they aren't nav-bar actions. The user doc for Arrange threads no longer refers to a Done button.

Other surfaces, before/after

Verified

On an iPhone 17 Pro Max simulator (iOS 26.5) against an isolated dev backend seeded with real threads:

• Thread settings: picking another model, then X, closes without changing the thread. Picking a model, then the checkmark, applies it (composer shows the new model). The checkmark's accessibility label switches from "Done" to "Save thread settings" once a model is pending.
• Auto-settle days picker: X closes without changing the value; the checkmark applies a new value.
• New thread, custom snooze, Arrange threads, and the shared Sheet: X closes each.
• Light and dark mode both checked; the dark-mode checkmark keeps a dark glyph on its light fill.

Not run on Android; the Android change is the worktree-setup sheet header only.

Done with Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at aa83f99

Macroscope's review found this PR approvable — This is a localized mobile UI polish change that replaces ambiguous text actions with conventional X and checkmark icons while preserving existing close and submit behavior. It introduces no schema, deployment, sensitive-data, product-default, or static-analysis configuration changes.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Team
• Run ID: 2abfd87a-495c-4f9d-b252-f1d2e7a470e5

📥 Commits

Reviewing files that changed from the base of the PR and between d8e9fd2 and aa83f99.

📒 Files selected for processing: 8

• apps/mobile/src/components/ui/NumberField.tsx
• apps/mobile/src/components/ui/Sheet.tsx
• apps/mobile/src/features/threads/CustomSnoozeSheet.ios.tsx
• apps/mobile/src/features/threads/NewTaskDraftScreen.tsx
• apps/mobile/src/features/threads/ThreadArrangementSheet.tsx
• apps/mobile/src/features/threads/ThreadSettingsSheet.tsx
• apps/mobile/src/features/threads/worktree-setup-sheet.android.tsx
• docs/user/thread-sidebar.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.

📝 Walkthrough

Mobile sheet and toolbar actions replace several text labels with icons. Existing actions and accessibility labels remain in place. The thread-sidebar instructions now describe closing the sheet to return to the thread list.

Changes: Mobile sheet actions

Layer / File(s)	Summary
Shared control actions apps/mobile/src/components/ui/NumberField.tsx, apps/mobile/src/components/ui/Sheet.tsx	NumberField uses xmark and checkmark icons for Cancel and Done. The sheet header uses an xmark close action and a new identifier.
Thread sheet actions and instructions apps/mobile/src/features/threads/CustomSnoozeSheet.ios.tsx, apps/mobile/src/features/threads/NewTaskDraftScreen.tsx, apps/mobile/src/features/threads/ThreadArrangementSheet.tsx, apps/mobile/src/features/threads/ThreadSettingsSheet.tsx, apps/mobile/src/features/threads/worktree-setup-sheet.android.tsx, docs/user/thread-sidebar.md	Thread toolbar actions use icon controls for snoozing, cancellation, closing, and saving. Android worktree setup uses the header close action. The mobile instructions now say to close the sheet to return to the thread list.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: maria-rcks

Merge Risk: ⚪ Minimal · up to aa83f

The sheet actions now use icons while retaining their labels and existing actions. No concrete functional or checked-in automation issue is established; visual parity still awaits simulator validation.

Pre-merge checks: 3 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Description check		The description clearly explains the problem, affected surfaces, implementation, screenshots, and focused verification results. It does not include the required Scope and approval information, such as…	Add a Scope and approval section. Include the triaged issue or explicit maintainer approval with a link and approval comment. If no prior issue or discussion exists, explain why this focused, obvious fix qualifies for the exemption.

Passed checks: 3 passed

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly summarizes the main change: dismiss-only mobile sheets use an X, and actions that apply changes use a checkmark.

Full details: Description check

Explanation

The description clearly explains the problem, affected surfaces, implementation, screenshots, and focused verification results. It does not include the required Scope and approval information, such as a linked issue, maintainer approval, or an explanation that this focused fix qualifies for an exemption.

Resolution

Add a Scope and approval section. Include the triaged issue or explicit maintainer approval with a link and approval comment. If no prior issue or discussion exists, explain why this focused, obvious fix qualifies for the exemption.

• Fix all pre-merge checks with AI

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}