Repository navigation
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This updates the vendored markdown renderer and its dependency references to correct Android file-link pill text scaling. The runtime effect is narrowly limited to existing mobile markdown rendering, with no product-default, schema, security, or static-analysis changes. You can add or adjust custom eligibility rules. Learn more. |
Contributor
RVZO6
added a commit
to RVZO6/t3code
that referenced
this pull request
Oct 21, 2026
Picks up pingdotgg/enriched-markdown#8, which resets the pill label's horizontal text scale so it no longer inherits inline code's narrowed padding space. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
RVZO6
force-pushed
the
fix/mobile-android-pill-squish
branch
from
October 21, 2026 19:17
5d235c9 to
9701546
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since #18735, Android draws file link pills whose text is inline code at about half width. The label is still DM Sans, just squeezed horizontally. Agents usually write file links this way (
[`menu.js`](menu.js)), so most file links in chat are affected. iOS is not.Change
The Enriched Markdown tarball in #18735 (fork commit
373f4eec) pads inline code with a no-break space at each end, narrowed byScaleXSpan(0.55f).LinkPillSpantakes its paint from the link's first run, which is now that padding space, and copies itstextScaleX. pingdotgg/enriched-markdown#8 resetstextScaleXto 1 when the pill sets up its label paint.This PR swaps in a tarball packed from that branch (
675136e7), followingapps/mobile/deps/README.md. Compared with the shipped tarball, the only file differences areLinkPillSpan.ktand the commit recorded int3-fork.json. Android clients need a native rebuild to pick it up.Scope and approval
This is a very small, focused fix for an obvious regression, so it qualifies without a prior issue. #18735 made inline-code file links render at 0.55× width on Android. The fix resets one paint property so they render at normal width again. It doesn't change behavior on any other path.
Verification
LinkPillSpan.ktandt3-fork.jsondiffer.SelectableMarkdownTextpath as the chat feed. The inline-code pill now matches the width of a plain[menu.js](menu.js)pill.v0.1.1-nightly.20261020.3386.v0.1.1-nightly.20261020.3386, thread feed)CI failures in Build and Typecheck and Test Web come from
main(Cannot find module 'mermaid'after #21472), not from this change.🤖 Generated with Claude Code (Claude Opus 5.5)