Repository navigation
fix(scheduler): show short server timezone on fixed-time labels - #23111
shawk08033 wants to merge 1 commit into
Conversation
Fixed-time tasks run in the server zone, but labels showed an unqualified wall-clock time. Restore the list timeZone field and append a short zone (UTC, PDT, GMT+5:30) so the automations panel stays compact after pingdotgg#18653 was reverted for overflowing full IANA names. Fixes pingdotgg#18632 Co-authored-by: Cursor <cursoragent@cursor.com>
|
Before/after evidence image (local generation): short zone labels UTC/PDT instead of unqualified times or full IANA names. Label examples from unit tests on this branch:
|
|
Browser tests now green on this host after installing Playwright Chromium with: PLAYWRIGHT_HOST_PLATFORM_OVERRIDE=ubuntu24.04-x64 pnpm --filter @t3tools/web exec playwright install chromiumUbuntu 26.04 is outside Playwright 1.60’s official host matrix; the override downloads the ubuntu24.04-x64 build. Once cached, subsequent test runs do not need the override. |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a backward-compatible scheduler-label fix: the server exposes its optional timezone and web/mobile clients append a short zone only for fixed-time schedules. Scheduling execution, interval/webhook labels, older-server behavior, and product defaults remain unchanged, with targeted tests covering the new metadata and formatting. You can add or adjust custom eligibility rules. Learn more. |
Summary
Fixes #18632.
Fixed-time schedules run in the server timezone, but list/editor labels showed an unqualified wall-clock time (
Daily at 16:31). A remote client can read that as its own local time.This restores the
timeZonefield onScheduledTaskListResult(as in #18653) and appends a short zone label —UTC,PDT,GMT+5:30— instead of the full IANA name that overflowed the automations panel and led to revert #22230.Scheduling behavior is unchanged; only labeling/display.
Evidence
Problem (accepted in #18632): the missing zone on the label is the bug, not the zone schedules run in.
Label format (from unit tests on this branch):
Daily at 16:31Daily at 16:31 UTCAmerica/Los_AngelesPDT/PST/GMT-7Asia/KolkataGMT+5:30(orIST)timeZone)Daily at 09:00Surfaces updated: Settings scheduled-task rows, Run at editor, Thread Automations panel, mobile scheduled-task list/editor.
Checks run:
Browser tests:
(Ubuntu 26.04 needs the host-platform override once to fetch the ubuntu24.04 Chromium build.)
Test plan
… at HH:MM UTCAmerica/Los_Angeles) showsPDT/PST/GMT-7, notAmerica/Los_Angeles