Repository navigation
Conversation
* Refer to Enumerations Instead of Counting Them in OPERATIONS.md The carried Incidental Counts rule says text names an enumeration rather than stating its size, since a stated count is a second copy nothing keeps in sync. Each count that restated a list or table beside it now refers to the enumeration. The retention limit stays and names its sources, and fixed pairs keep "both". Renaming the log-tiers heading moves its anchor, so the one link to it in deploy/README.md follows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Name What Each Rewritten Reference Points At The local strict review found rewrites that lost their antecedent or widened their claim, and further counts beside their enumerations. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Say How the Explanatory Files Raise the Archive Count Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Let the Read Be the Check in the checks/ Gates That Probe First The carried Operations and Failure Messages rule says to attempt the operation and turn its failure into a clean refusal, rather than predicting it with an existence test. Each of these gates read a file after an exists() or is_file() probe. Each now reads directly and catches FileNotFoundError, keeping the message the probe gave. The robots.txt read moves ahead of the origin lookup so its except clause can hold the missing-file refusal, and its comment moves with it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Read Each Env Template Directly Too The strict review found the template loop probing with exists() before its read, the same class this change removes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
ptr727
added
the
comments
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues are identified, with the documentation references and direct-read gate updates aligned while preserving existing diagnostics and missing-file handling.
No open issues 🎉
What changed in this PR
This pull request promotes documentation-conformance updates and direct-read fixes for the repository’s operational checks, without changing deployed server behavior.
Changes:
- Removes incidental counts from
OPERATIONS.md, documents retention sources, and updates the log-tier anchor. - Updates the corresponding reference in
deploy/README.md. - Makes the environment, media redaction, text PII, and URL parity gates read files directly while preserving existing diagnostics and missing-file handling.
| File | Description |
|---|---|
OPERATIONS.md |
Removes incidental counts, names retention sources, and updates the log-tier heading. |
deploy/README.md |
Updates the log-tier link and removes an incidental count. |
checks/url_parity_gate.py |
Reads robots.txt and index.html directly with missing-file handling. |
checks/text_pii_gate.py |
Reads exclusion and allow-list files directly. |
checks/media_redactions_gate.py |
Reads declared media files directly before hashing. |
checks/env_docs_gate.py |
Reads environment documentation and templates directly. |
Review effort: Lite
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #574 +/- ##
==========================================
- Coverage 67.12% 66.95% -0.17%
==========================================
Files 11 11
Lines 2494 2503 +9
==========================================
+ Hits 1674 1676 +2
- Misses 820 827 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes two conformance fixes to
main.OPERATIONS.mdin line with the carried "Incidental Counts" rule. Each count that restated the size of a list or table beside it now refers to the enumeration, and the retention limit names its sources. Renaming the log-tiers heading moves its anchor, and the one link to it indeploy/README.mdfollows.checks/gates that probed first. The environment docs, media redactions, text PII, and URL parity gates each read directly and catchFileNotFoundError, and keep their messages.Nothing the server sends changes, so no deploy is owed.
Verification
python3 -m unittest discover -s checks/testspassed on Let the Read Be the Check in the checks/ Gates That Probe First #573's head, andurl_parity_gate.pypassed against a freshhugobuild.Issues
Closes #547
Closes #546
🤖 Generated with Claude Code