Repository navigation
Report Every Repair a Track Needs When Its State Holds One #1127
Description
Behavior
TrackProps holds one State per track. SetLanguage() can set ReMux for a language tag that does not match its IETF tag, and SetFlagsFromTitle() then overwrites State with SetFlags when the title names a flag that is not set.
So ProcessFile.HasMetadataErrors(TrackProps.StateType.ReMux) misses such a track. With ReMux and SetTrackFlags both off, the unrepaired-metadata report in RepairMetadataErrors() names only the track flags, and says nothing about the remux the language tag needs.
Reproduction shape
- Give a MkvMerge audio track the language
eng, the IETF tagde, and the titleCommentarywith the commentary flag unset. - Turn
ReMuxandSetTrackFlagsoff, then process the file. - The log reports "Track flags not set" only.
Expected
A track that needs more than one repair reports each one, for example by keeping the remux need apart from the flag state.
Found by the local review of the pull request for #1074, #1077 and #1116.
Activity
ptr727 commentedon Oct 31, 2026
Maintainer decision on the design:
TrackProps.Statekeeps only the track disposition, one value per track:None,Keep,Remove,Unsupported.[Flags]property,TrackProps.Actions, holds every action the track needs:SetLanguage,SetFlags,ReMux,ReEncode,DeInterlace. Actions are added and removed as needed, so one finding never erases another.AttributeActions(SetLanguage,SetFlags) change track metadata.StreamActions(ReMux,ReEncode,DeInterlace) rewrite the file.The reporting fix follows from this: a track that needs a remux and flags keeps both actions, so it is repaired and reported for each.