[ptr727]

Summary

Closes #1141 by keeping the current behavior and documenting it.

• Every step that rewrites a file writes through MkvMerge with InputOptions.Default(), which drops tags and attachments whatever RemoveTags says. That incidental removal keeps a tool from adding tags during processing.
• RemoveTags is the explicit, in-place MkvPropEdit removal for a file no MkvMerge pass rewrites.
• The lossless timestamp repair (setts) is the one rewrite with no MkvMerge pass. It is named as the exception, and the behavior question is filed as Decide Whether the Lossless Timestamp Repair Drops Tags Like Every Other Rewrite #1146.
• Cover art removal clears attachments in place whatever RemoveTags says, and that is stated too.

Changes: a paragraph in ARCHITECTURE.md "Remux and Container Steps", a note on the RemoveTags bullet in README.md, and a why-comment on MkvMergeBuilder.InputOptions.Default() (hence the comments label). No behavior change.

Verification

• CSharpier, dotnet build (0 warnings), and dotnet format style --verify-no-changes --severity=info pass. markdownlint and cspell pass in the pre-commit hook.
• prose_lint.py --diff is clean, with comment-added covered by the label.
• A local strict review pass checked each claim against the source and found the setts exception and the in-place attachment removal, which commit 6e8123a fixes. The re-review found nothing, and the pass is recorded.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 4 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: caea2444-f318-4d4e-a1f1-600910c567b0

Commits

Reviewing files that changed from the base of the PR and between e94db43 and 77c9c9a.

Files selected for processing: 3

• ARCHITECTURE.md
• PlexCleaner/MkvMergeBuilder.cs
• README.md

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can show, collapse, or hide each part of a finding: code, evidence, and all

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[ptr727]

A recorded local strict-review pass covers head 6e8123acd9b013ee6a30dc7511ab898544f44e33, the content this pull request carries at that commit against develop, and it recorded 0 findings.

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Document tag removal during MkvMerge rewrites

📝 Documentation 🕐 Less than 10 minutes

AI Description

• Clarify that MkvMerge rewrites drop tags and attachments regardless of RemoveTags.
• Document the lossless timestamp repair exception and in-place cover art removal.
• Add a code comment explaining why MkvMerge excludes metadata by default; behavior is unchanged.

Diagram

graph TD
  P["File processing"] --> D{"Output path?"}
  D -->|MkvMerge rewrite| M["Default input options"] --> X["Metadata dropped"]
  D -->|setts repair| S["FfMpeg timestamp repair"] --> K["Tags may persist"]
  D -->|explicit removal| E["MkvPropEdit cleanup"] --> X

Loading

High-Level Assessment

Documenting the existing behavior is appropriate for this PR. Changing MkvMerge options to honor RemoveTags would alter processing behavior and could retain tags added by other tools; the separate question of setts behavior can be addressed independently.

Files changed (3) +5 / -1

Documentation (3) +5 / -1

ARCHITECTURE.mdExplain metadata handling across rewrite paths +2/-0

Explain metadata handling across rewrite paths

• Documents MkvMerge's unconditional removal of tags and attachments across rewrite steps. Identifies the lossless timestamp repair exception and distinguishes in-place tag and cover art removal.

ARCHITECTURE.md

MkvMergeBuilder.csExplain the default metadata-exclusion options +2/-0

Explain the default metadata-exclusion options

• Adds a comment explaining that the existing input options prevent rewrites from carrying tool-added tags and points readers to the documented exception. No executable code changes.

PlexCleaner/MkvMergeBuilder.cs

README.mdClarify the scope of RemoveTags +1/-1

Clarify the scope of RemoveTags

• Notes alongside the setting that remuxes and re-encodes drop tags and attachments regardless of its value.

README.md

[Copilot]

🟡 Changes recommended

ARCHITECTURE.md inaccurately describes all cover-art removal as in-place, overlooking paths that remove attachments through MkvMerge rewrites.

1 open issue

• Clarify which cover-art removal paths use in-place attachment cleanup · New

What changed in this PR

This documentation-only pull request records existing metadata behavior for file rewrites: MkvMerge removes tags and attachments independently of RemoveTags, with lossless timestamp repair documented as an exception.

Changes:

• Documents rewrite behavior and the timestamp-repair exception in ARCHITECTURE.md.
• Clarifies RemoveTags behavior in README.md.
• Explains the rationale for default MkvMerge input options in MkvMergeBuilder.cs.

File	Summary
README.md	Documents that remuxes and re-encodes remove tags and attachments regardless of RemoveTags.
PlexCleaner/​MkvMergeBuilder.cs	Explains why default MkvMerge input options exclude tags and attachments.
ARCHITECTURE.md	Describes rewrite, timestamp-repair, and cover-art metadata behavior; includes a minor wording inconsistency about which cover-art paths remove attachments in place.

This pull request is ready to be approved.

_{Review effort: Lite}

[ptr727]

A recorded local strict-review pass covers head 77c9c9a9b05763f64b39ec455e90edce94c51e8f, the content this pull request carries at that commit against develop, and it recorded 0 findings.