[ptr727]

Summary

#1152 and #1145 changed user-visible behavior with no line in the 3.23 release entry. This adds them, found while preparing the 3.23 promotion #1156.

• An FFmpeg or HandBrake rewrite of an MKV file restores the IETF language tags, and fails before replacing the original when the tracks no longer match (Restore IETF Language Tags After Every FFmpeg or HandBrake Rewrite #1152).
• Every HandBrake run keeps the original subtitle tracks, so the re-encode repair's HandBrake fallback no longer converts them to ASS (Restore IETF Language Tags After Every FFmpeg or HandBrake Rewrite #1152).
• The .tmp* names beside a media file are reserved, and an uppercase extension rename goes through .rename.mkv rather than .tmp7 (Rename Uppercase Extensions Through an MKV Name and Reserve .tmp Names #1145).

Docs only, HISTORY.md.

Review

A local strict review pass covers this head. The first pass found the first wording overstated the track check and left out what happens to a .tmp* file. Each line was narrowed to what the code does, and the second pass found nothing.

Pre-existing findings, filed

• PlexCleaner/ProcessFile.cs ConvertUsingHandBrake(): correctness. Embedded closed captions are dropped by the re-encode repair's HandBrake fallback when RemoveClosedCaptions is off. Filed as Keep or Report Embedded Closed Captions in the HandBrake Re-Encode Fallback #1157.

Pre-existing findings, not filed

• PlexCleaner/Convert.cs HasSameTracks(): correctness. It compares track count, number, type, and ISO 639-2 language but not the IETF tag, so a swap of two same-type tracks with the same ISO language would go unseen. No tool on these paths reorders such tracks.

🤖 Generated with Claude Code

[ptr727]

A recorded local strict-review pass covers head 97bccd0a7b3dbccea35a29514ed764b86684f03e, the content this pull request carries at that commit against develop, and it recorded 0 findings.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 20 seconds.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 4155b0e2-1844-4d8c-a242-bb0884315203

Commits

Reviewing files that changed from the base of the PR and between 34153be and b3bd15f.

Files selected for processing: 1

• HISTORY.md

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can show, collapse, or hide each part of a finding: code, evidence, and all

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Document MKV tag restoration and reserved temporary names in 3.23

📝 Documentation 🕐 Less than 10 minutes

AI Description

• Document MKV language-tag restoration and the track checks that protect the original file.
• Clarify HandBrake subtitle preservation and reserved .tmp* names during uppercase-extension
 renames.

Diagram

graph TD
  A["MKV rewrite"] --> B{"Tracks match?"}
  B -->|Yes| C["Restore IETF tags"] --> D["Replace original"]
  B -->|No| E["Abort rewrite"]
  F["Uppercase rename"] --> G[".rename.mkv staging"] --> D
  H["Reserved .tmp* names"] -.->|Avoided by| G

Loading

High-Level Assessment

Adding focused lines to the existing 3.23 entry is appropriate for documenting previously shipped behavior. Separate documentation or code changes would add scope without improving these release notes.

Files changed (1) +5 / -0

Documentation (1) +5 / -0

HISTORY.mdAdd missing 3.23 release notes for rewrites and temporary names +5/-0

Add missing 3.23 release notes for rewrites and temporary names

• Documents MKV IETF language-tag restoration, the track check before replacement, and HandBrake subtitle preservation. Also warns that adjacent '.tmp*' names are reserved and explains why uppercase-extension renames use '.rename.mkv'.

HISTORY.md

[Copilot]

🟡 Changes recommended

An active documentation issue remains because HISTORY.md does not mention that RestoreLanguageTags() also requires output track numbers to match the original.

1 open issue

• Document track-order mismatches as a restore failure condition · New

What changed in this PR

This documentation-only pull request updates HISTORY.md with user-visible behavior changes for the 3.23 release.

Changes:

• Documents IETF language-tag restoration after FFmpeg and HandBrake rewrites.
• Documents subtitle preservation during HandBrake processing.
• Documents reserved .tmp* names and the .rename.mkv intermediate rename path.
• Review note: the track-validation description should also mention track-number mismatches.

File	Description
HISTORY.md	Adds 3.23 release-history entries for language restoration, HandBrake behavior, and reserved temporary names.

_{Review effort: Lite}

[ptr727]

A recorded local strict-review pass covers head b3bd15ff15935517ee67b3abb34ebc7aabe48c71, the content this pull request carries at that commit against develop, and it recorded 0 findings.