Repository navigation
Nothing tests the bootstrap loaders' kept-tree swap sequence #1767
Description
Activity
- added a commit that references this issue
on Sep 24, 2026 Note from the
windowslane, for whoever works this next. What now exercises the kept-tree swap sequence is intests/test_bootstrap.py, by option 2's shape, each loader's own functions driven against a scratch directory:TestKeptTreeHandling(bash, Linux) andTestPowerShellKeptTreeHandling(pwsh, both platforms) inject a failure at each rename and removal ofswap_in/Invoke-SwapInand of the cleanup, then assert which tree is left on disk.- The PowerShell class also runs
Get-Tree→Invoke-SwapIn→Invoke-Cleanupwith a stubbed download and extract, including a failed extract. - Test That the Directory the Skills Installer Registers Outlives the Run #2554, merged to develop, adds one case per loader that runs fetch →
install_skills/Invoke-SkillsInstall→ cleanup. Each asserts that the directory the installer registers is the kept tree and outlives the run. Running the installer ahead of the swap fails both cases.
What none of them does is option 1's end-to-end run of
mainwith a stubcurland a scratch HOME, so whether that is still owed is this issue's call.Claimed for the
wsllane (#2478), worked on this WSL2 Debian host.- Branch:
feature/wsl-1767 - Predicted file set:
tests/test_bootstrap.py, andhost-setup/bootstrap.shonly if the end-to-end run needs a seam
Any other group needing one of these files waits for this branch to merge.
- Branch:
- added a commit that references this issue
on Oct 8, 2026
The #1756 change gave
host-setup/bootstrap.shandbootstrap.ps1a kept tree with a staging, swap, and retire sequence. The sequence runs in this order:.newsibling..oldfirst and removed last..newor.oldon exit.Nothing executes that sequence in CI.
scripts/tests/test_bootstrap.pychecks the loaders statically, andscripts/tests/test_skills_install.pycovers only the Python installer. A change that reorders the steps would pass every check. Examples: swapping before an earlier stand-up step, or removing the old tree before the new one is in place.What follows
Options
bootstrap.shin a scratch HOME. Give it a stubcurlthat serves a local tarball, and stub tools that fail at a chosen step. Then assert on the tree left behind. Add the same test forbootstrap.ps1underpwsh.Found by the local strict review on the #1756 change.