Test That the Directory the Skills Installer Registers Outlives the Run

[ptr727]

Summary

Each loader's kept-tree path now runs as one sequence under a test: fetch, swap, skills install, cleanup. The installer in the fixture is the real wrapper (install-skills.sh or install-skills.ps1) beside a stand-in scripts/skills_install.py that records the ROOT it would pass to claude plugin marketplace add. Each test asserts that the recorded directory is the kept skills-tree, that it still holds the installer once the cleanup has run, and that no staging or retired tree is left beside it.

This is the test #1756 named as its done condition: the registered directory outlives the run, on both platforms. The kept-tree design itself landed in #1773.

Verification

• Windows, native: tests/test_bootstrap.py passes (68 passed, 32 skipped). The new PowerShell case runs the real bootstrap.ps1 functions under pwsh 7 on this host.
• Linux: in python:3.12-slim as a non-root user, TestKeptTreeHandling passes (20 tests). TestPowerShellKeptTreeHandling passes too (25 tests, 5 skipped), run under pwsh 7 copied from the PowerShell image.
• Mutation: swapping the installer ahead of the swap in each loader makes its test fail. The recorder then names skills-tree.new, the directory the cleanup removes. This was checked natively for bootstrap.ps1 and in the container for bootstrap.sh.
• Live host: on this Windows host, the projecttemplate-fleet marketplace's folder source is the kept tree under %LOCALAPPDATA%\host-setup\skills-tree. It is still there after the bootstrap run that registered it, with no .new or .old beside it.
• Checks: ruff check, ruff format, mypy, and the prose gate are clean. One local strict-review pass raised no findings.

Refs #1756

🤖 Generated with Claude Code

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

• Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: 2b6de829-ca17-42b2-ab3b-4b774b0dc96e

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

🔵 Needs a closer look

Escape temporary paths before embedding them in PowerShell test scripts.

0 open findings

What changed in this PR

Adds cross-platform regression tests verifying the skills installer registers the durable skills-tree.

Changes:

• Adds registration-recording fixtures and helpers.
• Tests Linux and PowerShell lifecycle cleanup.
• Verifies staging and retired trees are removed.

File	Description
tests/​test_bootstrap.py	Adds cross-platform kept-tree registration tests and harness support.

🧠 Review effort: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.40%. Comparing base (80b5f01) to head (8c97996).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #2554   +/-   ##
========================================
  Coverage    58.40%   58.40%           
========================================
  Files           16       16           
  Lines         8090     8090           
========================================
  Hits          4725     4725           
  Misses        3365     3365           

Flag	Coverage Δ
python-3.13	58.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ptr727]

Copilot's overview headline on aa8ce1b, "Escape temporary paths before embedding them in PowerShell test scripts" (which reported 0 open findings and opened no thread): real, fixed in 8c97996. The registration test quoted its fixture source and record paths into single-quoted PowerShell strings. With TMP set to a directory named o'brien, the previous version of the test fails and the fixed one passes, natively on Windows. The harness's run_loader now takes an environment, and the test reads both paths as $env:FIXTURE_SOURCE and $env:REGISTERED_RECORD. Sibling sweep: no other PowerShell body in the file quotes a filesystem path. The remaining single-quoted interpolations hold tree names, two literal -Dir values and tokens, and the menu harnesses take their paths as argv parameters. The bash sites put paths inside double quotes, and those classes are Linux-only and run under /tmp. A Windows path cannot contain a double quote either, so they are not the same defect.

[Copilot]

🟢 Approval recommended

No unresolved review issues were identified.

0 open findings

🧠 Review effort: Lite