Repository navigation
Run the Test Suite on windows-latest in the Pull Request Gate - #2555
Merged
Merged
Conversation
A windows-test job runs the hub's unittest suite on windows-latest from Git Bash, under Python 3.13, and the pull request aggregator now requires it beside validate. Windows is a supported fleet host, and the hub's tooling broke there unnoticed while only Linux ran the suite. The job is hub-only. The reusable validate-task.yml is unchanged, so no other repository's gate moves. Refs #1143 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ptr727
added
the
comments
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The new required Windows gate needs a successful hosted-runner suite run before final approval.
1 open finding
What changed in this PR
This PR adds Windows test coverage to the hub’s pull request gate without changing the reusable gate used by other repositories.
Changes:
- Runs the unit suite on
windows-latestwith Python 3.13 and Git Bash. - Requires both the existing validation job and the Windows job to pass under the unchanged required check.
| File | Description |
|---|---|
.github/workflows/test-pull-request.yml |
Adds the Windows test job and includes its result in the merge gate. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2555 +/- ##
========================================
Coverage 58.40% 58.40%
========================================
Files 16 16
Lines 8090 8090
========================================
Hits 4725 4725
Misses 3365 3365
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The first hosted run failed six TestCompositeActions cases. The repo gate's action reader falls back to uvx where PyYAML does not import, and the job had neither. The Linux leg gets uvx from setup-uv, and uvx is a declared host tool, so the job now installs it the same way. The job's comment states why the job exists rather than the history behind it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ptr727
added a commit
that referenced
this pull request
Oct 8, 2026
…Test Job (#2558) ## Summary Promotes two changes from the `windows` lane. - [#2554](#2554) adds a test for each loader (`bootstrap.sh` and `bootstrap.ps1`). Each one runs the kept-tree fetch, the swap, the skills install and the cleanup in order, and asserts that the directory the installer registers as the Claude Code marketplace is the kept `skills-tree` and still exists after the run. It passes natively on Windows and on Linux, and running the installer before the swap fails it. - [#2555](#2555) adds a hub-only `windows-test` job to `test-pull-request.yml`. It runs the suite on `windows-latest` from Git Bash with uv installed, and `check-workflow-status` now requires it. Its first green hosted run took about 196s for 2277 tests. The required check's name is unchanged, and no other repository's gate moves. Closes #1756 Closes #1143 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
windows-testjob to the hub's owntest-pull-request.yml. It runs the hub's unittest suite onwindows-latestfrom Git Bash under Python 3.13, andcheck-workflow-statusnow requires it besidevalidate. The required check's name does not change.This follows the maintainer's answer recorded on #1143: add a
windows-latestjob once the suite passes on Windows, which it has since #2488. The maintainer also chose to keep the job hub-only. The reusablevalidate-task.ymlandcatalog/snippets/workflows/test-pull-request.ymlare untouched, so no other repository's gate moves.Notes
unittest discover -s testsas the Linux leg, without coverage, since the Linux leg owns the Codecov report.validate-task.yml, setup-python v7.0.0 as incanonical-review-sweep.yml.spec/files.jsoncontract for this file is interface fidelity withrequiredJobKeys[check-workflow-status, validate], so an extra job conforms.Verification
scripts/docker_lint.py, pass. So doscripts/repo_gate.py(sha-pin included),spec/validate.py, and the prose gate with comments allowed.Refs #1143
🤖 Generated with Claude Code