Skip to content

Session Handoff [auto-2187]: Pair Nonstandard details Markup Correctly When Blanking the Overview Narrative per #2187 #2382

Closed

Description

@ptr727

Next steps, in priority order

  1. Fix Pair Nonstandard details Markup Correctly When Blanking the Overview Narrative #2187 in scripts/pr_review.py's overview-narrative blanking (mask_narrative and the DETAILS_TAG pairing it relies on). Work each of the issue's three cases: a narrative closed with a nonstandard spelling such as </details >, a <details/> opener inside the narrative, and the report order of a label seen both inside and outside the narrative. Each case is either handled with a test or declined with observed-format evidence that rules it out, per the issue's done line. Any widened close pattern matches only where HTML actually ends the element: the reverted attempt in the issue body matched a mid-line </details x>, let its [^>]* tail swallow a following opener or a ### Suppressed comments heading, and accepted non-HTML whitespace through Python's \s, so do not repeat it. Leave the details_spans readers (suppressed_blocks, outside_diff_blocks, previously_missed_blocks) no worse. Add the test the issue's comment asks for: an unclosed narrative followed by - **Confidence:** high reports that label, and confirm it fails against a mutation that blanks an unclosed narrative to the end of the body. Build every fixture from constructed text. Done looks like: each case handled or declined with evidence, the full unit suite, ruff, mypy, the prose gate, the repo gate, and spec/validate.py pass, and a local-strict-review pass is recorded at the pushed head.
  2. Drive the pull request into develop with Closes on promotion: #2187 in its body, scope develop.

External blockers

None known.

Internal dependencies

Step 2 follows step 1. #2372 (merged to develop for #2186, not yet promoted) changed details_spans in the same file, so base the work on current develop rather than main and build on that change.

State

No branch or worktree yet. Base the work on develop, per repo-worktree. The parked lane on track auto-2251 also targets scripts/pr_review.py and recorded no branch when it parked, so re-derive open pull requests and branches touching that file before starting.

The parked decision queue

None for this lane.

What the last round did

Nothing yet. The unattended picker created this lane from the open backlog.

What not to repeat

Nothing recorded yet beyond the reverted close pattern the issue body names.

New learnings

None yet.

Activity

  1. added
    handoffA link in the session handoff chain, one open issue per track
    on Oct 5, 2026
  2. ptr727 commented on Oct 5, 2026

    @ptr727
    OwnerAuthor

    Done. #2383 merged to develop as 5ae119b, carrying Closes on promotion: #2187, so #2187 closes when develop is promoted. All three cases in #2187 are handled with tests, and the unclosed-narrative test from its comment is added and proved against the mutation it names. Copilot raised two findings across three rounds, both on line-separator handling in the new close pattern, and both were fixed. Filed along the way: #2384, covering the preamble reader's tag boundary and the HTML closes still left unread, none of them regressions. The worktree and branch are removed. This lane is closed out with no successor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    handoffA link in the session handoff chain, one open issue per track

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions