Repository navigation
Emit an Unclosed details Block's Preceding Text Once in details_spans - #2372
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues remain.
Review effort: Lite
Findings: None
What changed in this PR
Fixes duplicate text extraction for unclosed top-level <details> blocks.
Changes:
- Advances the cursor to each unclosed opener.
- Adds regression coverage for truncated review bodies.
| File | Summary |
|---|---|
tests/test_pr_review.py |
Verifies suppressed findings appear only once. |
scripts/pr_review.py |
Prevents duplicated leftover spans. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2372 +/- ##
==========================================
Coverage ? 58.09%
==========================================
Files ? 16
Lines ? 7987
Branches ? 0
==========================================
Hits ? 4640
Misses ? 3347
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 4, 2026
ptr727
added a commit
that referenced
this pull request
Oct 5, 2026
…nd STANDUP Deploy Sources (#2411) ## Summary Promotes `develop` to `main` with sixteen pull requests, each already reviewed and merged into `develop`: - [#2368](#2368) Drop the Path Argument From the VS Code Tasks Snippet's Mypy Swaps. - [#2369](#2369) Match Wildcard and Shortened Rows in Copilot's File Table. - [#2372](#2372) Emit an Unclosed details Block's Preceding Text Once in details_spans. - [#2379](#2379) Exclude an Issue Only on a Fix-Intent Reference in the Unattended Picker. - [#2381](#2381) Refuse a Backslash Anywhere in carry.py's relative_root. - [#2383](#2383) Pair Nonstandard details Markup Correctly When Blanking the Overview Narrative. - [#2389](#2389) Drop Blog's Stale lineEndings driftNote From the Registry. - [#2391](#2391) State the Archive Registration in host-setup.md's Fleet Skills Install. - [#2393](#2393) Verify the Resolved Head on handoff.py's Read Path. - [#2397](#2397) Read the Closed Handoff List Once for a Closed Head. - [#2400](#2400) Bound DETAILS_TAG's Opener Tail at the Next Tag. - [#2404](#2404) Remove the Resolved Financial-Modeling markdownlint Entry From the Divergence Ledger. - [#2406](#2406) Format Only a Scalar Step Name or Shell in the Composite-Actions Check. - [#2408](#2408) Say the Hub Commits the Audit Report Wherever Done-Means-Audited Is Stated. - [#2409](#2409) Name the Three Sources in STANDUP.md's Deploy Prerequisite. - [#2413](#2413) Say Which Merge-Bot Proofs Are Tracked Rather Than an Audit Report Recording Them, the fix for this PR's CodeRabbit finding on `TODO.md`. ## Review Coverage CodeRabbit reviewed this PR at `73c9031c`. The one commit since, `92b0fb3d` from #2413, has parent `73c9031c` and the same tree as `0b371236`, the head CodeRabbit reviewed on #2413 with no actionable comments (`git rev-parse <commit>^{tree}` gives `83bd3d9f` for both). So CodeRabbit has read every line this PR carries. Closes #2157 Closes #2167 Closes #2186 Closes #2351 Closes #2246 Closes #2187 Closes #2279 Closes #2236 Closes #1500 Closes #2394 Closes #2386 Closes #1573 Closes #2357 Closes #1826 Closes #2270 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
details_spansappended the text before an unclosed top-level<details>once at the opener and again at end of body from the same cursor. The cursor now moves to the opener, so the final span continues the first. A test holds a suppressed section before a truncated block to one copy, and fails without the fix.Closes on promotion: #2186
🤖 Generated with Claude Code