Skip to content

Say Which Merge-Bot Proofs Are Tracked Rather Than an Audit Report Recording Them - #2413

Merged
ptr727 merged 2 commits into
developfrom
feature/pilot-proof-attribution
Oct 5, 2026
Merged

ptr727 merged 2 commits into
developfrom
feature/pilot-proof-attribution

Conversation

@ptr727

@ptr727 ptr727 commented Oct 5, 2026 •

Copy link
Copy Markdown
Owner

Summary

Verification

  • The prose gate on the diff, the eol gate, and markdownlint are clean. The two remaining --check sentence-length hits are sentences this change leaves unchanged.
  • local-strict-review ran twice. The first pass found the first rewrite assigned the rules and merge-app proofs to a pilot that cannot produce them. The second pass found nothing, and its receipt is recorded at the pushed head.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Clarified which behaviors the merge-bot pilot does not verify and which downstream adopters need to validate, including cross-repository pin resolution, the first Dependabot bump, end-to-end rules use, and merge-app.
    • Updated the adoption notes and added a reference to issue #2412.

ptr727 and others added 2 commits October 5, 2026 08:29
…ecording Them

TODO.md and docs/reusable-workflows.md said the hub's audit report on
the pilot records what the hub cannot prove, but the PhotoCleaner report
records none of it. Only the pin's resolution and its first bump are
tracked, as proof items under Stage 1. The three sentences now say the
pilot owes those proofs, TODO.md names merge-app as the fourth, and
Stage 1 names the two that are proof items.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The pilot cannot owe the rules input or merge-app proofs, having no
tracker and no App pull requests, and no tracker item owns them. Each
statement now says the pin's resolution and first bump are the Stage 1
proof items and #2412 tracks the other two, and "What a Pilot Proves"
gives the four to downstream adopters rather than the first one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 5, 2026 15:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review issues remain.

Review effort: Lite
Findings: None

What changed in this PR

Clarifies which merge-bot proofs are tracked and which require downstream follow-up.

Changes:

  • Updates proof-tracking language in TODO.md.
  • Corrects pilot and adopter guidance.
  • Links untracked proofs to issue #2412.
File Description
TODO.md Identifies tracked and untracked proofs.
docs/​reusable-workflows.md Clarifies pilot and downstream proof responsibilities.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used
📚 Code guidelines (2)
CODESTYLE.md — auto-discovered
RESYNC.md — auto-discovered

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e603c301-7590-4fe7-801b-fc6e666bc338
📥 Commits

Reviewing files that changed from the base of the PR and between 73c9031 and 0b37123.

📒 Files selected for processing (2)
  • TODO.md
  • docs/reusable-workflows.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Merge-Bot adoption notes distinguish pilot proof items from behaviors downstream adopters must prove. The notes include merge-app and end-to-end rules behavior among the downstream proof items and link to issue #2412.

Changes

Merge-Bot adoption documentation

Layer / File(s) Summary
Update Merge-Bot proof scope
docs/reusable-workflows.md, TODO.md
The notes list cross-repository pin resolution and the first Dependabot bump as pilot proof items. They assign four behaviors, including end-to-end rules behavior and merge-app, to downstream adopters and reference issue #2412.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 0b371

The proof responsibilities are consistent, and the follow-up link points to the relevant issue. No merge-blocking documentation risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 0b371

The change affects 2 systems.

Changed systems: docs, TODO.md

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — docs (service) was modified; 1 changed file maps to changed impact.
  • observed — TODO.md (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in TODO.md: The merge-bot detail now includes merge-app among the items the hub cannot prove and links the rules input and merge-app proof items to issue #2412.
  • observed — Modified behavior in TODO.md: Added the issue #2412 reference used by the merge-bot detail.
  • observed — Modified behavior in docs/reusable-workflows.md: The adoption description no longer lists rules support and the first Dependabot bump among the pilot’s proof items; it now identifies only cross-repository pin resolution and the first bump as proof items.
  • observed — Modified behavior in docs/reusable-workflows.md: The text now says downstream adopters must prove cross-repository pin resolution, Dependabot pin bumps, end-to-end rules behavior, and merge-app; it removes the statement that the pilot audit recorded these as observed and adds a reference to issue #2412.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: clarifying which merge-bot proofs are tracked rather than claiming the pilot audit report recorded them.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.34%. Comparing base (73c9031) to head (0b37123).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2413   +/-   ##
========================================
  Coverage    58.34%   58.34%           
========================================
  Files           16       16           
  Lines         8036     8036           
========================================
  Hits          4689     4689           
  Misses        3347     3347           
Flag Coverage Δ
python-3.13 58.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727

ptr727 commented Oct 5, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ptr727
ptr727 merged commit 92b0fb3 into develop Oct 5, 2026
13 checks passed
@ptr727
ptr727 deleted the feature/pilot-proof-attribution branch October 5, 2026 16:20
ptr727 added a commit that referenced this pull request Oct 5, 2026
…nd STANDUP Deploy Sources (#2411)

## Summary

Promotes `develop` to `main` with sixteen pull requests, each already
reviewed and merged into `develop`:

- [#2368](#2368) Drop the
Path Argument From the VS Code Tasks Snippet's Mypy Swaps.
- [#2369](#2369) Match
Wildcard and Shortened Rows in Copilot's File Table.
- [#2372](#2372) Emit an
Unclosed details Block's Preceding Text Once in details_spans.
- [#2379](#2379) Exclude
an Issue Only on a Fix-Intent Reference in the Unattended Picker.
- [#2381](#2381) Refuse a
Backslash Anywhere in carry.py's relative_root.
- [#2383](#2383) Pair
Nonstandard details Markup Correctly When Blanking the Overview
Narrative.
- [#2389](#2389) Drop
Blog's Stale lineEndings driftNote From the Registry.
- [#2391](#2391) State the
Archive Registration in host-setup.md's Fleet Skills Install.
- [#2393](#2393) Verify
the Resolved Head on handoff.py's Read Path.
- [#2397](#2397) Read the
Closed Handoff List Once for a Closed Head.
- [#2400](#2400) Bound
DETAILS_TAG's Opener Tail at the Next Tag.
- [#2404](#2404) Remove
the Resolved Financial-Modeling markdownlint Entry From the Divergence
Ledger.
- [#2406](#2406) Format
Only a Scalar Step Name or Shell in the Composite-Actions Check.
- [#2408](#2408) Say the
Hub Commits the Audit Report Wherever Done-Means-Audited Is Stated.
- [#2409](#2409) Name the
Three Sources in STANDUP.md's Deploy Prerequisite.
- [#2413](#2413) Say Which
Merge-Bot Proofs Are Tracked Rather Than an Audit Report Recording Them,
the fix for this PR's CodeRabbit finding on `TODO.md`.

## Review Coverage

CodeRabbit reviewed this PR at `73c9031c`. The one commit since,
`92b0fb3d` from #2413, has parent `73c9031c` and the same tree as
`0b371236`, the head CodeRabbit reviewed on #2413 with no actionable
comments (`git rev-parse <commit>^{tree}` gives `83bd3d9f` for both). So
CodeRabbit has read every line this PR carries.

Closes #2157
Closes #2167
Closes #2186
Closes #2351
Closes #2246
Closes #2187
Closes #2279
Closes #2236
Closes #1500
Closes #2394
Closes #2386
Closes #1573
Closes #2357
Closes #1826
Closes #2270

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants