Skip to content

Recognize Copilot's "Resolved Since Last Review" Overview Block in pr_review.py #2479

Closed as not planned

Description

@ptr727

Problem

scripts/pr_review.py wait (hub main) exits 43, UNRECOGNIZED_REVIEWER_OUTPUT, on a Copilot overview carrying a "resolved since last review" summary. Its status line reports:

UNRECOGNIZED REVIEWER OUTPUT (1): ...
  summary: 3 resolved since last review  (round <head>)

The shape is a collapsible block in the ccr-overview-v2 review body. It lists the threads that earlier rounds raised and that are now resolved, each as a severity badge and a link to its thread:

<details>
<summary><strong>3 resolved since last review</strong></summary>

- <picture>...Medium severity...</picture> [Finding title](#discussion_r<id>)
</details>

In the round that showed it, the block sat between **0 open findings** and a Previously missed (3) block, which the script already reads. The block carries no finding of its own: every entry links to a thread that is already resolved.

Done when

  • pr_review.py recognizes the "N resolved since last review" block as informational, so it neither counts its entries as findings nor fails the round as unrecognized.
  • A fixture of the shape, with constructed titles and ids, covers it.

Activity

  1. ptr727 commented on Oct 8, 2026

    @ptr727
    OwnerAuthor

    Folded into #2480 per #2517, approved by the maintainer. Both are Copilot collapsible overview blocks, fixed there through one recognizer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions