Repository navigation
Recognize Copilot's Collapsible "N Open Findings" Overview Block in pr_review.py #2480
Description
Problem
scripts/pr_review.py wait (hub main) exits 43, UNRECOGNIZED_REVIEWER_OUTPUT, on a Copilot ccr-overview-v2 review whose open findings sit in a collapsible block rather than on a bold line. The digest reports:
UNRECOGNIZED REVIEWER OUTPUT (1): ...
summary: 2 open findings (round <head>)
The block opens expanded and lists each open finding as a severity badge and a link to its thread:
<details open>
<summary><strong>2 open findings</strong></summary>
- <picture>...Medium severity...</picture> [Finding title](#discussion_r<id>) · New
- <picture>...Low severity...</picture> [Another title](#discussion_r<id>) · New
</details>The script already reads **0 open findings** as a bold line, and #2479 covers the sibling N resolved since last review block. In the round that showed this shape, both linked findings were also ordinary review threads, which the digest listed correctly, and the same body carried a What changed in this PR file table naming every changed file.
Done when
- The digest reads
<summary><strong>N open findings</strong></summary>as a known shape. - It checks that each linked
#discussion_r<id>entry matches a review thread, so a finding named only in this block is counted rather than passed.
Activity
ptr727 commentedon Oct 7, 2026
The singular form is unread too. A later round on another pull request exited 43 with
summary: 1 open finding (round <head>), from the same<summary><strong>1 open finding</strong></summary>block, so the reader needs to acceptfindingas well asfindings.ptr727 commentedon Oct 8, 2026
Another variant of this block, seen on #2508: with a single finding, the summary is singular,
<summary><strong>1 open finding</strong></summary>. pr_review.py reports it as the shape(N) open finding, separately from(N) open findings. A reader for this block should therefore accept both the singular and the plural noun.Promote develop to main: Skip or Run the Test Suite Cleanly on Windows (
ptr727 commentedon Oct 8, 2026
Folded in per #2517, approved by the maintainer: #2479 (the "Resolved Since Last Review" block) is the same defect class as this one, Copilot's collapsible overview blocks going unrecognized. Fix both shapes through one recognizer, per #2516's rule that a defect class seen a second time gets one primitive, with a test for each block shape.
Promote develop to main: Lock menu.ps1's Hub Cache Through hub.lock (#…
Read Copilot's Overview Sections Through One Recognizer in pr_review.…
Count an Open (N) Entry Carrying No Thread Link as Unthreaded (#2570)
Read Open-Section Thread Ids From Its Entries Alone (#2573)
Promote develop to main: Read Copilot's Overview Sections Through One…