Skip to content

Session Handoff [auto-2490]: Gate Prose on the Merge Commit's Own Base per #2490 #2526

Closed

Description

@ptr727

Next steps, in priority order

  1. Fix Gate Prose on the Merge Commit's Own Base, Not the Event's base.sha #2490 in one pull request to develop. The prose gate step in .github/workflows/validate-task.yml passes base: ${{ github.event.pull_request.base.sha }} while the job checks out GitHub's merge commit, so a base branch that moved after the event was recorded makes the gate scan other pull requests' lines. Diff against the base the checkout was built on, the merge commit's first parent, so the gate's scope equals the pull request's own change. Done looks like: a pull request whose base moved after its event is gated on its own diff only, a test or constructed run showing the gate's scope on a merge commit whose first parent differs from base.sha, and a body carrying Closes on promotion: #2490.
  2. Under scope main, promote that fix per the unattended worker's procedure.

External blockers

None known. Copilot and CodeRabbit availability is re-read live at the drive, per drive-pr.

Internal dependencies

The prose-gate composite action under .github/actions/ consumes the base input, so read how it resolves that input before choosing where the first-parent resolution happens. Keep the promotion-run behavior the step's comments describe, where a develop -> main run diffs against the default branch's tip.

State

No branch, worktree, or pull request yet. Open pull request #2523 targets develop on the Windows lane and touches no workflow file. Develop is two commits ahead of main.

The parked decision queue

Not applicable to this lane.

What the last round did

The unattended picker ranked #2490 as a correctness defect in a running gate that fails pull requests adding no violation, and opened this lane.

What not to repeat

Nothing yet.

New learnings

None yet.

Activity

  1. added
    handoffA link in the session handoff chain, one open issue per track
    on Oct 8, 2026
  2. ptr727 commented on Oct 8, 2026

    @ptr727
    OwnerAuthor

    Parked: waiting on decision #2533

    Done

    • Gate Prose on the Merge Commit's Own Base, Not the Event's base.sha #2490 is fixed in #2529, squash-merged to develop as afc77cb9.
      • The new Resolve prose base step in validate-task.yml diffs against the merge commit's first parent, and falls back to the event's base.sha when the checkout is no merge commit.
      • Tests are in TestTheGateDiffsAgainstTheMergeCommitsOwnBase in tests/test_prose_lint.py.
    • The feature/auto-2490 worktree, its local branch, and its remote branch are all removed, and the base clone is fast-forwarded to develop. No worktree was left standing.
    • The promotion pull request #2532 is open, from develop into main, at head afc77cb90d205d83dca33a99f9356beba9a7146c. Its body carries Fixes #2490.
      • Every check passes and mergeStateStatus is CLEAN.
      • Copilot reviewed that head. Both of its findings were declined with evidence and resolved.

    Remaining

    Resuming

    No lesson issue was filed.

  3. added
    blockedBlocked on another issue: one in another repository, or a decision issue here for a parked handoff
    on Oct 8, 2026
  4. ptr727 commented on Oct 8, 2026

    @ptr727
    OwnerAuthor

    Closed out. #2529 fixed #2490 into develop, and promotion #2532 merged to main as 2d5601d once the maintainer answered #2533 (merge over the unrecognized overview block #2480 tracks). #2490 is closed. Filed along the way: #2533. Lane complete, no successor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    blockedBlocked on another issue: one in another repository, or a decision issue here for a parked handoffhandoffA link in the session handoff chain, one open issue per track

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions